Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Unified Diff: chrome/browser/ui/cocoa/browser_window_cocoa.h

Issue 1827083004: UI: Rename MediaState to AlertState (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bluetooth-tab-indicator
Patch Set: Keep gypi ordered Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_tab_util.cc ('k') | chrome/browser/ui/cocoa/browser_window_cocoa.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/browser_window_cocoa.h
diff --git a/chrome/browser/ui/cocoa/browser_window_cocoa.h b/chrome/browser/ui/cocoa/browser_window_cocoa.h
index a6629e2250cc45af02c610762ef1ebcb76128167..da9b2d90ef133911cb8b78a3505b7c84d200bd94 100644
--- a/chrome/browser/ui/cocoa/browser_window_cocoa.h
+++ b/chrome/browser/ui/cocoa/browser_window_cocoa.h
@@ -165,19 +165,21 @@ class BrowserWindowCocoa
// Adds the given FindBar cocoa controller to this browser window.
void AddFindBar(FindBarCocoaController* find_bar_cocoa_controller);
- // Update window media state to show if one of the tabs within the window is
- // playing an audio/video or even if it's playing something but it's muted.
- void UpdateMediaState(TabMediaState media_state);
+ // Updates the window's alert state. If the new alert state is
+ // TabAlertState::AUDIO_PLAYING or TabAlertState::AUDIO_MUTING then sets
+ // the window's title to reflect that.
+ void UpdateAlertState(TabAlertState alert_state);
// Returns the cocoa-world BrowserWindowController
BrowserWindowController* cocoa_controller() { return controller_; }
- // Returns window title based on the active tab title and window media state.
+ // Returns window title based on the active tab title and the window's alert
+ // state.
NSString* WindowTitle();
- // Returns current media state, determined by the media state of tabs, set by
- // UpdateMediaState.
- TabMediaState media_state() { return media_state_; }
+ // Returns the current alert state, determined by the alert state of tabs. Set
+ // by UpdateAlertState.
+ TabAlertState alert_state() { return alert_state_; }
protected:
void DestroyBrowser() override;
@@ -191,10 +193,10 @@ class BrowserWindowCocoa
ui::WindowShowState initial_show_state_;
NSInteger attention_request_id_; // identifier from requestUserAttention
- // Preserves window media state to show appropriate icon in the window title
- // which can be audio playing, muting or none (determined by media state of
+ // Preserves window alert state to show appropriate icon in the window title
+ // which can be audio playing, muting or none (determined by alert state of
// tabs.
- TabMediaState media_state_;
+ TabAlertState alert_state_;
};
#endif // CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_COCOA_H_
« no previous file with comments | « chrome/browser/extensions/extension_tab_util.cc ('k') | chrome/browser/ui/cocoa/browser_window_cocoa.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698