Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1826953002: Fix a regression where the tab-modal signin flow wasn't shown. (Closed)

Created:
4 years, 9 months ago by apacible
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Fix a regression where the tab-modal signin flow wasn't shown. https://codereview.chromium.org/1781433002 changed some of the constrained_window code and updated some callers, but not the tab-modal signin flow. The modal was being created but not shown. BUG=593091, 217034 Review URL: https://codereview.chromium.org/1815433002 Cr-Commit-Position: refs/heads/master@{#381778} (cherry picked from commit 4588b6b41a9356338c1c2a2eea3bf11fb8647a35) Committed: https://chromium.googlesource.com/chromium/src/+/8ef11436d4619a1292803a29f2623df4f2f44bf6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/ui/cocoa/profiles/signin_view_controller_delegate_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
apacible
4 years, 9 months ago (2016-03-23 23:16:26 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8ef11436d4619a1292803a29f2623df4f2f44bf6.

Powered by Google App Engine
This is Rietveld 408576698