[Reland] Enable AutoResize for Constrained Web Dialogs for Mac.

[Reland] Enable AutoResize for Constrained Web Dialogs for Mac.

Currently only constrained web dialogs for views (Linux/Windows) are able to
autoresize. This change implements the option to pass in minimum and maximum
sizes and enabling autoresizing functionality for OSX.

This change adds two static functions for options on whether to create a
ConstrainedWindowsMac that autoresizes or is of fixed size.

The first two patches were reverted because of flaky tests on Mac 10.9.

Those patches can be found at:
1. https://codereview.chromium.org/1430023002
2. https://codereview.chromium.org/1446623003

After some investigation, we found that the failures are being caused by an occlusion notifications in cocoa, which is not expected in browser tests. This is currently mac-only. By disabling these notifications in browser tests, we see this patch passing on the swarming bots that were previously failing. See http://crbug/558585.

The patch to disable occlusion notifications can be found at:
https://codereview.chromium.org/1762883002/

The third patch (same as second patch) broke dialogs like print preview. This was because the change used ui::kWindowSizeDeterminedLater for the dialog window's frame for all constrained web dialogs on mac, not just autoresizable dialogs. That has been amended in this change. That patch can be found here: https://codereview.chromium.org/1699763002/

BUG=217034
Committed: https://crrev.com/740c4109f954a11c544c02132a89fabab767e7ab
Cr-Commit-Position: refs/heads/master@{#380352}

[apacible, 2016-03-08 18:45:48]

Description was changed from

==========
autoresizing take four

BUG=
==========

to

==========
[Reland] Enable AutoResize for Constrained Web Dialogs for Mac.

Currently only constrained web dialogs for views (Linux/Windows) are able to
autoresize. This change implements the option to pass in minimum and maximum
sizes and enabling autoresizing functionality for OSX.

This change adds two static functions for options on whether to create a
ConstrainedWindowsMac that autoresizes or is of fixed size.

The first two patches were reverted because of flaky tests on Mac 10.9.

Those patches can be found at:
1. https://codereview.chromium.org/1430023002
2. https://codereview.chromium.org/1446623003

After some investigation, we found that the failures are being caused by an
occlusion notifications in cocoa, which is not expected in browser tests. This
is currently mac-only. By disabling these notifications in browser tests, we see
this patch passing on the swarming bots that were previously failing. See
http://crbug/558585.

The patch to disable occlusion notifications can be found at:
https://codereview.chromium.org/1762883002/

The third patch, which mirrored the second one, landed successfully (waterfall
stayed green), but also presented a few issues not found in the second patch
set. While most of the dialogs (e.g. extension installation) were OK, the change
broke print preview. That patch can be found here:
https://codereview.chromium.org/1699763002/

This current CL starts with the first patch (which did not introduce breakages
on existing dialogs) and makes its way through the feedback in the second patch
to find where the issues were introduced. Besides running try bots, each patch
set is also manually tested to ensure the dialogs are properly rendered.\

BUG=217034
==========

[apacible, 2016-03-08 18:46:13]

Description was changed from

==========
[Reland] Enable AutoResize for Constrained Web Dialogs for Mac.

Currently only constrained web dialogs for views (Linux/Windows) are able to
autoresize. This change implements the option to pass in minimum and maximum
sizes and enabling autoresizing functionality for OSX.

This change adds two static functions for options on whether to create a
ConstrainedWindowsMac that autoresizes or is of fixed size.

The first two patches were reverted because of flaky tests on Mac 10.9.

Those patches can be found at:
1. https://codereview.chromium.org/1430023002
2. https://codereview.chromium.org/1446623003

After some investigation, we found that the failures are being caused by an
occlusion notifications in cocoa, which is not expected in browser tests. This
is currently mac-only. By disabling these notifications in browser tests, we see
this patch passing on the swarming bots that were previously failing. See
http://crbug/558585.

The patch to disable occlusion notifications can be found at:
https://codereview.chromium.org/1762883002/

The third patch, which mirrored the second one, landed successfully (waterfall
stayed green), but also presented a few issues not found in the second patch
set. While most of the dialogs (e.g. extension installation) were OK, the change
broke print preview. That patch can be found here:
https://codereview.chromium.org/1699763002/

This current CL starts with the first patch (which did not introduce breakages
on existing dialogs) and makes its way through the feedback in the second patch
to find where the issues were introduced. Besides running try bots, each patch
set is also manually tested to ensure the dialogs are properly rendered.\

BUG=217034
==========

to

==========
[Reland] Enable AutoResize for Constrained Web Dialogs for Mac.

Currently only constrained web dialogs for views (Linux/Windows) are able to
autoresize. This change implements the option to pass in minimum and maximum
sizes and enabling autoresizing functionality for OSX.

This change adds two static functions for options on whether to create a
ConstrainedWindowsMac that autoresizes or is of fixed size.

The first two patches were reverted because of flaky tests on Mac 10.9.

Those patches can be found at:
1. https://codereview.chromium.org/1430023002
2. https://codereview.chromium.org/1446623003

After some investigation, we found that the failures are being caused by an
occlusion notifications in cocoa, which is not expected in browser tests. This
is currently mac-only. By disabling these notifications in browser tests, we see
this patch passing on the swarming bots that were previously failing. See
http://crbug/558585.

The patch to disable occlusion notifications can be found at:
https://codereview.chromium.org/1762883002/

The third patch, which mirrored the second one, landed successfully (waterfall
stayed green), but also presented a few issues not found in the second patch
set. While most of the dialogs (e.g. extension installation) were OK, the change
broke print preview. That patch can be found here:
https://codereview.chromium.org/1699763002/

This current CL starts with the first patch (which did not introduce breakages
on existing dialogs) and makes its way through the feedback in the second patch
to find where the issues were introduced. Besides running try bots, each patch
set is also manually tested to ensure the dialog contents are properly rendered.

BUG=217034
==========

[apacible, 2016-03-08 18:54:47]

Description was changed from

==========
[Reland] Enable AutoResize for Constrained Web Dialogs for Mac.

Currently only constrained web dialogs for views (Linux/Windows) are able to
autoresize. This change implements the option to pass in minimum and maximum
sizes and enabling autoresizing functionality for OSX.

This change adds two static functions for options on whether to create a
ConstrainedWindowsMac that autoresizes or is of fixed size.

The first two patches were reverted because of flaky tests on Mac 10.9.

Those patches can be found at:
1. https://codereview.chromium.org/1430023002
2. https://codereview.chromium.org/1446623003

After some investigation, we found that the failures are being caused by an
occlusion notifications in cocoa, which is not expected in browser tests. This
is currently mac-only. By disabling these notifications in browser tests, we see
this patch passing on the swarming bots that were previously failing. See
http://crbug/558585.

The patch to disable occlusion notifications can be found at:
https://codereview.chromium.org/1762883002/

The third patch, which mirrored the second one, landed successfully (waterfall
stayed green), but also presented a few issues not found in the second patch
set. While most of the dialogs (e.g. extension installation) were OK, the change
broke print preview. That patch can be found here:
https://codereview.chromium.org/1699763002/

This current CL starts with the first patch (which did not introduce breakages
on existing dialogs) and makes its way through the feedback in the second patch
to find where the issues were introduced. Besides running try bots, each patch
set is also manually tested to ensure the dialog contents are properly rendered.

BUG=217034
==========

to

==========
[Reland] Enable AutoResize for Constrained Web Dialogs for Mac.

Currently only constrained web dialogs for views (Linux/Windows) are able to
autoresize. This change implements the option to pass in minimum and maximum
sizes and enabling autoresizing functionality for OSX.

This change adds two static functions for options on whether to create a
ConstrainedWindowsMac that autoresizes or is of fixed size.

The first two patches were reverted because of flaky tests on Mac 10.9.

Those patches can be found at:
1. https://codereview.chromium.org/1430023002
2. https://codereview.chromium.org/1446623003

After some investigation, we found that the failures are being caused by an
occlusion notifications in cocoa, which is not expected in browser tests. This
is currently mac-only. By disabling these notifications in browser tests, we see
this patch passing on the swarming bots that were previously failing. See
http://crbug/558585.

The patch to disable occlusion notifications can be found at:
https://codereview.chromium.org/1762883002/

The third patch, which mirrored the second one, landed successfully (waterfall
stayed green), but also presented a few issues not found in the second patch
set. While most of the dialogs (e.g. extension installation) were OK, the change
broke print preview. That patch can be found here:
https://codereview.chromium.org/1699763002/

This current CL starts with the first patch (which did not introduce breakages
on existing dialogs) and makes its way through the feedback in the second patch
to find where the issues were introduced. Besides running try bots, each patch
set is also manually tested.

BUG=217034
==========

[apacible, 2016-03-08 22:40:17]

Patchset #3 (id:40001) has been deleted

[apacible, 2016-03-09 00:35:25]

Patchset #3 (id:60001) has been deleted

[apacible, 2016-03-09 00:35:43]

Patchset #2 (id:20001) has been deleted

[apacible, 2016-03-09 02:15:55]

Patchset #3 (id:100001) has been deleted

[apacible, 2016-03-09 02:21:14]

Description was changed from

==========
[Reland] Enable AutoResize for Constrained Web Dialogs for Mac.

Currently only constrained web dialogs for views (Linux/Windows) are able to
autoresize. This change implements the option to pass in minimum and maximum
sizes and enabling autoresizing functionality for OSX.

This change adds two static functions for options on whether to create a
ConstrainedWindowsMac that autoresizes or is of fixed size.

The first two patches were reverted because of flaky tests on Mac 10.9.

Those patches can be found at:
1. https://codereview.chromium.org/1430023002
2. https://codereview.chromium.org/1446623003

After some investigation, we found that the failures are being caused by an
occlusion notifications in cocoa, which is not expected in browser tests. This
is currently mac-only. By disabling these notifications in browser tests, we see
this patch passing on the swarming bots that were previously failing. See
http://crbug/558585.

The patch to disable occlusion notifications can be found at:
https://codereview.chromium.org/1762883002/

The third patch, which mirrored the second one, landed successfully (waterfall
stayed green), but also presented a few issues not found in the second patch
set. While most of the dialogs (e.g. extension installation) were OK, the change
broke print preview. That patch can be found here:
https://codereview.chromium.org/1699763002/

This current CL starts with the first patch (which did not introduce breakages
on existing dialogs) and makes its way through the feedback in the second patch
to find where the issues were introduced. Besides running try bots, each patch
set is also manually tested.

BUG=217034
==========

to

==========
[Reland] Enable AutoResize for Constrained Web Dialogs for Mac.

Currently only constrained web dialogs for views (Linux/Windows) are able to
autoresize. This change implements the option to pass in minimum and maximum
sizes and enabling autoresizing functionality for OSX.

This change adds two static functions for options on whether to create a
ConstrainedWindowsMac that autoresizes or is of fixed size.

The first two patches were reverted because of flaky tests on Mac 10.9.

Those patches can be found at:
1. https://codereview.chromium.org/1430023002
2. https://codereview.chromium.org/1446623003

After some investigation, we found that the failures are being caused by an
occlusion notifications in cocoa, which is not expected in browser tests. This
is currently mac-only. By disabling these notifications in browser tests, we see
this patch passing on the swarming bots that were previously failing. See
http://crbug/558585.

The patch to disable occlusion notifications can be found at:
https://codereview.chromium.org/1762883002/

The third patch, which mirrored the second one, landed successfully (waterfall
stayed green), but also presented an issue that wasn't caught; dialogs like
print preview were broken. This was because the change used
ui::kWindowSizeDeterminedLater for the dialog window's frame for all constrained
web dialogs on mac, not just autoresizable dialogs. That has been amended in
this change. That patch can be found here:
https://codereview.chromium.org/1699763002/

This current CL starts with the final changes in the first CL and each
subsequent patch set is based on feedback from the other CLs so that it's easy
to follow along.

BUG=217034
==========

[apacible, 2016-03-09 02:22:50]

Description was changed from

==========
[Reland] Enable AutoResize for Constrained Web Dialogs for Mac.

Currently only constrained web dialogs for views (Linux/Windows) are able to
autoresize. This change implements the option to pass in minimum and maximum
sizes and enabling autoresizing functionality for OSX.

This change adds two static functions for options on whether to create a
ConstrainedWindowsMac that autoresizes or is of fixed size.

The first two patches were reverted because of flaky tests on Mac 10.9.

Those patches can be found at:
1. https://codereview.chromium.org/1430023002
2. https://codereview.chromium.org/1446623003

After some investigation, we found that the failures are being caused by an
occlusion notifications in cocoa, which is not expected in browser tests. This
is currently mac-only. By disabling these notifications in browser tests, we see
this patch passing on the swarming bots that were previously failing. See
http://crbug/558585.

The patch to disable occlusion notifications can be found at:
https://codereview.chromium.org/1762883002/

The third patch, which mirrored the second one, landed successfully (waterfall
stayed green), but also presented an issue that wasn't caught; dialogs like
print preview were broken. This was because the change used
ui::kWindowSizeDeterminedLater for the dialog window's frame for all constrained
web dialogs on mac, not just autoresizable dialogs. That has been amended in
this change. That patch can be found here:
https://codereview.chromium.org/1699763002/

This current CL starts with the final changes in the first CL and each
subsequent patch set is based on feedback from the other CLs so that it's easy
to follow along.

BUG=217034
==========

to

==========
[Reland] Enable AutoResize for Constrained Web Dialogs for Mac.

Currently only constrained web dialogs for views (Linux/Windows) are able to
autoresize. This change implements the option to pass in minimum and maximum
sizes and enabling autoresizing functionality for OSX.

This change adds two static functions for options on whether to create a
ConstrainedWindowsMac that autoresizes or is of fixed size.

The first two patches were reverted because of flaky tests on Mac 10.9.

Those patches can be found at:
1. https://codereview.chromium.org/1430023002
2. https://codereview.chromium.org/1446623003

After some investigation, we found that the failures are being caused by an
occlusion notifications in cocoa, which is not expected in browser tests. This
is currently mac-only. By disabling these notifications in browser tests, we see
this patch passing on the swarming bots that were previously failing. See
http://crbug/558585.

The patch to disable occlusion notifications can be found at:
https://codereview.chromium.org/1762883002/

The third patch (same as second patch) broke dialogs like print preview. This
was because the change used ui::kWindowSizeDeterminedLater for the dialog
window's frame for all constrained web dialogs on mac, not just autoresizable
dialogs. That has been amended in this change. That patch can be found here:
https://codereview.chromium.org/1699763002/

This CL starts with the final changes in the first CL and each subsequent patch
set is based on feedback from the other CLs so that it's easy to follow along.

BUG=217034
==========

[apacible, 2016-03-09 20:05:37]

Patchset #3 (id:90027) has been deleted

[apacible, 2016-03-09 20:54:36]

Description was changed from

==========
[Reland] Enable AutoResize for Constrained Web Dialogs for Mac.

Currently only constrained web dialogs for views (Linux/Windows) are able to
autoresize. This change implements the option to pass in minimum and maximum
sizes and enabling autoresizing functionality for OSX.

This change adds two static functions for options on whether to create a
ConstrainedWindowsMac that autoresizes or is of fixed size.

The first two patches were reverted because of flaky tests on Mac 10.9.

Those patches can be found at:
1. https://codereview.chromium.org/1430023002
2. https://codereview.chromium.org/1446623003

After some investigation, we found that the failures are being caused by an
occlusion notifications in cocoa, which is not expected in browser tests. This
is currently mac-only. By disabling these notifications in browser tests, we see
this patch passing on the swarming bots that were previously failing. See
http://crbug/558585.

The patch to disable occlusion notifications can be found at:
https://codereview.chromium.org/1762883002/

The third patch (same as second patch) broke dialogs like print preview. This
was because the change used ui::kWindowSizeDeterminedLater for the dialog
window's frame for all constrained web dialogs on mac, not just autoresizable
dialogs. That has been amended in this change. That patch can be found here:
https://codereview.chromium.org/1699763002/

This CL starts with the final changes in the first CL and each subsequent patch
set is based on feedback from the other CLs so that it's easy to follow along.

BUG=217034
==========

to

==========
[Reland] Enable AutoResize for Constrained Web Dialogs for Mac.

Currently only constrained web dialogs for views (Linux/Windows) are able to
autoresize. This change implements the option to pass in minimum and maximum
sizes and enabling autoresizing functionality for OSX.

This change adds two static functions for options on whether to create a
ConstrainedWindowsMac that autoresizes or is of fixed size.

The first two patches were reverted because of flaky tests on Mac 10.9.

Those patches can be found at:
1. https://codereview.chromium.org/1430023002
2. https://codereview.chromium.org/1446623003

After some investigation, we found that the failures are being caused by an
occlusion notifications in cocoa, which is not expected in browser tests. This
is currently mac-only. By disabling these notifications in browser tests, we see
this patch passing on the swarming bots that were previously failing. See
http://crbug/558585.

The patch to disable occlusion notifications can be found at:
https://codereview.chromium.org/1762883002/

The third patch (same as second patch) broke dialogs like print preview. This
was because the change used ui::kWindowSizeDeterminedLater for the dialog
window's frame for all constrained web dialogs on mac, not just autoresizable
dialogs. That has been amended in this change. That patch can be found here:
https://codereview.chromium.org/1699763002/

BUG=217034
==========

[apacible, 2016-03-09 21:01:35]

apacible@chromium.org changed reviewers:
+ thakis@chromium.org

[apacible, 2016-03-09 21:01:36]

This CL starts with the final changes in the first autoresizing CL and
subsequent patch sets are based on feedback from the second CL so that it's easy
to follow along. See description for CL links, reasons for reverting, and fixes.

I also fixed a bug (patch set 4) where switching tabs or resizing the browser
window will make an autoresizing dialog 'disappear'.

PTAL, thank you!

[Nico, 2016-03-09 23:59:46]

still lgtm

(is there a test that would've found the print preview regression?)

[apacible, 2016-03-10 01:31:17]

On 2016/03/09 23:59:46, Nico wrote:
> still lgtm
> 
> (is there a test that would've found the print preview regression?)

Thanks!

(I don't think so. The contents 'show up' but are constrained to a tiny frame. I
saw it crash a few times locally though; I'm surprised none of the browser tests
crashed.)

[apacible, 2016-03-10 02:09:26]

Patchset #6 (id:190001) has been deleted

[apacible, 2016-03-10 02:09:36]

Patchset #6 (id:210001) has been deleted

[apacible, 2016-03-10 06:04:29]

The CQ bit was checked by apacible@chromium.org

[apacible, 2016-03-10 06:04:29]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1781433002/#ps250001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-03-10 06:04:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1781433002/250001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1781433002/250001

[commit-bot: I haz the power, 2016-03-10 06:10:44]

Description was changed from

==========
[Reland] Enable AutoResize for Constrained Web Dialogs for Mac.

Currently only constrained web dialogs for views (Linux/Windows) are able to
autoresize. This change implements the option to pass in minimum and maximum
sizes and enabling autoresizing functionality for OSX.

This change adds two static functions for options on whether to create a
ConstrainedWindowsMac that autoresizes or is of fixed size.

The first two patches were reverted because of flaky tests on Mac 10.9.

Those patches can be found at:
1. https://codereview.chromium.org/1430023002
2. https://codereview.chromium.org/1446623003

After some investigation, we found that the failures are being caused by an
occlusion notifications in cocoa, which is not expected in browser tests. This
is currently mac-only. By disabling these notifications in browser tests, we see
this patch passing on the swarming bots that were previously failing. See
http://crbug/558585.

The patch to disable occlusion notifications can be found at:
https://codereview.chromium.org/1762883002/

The third patch (same as second patch) broke dialogs like print preview. This
was because the change used ui::kWindowSizeDeterminedLater for the dialog
window's frame for all constrained web dialogs on mac, not just autoresizable
dialogs. That has been amended in this change. That patch can be found here:
https://codereview.chromium.org/1699763002/

BUG=217034
==========

to

==========
[Reland] Enable AutoResize for Constrained Web Dialogs for Mac.

Currently only constrained web dialogs for views (Linux/Windows) are able to
autoresize. This change implements the option to pass in minimum and maximum
sizes and enabling autoresizing functionality for OSX.

This change adds two static functions for options on whether to create a
ConstrainedWindowsMac that autoresizes or is of fixed size.

The first two patches were reverted because of flaky tests on Mac 10.9.

Those patches can be found at:
1. https://codereview.chromium.org/1430023002
2. https://codereview.chromium.org/1446623003

After some investigation, we found that the failures are being caused by an
occlusion notifications in cocoa, which is not expected in browser tests. This
is currently mac-only. By disabling these notifications in browser tests, we see
this patch passing on the swarming bots that were previously failing. See
http://crbug/558585.

The patch to disable occlusion notifications can be found at:
https://codereview.chromium.org/1762883002/

The third patch (same as second patch) broke dialogs like print preview. This
was because the change used ui::kWindowSizeDeterminedLater for the dialog
window's frame for all constrained web dialogs on mac, not just autoresizable
dialogs. That has been amended in this change. That patch can be found here:
https://codereview.chromium.org/1699763002/

BUG=217034
==========

[commit-bot: I haz the power, 2016-03-10 06:10:45]

Committed patchset #7 (id:250001)

[commit-bot: I haz the power, 2016-03-10 06:12:13]

Description was changed from

==========
[Reland] Enable AutoResize for Constrained Web Dialogs for Mac.

Currently only constrained web dialogs for views (Linux/Windows) are able to
autoresize. This change implements the option to pass in minimum and maximum
sizes and enabling autoresizing functionality for OSX.

This change adds two static functions for options on whether to create a
ConstrainedWindowsMac that autoresizes or is of fixed size.

The first two patches were reverted because of flaky tests on Mac 10.9.

Those patches can be found at:
1. https://codereview.chromium.org/1430023002
2. https://codereview.chromium.org/1446623003

After some investigation, we found that the failures are being caused by an
occlusion notifications in cocoa, which is not expected in browser tests. This
is currently mac-only. By disabling these notifications in browser tests, we see
this patch passing on the swarming bots that were previously failing. See
http://crbug/558585.

The patch to disable occlusion notifications can be found at:
https://codereview.chromium.org/1762883002/

The third patch (same as second patch) broke dialogs like print preview. This
was because the change used ui::kWindowSizeDeterminedLater for the dialog
window's frame for all constrained web dialogs on mac, not just autoresizable
dialogs. That has been amended in this change. That patch can be found here:
https://codereview.chromium.org/1699763002/

BUG=217034
==========

to

==========
[Reland] Enable AutoResize for Constrained Web Dialogs for Mac.

Currently only constrained web dialogs for views (Linux/Windows) are able to
autoresize. This change implements the option to pass in minimum and maximum
sizes and enabling autoresizing functionality for OSX.

This change adds two static functions for options on whether to create a
ConstrainedWindowsMac that autoresizes or is of fixed size.

The first two patches were reverted because of flaky tests on Mac 10.9.

Those patches can be found at:
1. https://codereview.chromium.org/1430023002
2. https://codereview.chromium.org/1446623003

After some investigation, we found that the failures are being caused by an
occlusion notifications in cocoa, which is not expected in browser tests. This
is currently mac-only. By disabling these notifications in browser tests, we see
this patch passing on the swarming bots that were previously failing. See
http://crbug/558585.

The patch to disable occlusion notifications can be found at:
https://codereview.chromium.org/1762883002/

The third patch (same as second patch) broke dialogs like print preview. This
was because the change used ui::kWindowSizeDeterminedLater for the dialog
window's frame for all constrained web dialogs on mac, not just autoresizable
dialogs. That has been amended in this change. That patch can be found here:
https://codereview.chromium.org/1699763002/

BUG=217034

Committed: https://crrev.com/740c4109f954a11c544c02132a89fabab767e7ab
Cr-Commit-Position: refs/heads/master@{#380352}
==========

[commit-bot: I haz the power, 2016-03-10 06:12:14]

Patchset 7 (id:??) landed as
https://crrev.com/740c4109f954a11c544c02132a89fabab767e7ab
Cr-Commit-Position: refs/heads/master@{#380352}