Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1815433002: Fix a regression where the tab-modal signin flow wasn't shown. (Closed)

Created:
4 years, 9 months ago by anthonyvd
Modified:
4 years, 9 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a regression where the tab-modal signin flow wasn't shown. https://codereview.chromium.org/1781433002 changed some of the constrained_window code and updated some callers, but not the tab-modal signin flow. The modal was being created but not shown. BUG=593091, 217034 Committed: https://crrev.com/4588b6b41a9356338c1c2a2eea3bf11fb8647a35 Cr-Commit-Position: refs/heads/master@{#381778}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/ui/cocoa/profiles/signin_view_controller_delegate_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
anthonyvd
Hi Robert, can you please take a look at this small fix? This doesn't seem ...
4 years, 9 months ago (2016-03-17 19:10:46 UTC) #1
anthonyvd
Forgot to actually add you as a reviewer...
4 years, 9 months ago (2016-03-17 19:11:27 UTC) #3
Robert Sesek
lgtm
4 years, 9 months ago (2016-03-17 19:12:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1815433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1815433002/1
4 years, 9 months ago (2016-03-17 19:13:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 19:50:15 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 19:51:22 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4588b6b41a9356338c1c2a2eea3bf11fb8647a35
Cr-Commit-Position: refs/heads/master@{#381778}

Powered by Google App Engine
This is Rietveld 408576698