Switch new SkImageFilter internal methods over to sk_sp

Switch new SkImageFilter internal methods over to sk_sp

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1826893002

Committed: https://skia.googlesource.com/skia/+/2302de920e5434809bd0e85b871a6e002856dfdb

[robertphillips, 2016-03-23 20:00:52]

Description was changed from

==========
Switch SkImageFilter internal methods over to sk_sp

BUG=skia:
==========

to

==========
Switch SkImageFilter internal methods over to sk_sp

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-03-23 20:03:56]

Description was changed from

==========
Switch SkImageFilter internal methods over to sk_sp

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Switch new SkImageFilter internal methods over to sk_sp

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-03-23 20:03:56]

robertphillips@google.com changed reviewers:
+ reed@google.com

[reed1, 2016-03-23 20:06:57]

lgtm

https://codereview.chromium.org/1826893002/diff/1/include/core/SkImageFilter.h
File include/core/SkImageFilter.h (right):

https://codereview.chromium.org/1826893002/diff/1/include/core/SkImageFilter....
include/core/SkImageFilter.h:427: sk_sp<SkSpecialImage> applyCropRect(const
Context&, SkSpecialImage* src, SkIPoint* srcOffset,
do we ref src, or just inspect it?

[robertphillips, 2016-03-23 20:18:38]

https://codereview.chromium.org/1826893002/diff/1/include/core/SkImageFilter.h
File include/core/SkImageFilter.h (right):

https://codereview.chromium.org/1826893002/diff/1/include/core/SkImageFilter....
include/core/SkImageFilter.h:427: sk_sp<SkSpecialImage> applyCropRect(const
Context&, SkSpecialImage* src, SkIPoint* srcOffset,
On 2016/03/23 20:06:55, reed1 wrote:
> do we ref src, or just inspect it?

We can ref it sometimes (and return the refed pointer). I will make a separate
pass to update the parameters to all these methods.

[robertphillips, 2016-03-23 20:18:46]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-23 20:18:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1826893002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1826893002/1

[commit-bot: I haz the power, 2016-03-23 20:36:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-23 20:36:23]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-03-24 13:44:23]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-24 13:44:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1826893002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1826893002/20001

[commit-bot: I haz the power, 2016-03-24 14:01:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-24 14:01:13]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-03-24 14:25:05]

The CQ bit was checked by robertphillips@google.com

[robertphillips, 2016-03-24 14:25:05]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1826893002/#ps20001
(title: "Change method name to drawSpriteWithFilter")

[commit-bot: I haz the power, 2016-03-24 14:25:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1826893002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1826893002/20001

[commit-bot: I haz the power, 2016-03-24 14:26:36]

Description was changed from

==========
Switch new SkImageFilter internal methods over to sk_sp

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Switch new SkImageFilter internal methods over to sk_sp

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/2302de920e5434809bd0e85b871a6e002856dfdb
==========

[commit-bot: I haz the power, 2016-03-24 14:26:37]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/2302de920e5434809bd0e85b871a6e002856dfdb