Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1826863002: Add unit test for vertex attribute count. (Closed)

Created:
4 years, 9 months ago by bsalomon
Modified:
4 years, 9 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -2 lines) Patch
M src/gpu/GrGpu.h View 4 chunks +6 lines, -1 line 0 comments Download
M src/gpu/GrGpu.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/glsl/GrGLSLGeometryProcessor.h View 2 chunks +1 line, -1 line 0 comments Download
A tests/PrimitiveProcessorTest.cpp View 1 1 chunk +155 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
bsalomon
4 years, 9 months ago (2016-03-23 18:19:47 UTC) #3
robertphillips
lgtm
4 years, 9 months ago (2016-03-23 18:37:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826863002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826863002/20001
4 years, 9 months ago (2016-03-23 18:38:12 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 18:50:29 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/1d417a8738304c115f3547ecc34dda7a7d75b97a

Powered by Google App Engine
This is Rietveld 408576698