Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1826753002: Log the expected icon size when no suitable icon for a banner is found. (Closed)

Created:
4 years, 9 months ago by dominickn
Modified:
4 years, 9 months ago
Reviewers:
gone
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Log the expected icon size when no suitable icon for a banner is found. This CL improves the debug messaging for developers when an app banner cannot be displayed due to an icon which is too small. The existing messaging ("no suitable icon can be found") is split into two cases: when all available icons are too small, and when the selected icon cannot be fetched. In the former case, the exact required icon size (respecting the device scale factor, which means a different sized icon may be required on different platforms) is printed to console to better inform developers of the icon requirements. BUG=595517 Committed: https://crrev.com/bf032db305e5391644d614cc151a6599f8b0fbf6 Cr-Commit-Position: refs/heads/master@{#383196}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -19 lines) Patch
M chrome/browser/banners/app_banner_data_fetcher.cc View 2 chunks +11 lines, -2 lines 0 comments Download
M chrome/browser/banners/app_banner_debug_log.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/banners/app_banner_debug_log.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/manifest/manifest_icon_selector.h View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/manifest/manifest_icon_selector.cc View 5 chunks +17 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
dominickn
PTAL, thanks!
4 years, 9 months ago (2016-03-23 04:30:53 UTC) #3
gone
lgtm
4 years, 9 months ago (2016-03-24 19:05:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826753002/1
4 years, 9 months ago (2016-03-24 23:18:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-25 00:06:56 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 00:08:59 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf032db305e5391644d614cc151a6599f8b0fbf6
Cr-Commit-Position: refs/heads/master@{#383196}

Powered by Google App Engine
This is Rietveld 408576698