chrome/browser/banners/app_banner_debug_log.h - Issue 1826753002: Log the expected icon size when no suitable icon for a banner is found.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/banners/app_banner_debug_log.h

Issue 1826753002: Log the expected icon size when no suitable icon for a banner is found. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/banners/app_banner_debug_log.h

diff --git a/chrome/browser/banners/app_banner_debug_log.h b/chrome/browser/banners/app_banner_debug_log.h

index a4a601a9aee0ce0d7b25585fe85e01705e4a1683..ca742690118d15b3023d38ee135f43f6e8ef5db6 100644

--- a/chrome/browser/banners/app_banner_debug_log.h

+++ b/chrome/browser/banners/app_banner_debug_log.h

@@ -17,7 +17,8 @@ namespace banners {

extern const char kRendererRequestCancel[];

extern const char kManifestEmpty[];

extern const char kNoManifest[];

-extern const char kCannotDetermineBestIcon[];

+extern const char kNoIconMatchingRequirements[];

+extern const char kCannotDownloadIcon[];

extern const char kNoMatchingServiceWorker[];

extern const char kNoIconAvailable[];

extern const char kUserNavigatedBeforeBannerShown[];

« no previous file with comments | « chrome/browser/banners/app_banner_data_fetcher.cc ('k') | chrome/browser/banners/app_banner_debug_log.cc » ('j') | no next file with comments »