Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Side by Side Diff: chrome/browser/banners/app_banner_debug_log.cc

Issue 1826753002: Log the expected icon size when no suitable icon for a banner is found. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/banners/app_banner_debug_log.h" 5 #include "chrome/browser/banners/app_banner_debug_log.h"
6 6
7 #include "content/public/browser/render_frame_host.h" 7 #include "content/public/browser/render_frame_host.h"
8 #include "content/public/browser/web_contents.h" 8 #include "content/public/browser/web_contents.h"
9 9
10 namespace banners { 10 namespace banners {
11 11
12 const char kRendererRequestCancel[] = 12 const char kRendererRequestCancel[] =
13 "renderer has requested the banner prompt be cancelled"; 13 "renderer has requested the banner prompt be cancelled";
14 const char kManifestEmpty[] = 14 const char kManifestEmpty[] =
15 "manifest could not be fetched, is empty, or could not be parsed"; 15 "manifest could not be fetched, is empty, or could not be parsed";
16 const char kNoManifest[] = "site has no manifest <link> URL"; 16 const char kNoManifest[] = "site has no manifest <link> URL";
17 const char kCannotDetermineBestIcon[] = 17 // The required size is prepended.
18 "could not determine the best icon to use"; 18 const char kNoIconMatchingRequirements[] =
19 "px square icon is required, but no supplied icon is at least this size";
20 const char kCannotDownloadIcon[] = "could not download the specified icon";
19 const char kNoMatchingServiceWorker[] = 21 const char kNoMatchingServiceWorker[] =
20 "no matching service worker detected. You may need to reload the page, or " 22 "no matching service worker detected. You may need to reload the page, or "
21 "check that the service worker for the current page also controls the " 23 "check that the service worker for the current page also controls the "
22 "start URL from the manifest"; 24 "start URL from the manifest";
23 const char kNoIconAvailable[] = "no icon available to display"; 25 const char kNoIconAvailable[] = "no icon available to display";
24 const char kUserNavigatedBeforeBannerShown[] = 26 const char kUserNavigatedBeforeBannerShown[] =
25 "the user navigated before the banner could be shown"; 27 "the user navigated before the banner could be shown";
26 const char kStartURLNotValid[] = "start URL in manifest is not valid"; 28 const char kStartURLNotValid[] = "start URL in manifest is not valid";
27 const char kManifestMissingNameOrShortName[] = 29 const char kManifestMissingNameOrShortName[] =
28 "one of manifest name or short name must be specified"; 30 "one of manifest name or short name must be specified";
(...skipping 21 matching lines...) Expand all
50 void OutputDeveloperDebugMessage(content::WebContents* web_contents, 52 void OutputDeveloperDebugMessage(content::WebContents* web_contents,
51 const std::string& message, 53 const std::string& message,
52 bool is_debug_mode) { 54 bool is_debug_mode) {
53 if (!is_debug_mode || !web_contents) 55 if (!is_debug_mode || !web_contents)
54 return; 56 return;
55 web_contents->GetMainFrame()->AddMessageToConsole( 57 web_contents->GetMainFrame()->AddMessageToConsole(
56 content::CONSOLE_MESSAGE_LEVEL_DEBUG, "App banner " + message); 58 content::CONSOLE_MESSAGE_LEVEL_DEBUG, "App banner " + message);
57 } 59 }
58 60
59 } // namespace banners 61 } // namespace banners
OLDNEW
« no previous file with comments | « chrome/browser/banners/app_banner_debug_log.h ('k') | chrome/browser/manifest/manifest_icon_selector.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698