Fix of quick disappearing of password bubble when autofill happens.

Fix of quick disappearing of password bubble when autofill happens.

If passowrd bubble is in one states PENDING_PASSWORD_STATE, PENDING_PASSWORD_UPDATE_STATE or CONFIRMATION_STATE then not to turn it to MANAGED_STATE when autofill happens.

BUG=593325
Committed: https://crrev.com/f89c67271a18d8b6ae96a410e6999f2d61f3b26c
Cr-Commit-Position: refs/heads/master@{#383058}

[dvadym, 2016-03-22 14:51:38]

dvadym@chromium.org changed reviewers:
+ vasilii@chromium.org

[dvadym, 2016-03-22 14:51:39]

Hi Vasilii,

 Could you please review this CL?

Regards,
Vadym

[vasilii, 2016-03-22 15:42:48]

Please move the fix entirely to ManagePasswordsUIController. Instead of the
current state analyse |bubble_status_| as in
ManagePasswordsUIController::DidNavigateMainFrame.

[dvadym, 2016-03-24 11:53:36]

Thanks Vasilii for comments. I've moved implementation to controller. PTAL.

[vasilii, 2016-03-24 12:40:20]

lgtm

Remove ManagePasswordsBubbleViewTest.CloseOnChangedState

[dvadym, 2016-03-24 12:51:01]

On 2016/03/24 12:40:20, vasilii wrote:
> lgtm
> 
> Remove ManagePasswordsBubbleViewTest.CloseOnChangedState

Thanks for review! Test ManagePasswordsBubbleViewTest.CloseOnChangedState is
removed.

[dvadym, 2016-03-24 12:52:01]

Description was changed from

==========
Fix of quick disappearing of password bubble when autofill happens.

If passowrd bubble is in one of pending states (PENDING_PASSWORD_STATE or
PENDING_PASSWORD_UPDATE_STATE) then not to turn it to MANAGED_STATE when
autofill happens.

BUG=593325
==========

to

==========
Fix of quick disappearing of password bubble when autofill happens.

If passowrd bubble is in one states PENDING_PASSWORD_STATE,
PENDING_PASSWORD_UPDATE_STATE or CONFIRMATION_STATE then not to turn it to
MANAGED_STATE when autofill happens.

BUG=593325
==========

[dvadym, 2016-03-24 13:22:18]

The CQ bit was checked by dvadym@chromium.org

[dvadym, 2016-03-24 13:22:19]

The patchset sent to the CQ was uploaded after l-g-t-m from vasilii@chromium.org
Link to the patchset: https://codereview.chromium.org/1826473002/#ps100001
(title: "UI test removed")

[commit-bot: I haz the power, 2016-03-24 13:22:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1826473002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1826473002/100001

[commit-bot: I haz the power, 2016-03-24 13:33:56]

Description was changed from

==========
Fix of quick disappearing of password bubble when autofill happens.

If passowrd bubble is in one states PENDING_PASSWORD_STATE,
PENDING_PASSWORD_UPDATE_STATE or CONFIRMATION_STATE then not to turn it to
MANAGED_STATE when autofill happens.

BUG=593325
==========

to

==========
Fix of quick disappearing of password bubble when autofill happens.

If passowrd bubble is in one states PENDING_PASSWORD_STATE,
PENDING_PASSWORD_UPDATE_STATE or CONFIRMATION_STATE then not to turn it to
MANAGED_STATE when autofill happens.

BUG=593325
==========

[commit-bot: I haz the power, 2016-03-24 13:33:57]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-03-24 13:35:23]

Description was changed from

==========
Fix of quick disappearing of password bubble when autofill happens.

If passowrd bubble is in one states PENDING_PASSWORD_STATE,
PENDING_PASSWORD_UPDATE_STATE or CONFIRMATION_STATE then not to turn it to
MANAGED_STATE when autofill happens.

BUG=593325
==========

to

==========
Fix of quick disappearing of password bubble when autofill happens.

If passowrd bubble is in one states PENDING_PASSWORD_STATE,
PENDING_PASSWORD_UPDATE_STATE or CONFIRMATION_STATE then not to turn it to
MANAGED_STATE when autofill happens.

BUG=593325

Committed: https://crrev.com/f89c67271a18d8b6ae96a410e6999f2d61f3b26c
Cr-Commit-Position: refs/heads/master@{#383058}
==========

[commit-bot: I haz the power, 2016-03-24 13:35:24]

Patchset 6 (id:??) landed as
https://crrev.com/f89c67271a18d8b6ae96a410e6999f2d61f3b26c
Cr-Commit-Position: refs/heads/master@{#383058}