Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1402)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

Issue 1826473002: Fix of quick disappearing of password bubble when autofill happens. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: UI test removed Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc b/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
index dace6bef9ee6aca2fc07750908468131e8b9e1a6..6eac8fc74f1e60d27c0f9949e5b3eb80bdd12ce8 100644
--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
@@ -151,14 +151,10 @@ void ManagePasswordsUIController::OnPasswordAutofilled(
const autofill::PasswordFormMap& password_form_map,
const GURL& origin,
const std::vector<scoped_ptr<autofill::PasswordForm>>* federated_matches) {
- // If we fill a form while a dialog is open, then skip the state change; we
- // have
- // the information we need, and the dialog will change its own state once the
- // interaction is complete.
- if (passwords_data_.state() !=
- password_manager::ui::AUTO_SIGNIN_STATE &&
- passwords_data_.state() !=
- password_manager::ui::CREDENTIAL_REQUEST_STATE) {
+ // To change to managed state only when the managed state is more important
+ // for the user that the current state.
+ if (passwords_data_.state() == password_manager::ui::INACTIVE_STATE ||
+ passwords_data_.state() == password_manager::ui::MANAGE_STATE) {
passwords_data_.OnPasswordAutofilled(password_form_map, origin,
federated_matches);
UpdateBubbleAndIconVisibility();
« no previous file with comments | « no previous file | chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698