Fix of quick disappearing of password bubble when autofill happens.

chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <utility>
 #include <vector>
 
 #include "base/bind.h"
 #include "base/macros.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 162 matching lines @@
   void ExpectIconStateIs(password_manager::ui::State state);
   void ExpectIconAndControllerStateIs(password_manager::ui::State state);
 
   scoped_ptr<password_manager::PasswordFormManager>
   CreateFormManagerWithBestMatches(
       const autofill::PasswordForm& observed_form,
       ScopedVector<autofill::PasswordForm> best_matches);
 
   scoped_ptr<password_manager::PasswordFormManager> CreateFormManager();
 
+  // Tests that the state is not changed when the password is autofilled.
+  void TestNotChangingStateOnAutofill(
+      password_manager::ui::State state);
+
  private:
   password_manager::StubPasswordManagerClient client_;
   password_manager::StubPasswordManagerDriver driver_;
   password_manager::PasswordManager password_manager_;
 
   autofill::PasswordForm test_local_form_;
   autofill::PasswordForm test_federated_form_;
   scoped_ptr<password_manager::CredentialInfo> credential_info_;
   base::FieldTrialList field_trial_list_;
   DialogPromptMock dialog_prompt_;
@@ skipping 48 matching lines @@
 }
 
 scoped_ptr<password_manager::PasswordFormManager>
 ManagePasswordsUIControllerTest::CreateFormManager() {
   ScopedVector<autofill::PasswordForm> stored_forms;
   stored_forms.push_back(new autofill::PasswordForm(test_local_form()));
   return CreateFormManagerWithBestMatches(test_local_form(),
                                           std::move(stored_forms));
 }
 
+void ManagePasswordsUIControllerTest::TestNotChangingStateOnAutofill(
+    password_manager::ui::State state) {
+  DCHECK(state == password_manager::ui::PENDING_PASSWORD_STATE ||
+         state == password_manager::ui::PENDING_PASSWORD_UPDATE_STATE ||
+         state == password_manager::ui::CONFIRMATION_STATE);
+
+  // Set the bubble state to |state|.
+  scoped_ptr<password_manager::PasswordFormManager> test_form_manager(
+      CreateFormManager());
+  test_form_manager->ProvisionallySave(
+      test_local_form(),
+      password_manager::PasswordFormManager::IGNORE_OTHER_POSSIBLE_USERNAMES);
+  if (state == password_manager::ui::PENDING_PASSWORD_STATE)
+    controller()->OnPasswordSubmitted(std::move(test_form_manager));
+  else if (state == password_manager::ui::PENDING_PASSWORD_UPDATE_STATE)
+    controller()->OnUpdatePasswordSubmitted(std::move(test_form_manager));
+  else // password_manager::ui::CONFIRMATION_STATE
+    controller()->OnAutomaticPasswordSave(std::move(test_form_manager));
+  ASSERT_EQ(state, controller()->GetState());
+
+  // Autofill happens.
+  scoped_ptr<autofill::PasswordForm> test_form(
+      new autofill::PasswordForm(test_local_form()));
+  autofill::PasswordFormMap map;
+  map.insert(
+      std::make_pair(test_local_form().username_value, std::move(test_form)));
+  controller()->OnPasswordAutofilled(map, map.begin()->second->origin, nullptr);
+
+  // State shouldn't changed.
+  EXPECT_EQ(state, controller()->GetState());
+  ExpectIconStateIs(state);
+}
+
 TEST_F(ManagePasswordsUIControllerTest, DefaultState) {
   EXPECT_EQ(password_manager::ui::INACTIVE_STATE, controller()->GetState());
   EXPECT_EQ(GURL::EmptyGURL(), controller()->GetOrigin());
 
   ExpectIconStateIs(password_manager::ui::INACTIVE_STATE);
 }
 
 TEST_F(ManagePasswordsUIControllerTest, PasswordAutofilled) {
   scoped_ptr<autofill::PasswordForm> test_form(
       new autofill::PasswordForm(test_local_form()));
@@ skipping 448 matching lines @@
       CreateFormManager());
   test_form_manager->ProvisionallySave(
       test_local_form(),
       password_manager::PasswordFormManager::IGNORE_OTHER_POSSIBLE_USERNAMES);
   controller()->OnUpdatePasswordSubmitted(std::move(test_form_manager));
 
   ExpectIconStateIs(password_manager::ui::PENDING_PASSWORD_UPDATE_STATE);
   controller()->UpdatePassword(autofill::PasswordForm());
   ExpectIconStateIs(password_manager::ui::MANAGE_STATE);
 }
+
+TEST_F(ManagePasswordsUIControllerTest, SavePendingStatePasswordAutofilled) {
+  TestNotChangingStateOnAutofill(password_manager::ui::PENDING_PASSWORD_STATE);
+}
+
+TEST_F(ManagePasswordsUIControllerTest, UpdatePendingStatePasswordAutofilled) {
+  TestNotChangingStateOnAutofill(
+      password_manager::ui::PENDING_PASSWORD_UPDATE_STATE);
+}
+
+TEST_F(ManagePasswordsUIControllerTest, ConfirmationStatePasswordAutofilled) {
+  TestNotChangingStateOnAutofill(password_manager::ui::CONFIRMATION_STATE);
+}