[Media Router] Moves mojo-specific code into mojo/ folder

[Media Router] Moves mojo-specific code into mojo/ folder

This moves code specific to the Mojo-based implementation of MR into a separate folder.  As part of this change:

- Component-specific MediaRouterMetrics are split into MediaRouterMetricsMojo
- Mojo-specific mocks are moved into media_router_mojo_test.{h,cc}
- Various #ifdef defined(OS_ANDROID) are removed

Also, updates TODOs to remove dependencies on mojo/ from UI code.

NOTE: media_router.mojom remains outside the mojo/ folder until dependencies from the extensions system can be updated.

BUG=596999
Committed: https://crrev.com/66389721bebe73b5de231cea0672b0f436acea8c
Cr-Commit-Position: refs/heads/master@{#384442}

[mark a. foltz, 2016-03-24 23:23:12]

Description was changed from

==========
[Media Router] Moves mojo-specific code into mojo/ folder

This moves code specific to the Mojo-based implementation of MR into a separate
folder.  As part of this change:

- Component-specific MediaRouterMetrics are split into MediaRouterMetricsMojo
- Mojo-specific mocks are moved into media_router_mojo_test.{h,cc}
- Various #ifdef defined(OS_ANDROID) are removed

Also, adds a DEPS file to prevent new external dependencies on the Mojo
implementation of MR, and updates TODOs to remove existing ones.

BUG=596999
==========

to

==========
[Media Router] Moves mojo-specific code into mojo/ folder

This moves code specific to the Mojo-based implementation of MR into a separate
folder.  As part of this change:

- Component-specific MediaRouterMetrics are split into MediaRouterMetricsMojo
- Mojo-specific mocks are moved into media_router_mojo_test.{h,cc}
- Various #ifdef defined(OS_ANDROID) are removed

Also, updates TODOs to remove dependencies on mojo/ from UI code.

BUG=596999
==========

[mark a. foltz, 2016-03-24 23:28:30]

mfoltz@chromium.org changed reviewers:
+ benwells@chromium.org, sky@chromium.org, wez@chromium.org

[mark a. foltz, 2016-03-24 23:28:31]

benwells@: PTAL at c/b/extensions
sky@: PTAL at c/b/ui/toolbar
wez@: PTAL at everything else

[sky, 2016-03-25 15:35:47]

c/b/ui/toolbar LGTM

[Wez, 2016-03-29 00:16:16]

lgtm

https://codereview.chromium.org/1826403002/diff/1/chrome/browser/media/router...
File chrome/browser/media/router/media_router_metrics.h (right):

https://codereview.chromium.org/1826403002/diff/1/chrome/browser/media/router...
chrome/browser/media/router/media_router_metrics.h:17: // NOTE: For metrics
specific to the Media Router component, see
Do you mean "Media Router component extension"?

[benwells, 2016-03-29 06:55:09]

lgtm

[mark a. foltz, 2016-03-30 23:30:52]

The CQ bit was checked by mfoltz@chromium.org

[mark a. foltz, 2016-03-30 23:30:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
benwells@chromium.org, sky@chromium.org, wez@chromium.org
Link to the patchset: https://codereview.chromium.org/1826403002/#ps40001
(title: "Respond to wez@ comments")

[commit-bot: I haz the power, 2016-03-30 23:31:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1826403002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1826403002/40001

[commit-bot: I haz the power, 2016-03-30 23:47:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-30 23:47:06]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[mark a. foltz, 2016-03-31 00:09:58]

The CQ bit was checked by mfoltz@chromium.org

[mark a. foltz, 2016-03-31 00:09:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
benwells@chromium.org, sky@chromium.org, wez@chromium.org
Link to the patchset: https://codereview.chromium.org/1826403002/#ps60001
(title: "Remove unneeded #include to fix compile")

[commit-bot: I haz the power, 2016-03-31 00:16:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1826403002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1826403002/60001

[commit-bot: I haz the power, 2016-03-31 00:52:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 00:52:12]

Try jobs failed on following builders:
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mark a. foltz, 2016-03-31 05:20:46]

The CQ bit was checked by mfoltz@chromium.org

[commit-bot: I haz the power, 2016-03-31 05:21:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1826403002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1826403002/60001

[commit-bot: I haz the power, 2016-03-31 05:46:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 05:46:27]

Try jobs failed on following builders:
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mark a. foltz, 2016-03-31 17:05:25]

The CQ bit was checked by mfoltz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-31 17:05:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1826403002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1826403002/80001

[commit-bot: I haz the power, 2016-03-31 17:26:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 17:26:34]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)

[mark a. foltz, 2016-03-31 21:16:57]

Description was changed from

==========
[Media Router] Moves mojo-specific code into mojo/ folder

This moves code specific to the Mojo-based implementation of MR into a separate
folder.  As part of this change:

- Component-specific MediaRouterMetrics are split into MediaRouterMetricsMojo
- Mojo-specific mocks are moved into media_router_mojo_test.{h,cc}
- Various #ifdef defined(OS_ANDROID) are removed

Also, updates TODOs to remove dependencies on mojo/ from UI code.

BUG=596999
==========

to

==========
[Media Router] Moves mojo-specific code into mojo/ folder

This moves code specific to the Mojo-based implementation of MR into a separate
folder.  As part of this change:

- Component-specific MediaRouterMetrics are split into MediaRouterMetricsMojo
- Mojo-specific mocks are moved into media_router_mojo_test.{h,cc}
- Various #ifdef defined(OS_ANDROID) are removed

Also, updates TODOs to remove dependencies on mojo/ from UI code.

NOTE: media_router.mojom remains outside the mojo/ folder until dependencies
from the extensions system can be updated.

BUG=596999
==========

[mark a. foltz, 2016-03-31 23:58:09]

FYI

I reverted the change to move media_router.mojom as there are several references
in extensions/ that I want to address separately.  The current PS passes the
trybots except for mac_chromium_rel, which seems to be having issues today.

Committing now; feel free to look but there were straightforward changes to
#includes for media_router.mojom.

[mark a. foltz, 2016-03-31 23:58:20]

The CQ bit was checked by mfoltz@chromium.org

[mark a. foltz, 2016-03-31 23:58:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
benwells@chromium.org, sky@chromium.org, wez@chromium.org
Link to the patchset: https://codereview.chromium.org/1826403002/#ps80001
(title: "Revert change to media_router.mojom to fix compile")

[commit-bot: I haz the power, 2016-03-31 23:58:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1826403002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1826403002/80001

[commit-bot: I haz the power, 2016-04-01 00:08:47]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-04-01 00:11:37]

Description was changed from

==========
[Media Router] Moves mojo-specific code into mojo/ folder

This moves code specific to the Mojo-based implementation of MR into a separate
folder.  As part of this change:

- Component-specific MediaRouterMetrics are split into MediaRouterMetricsMojo
- Mojo-specific mocks are moved into media_router_mojo_test.{h,cc}
- Various #ifdef defined(OS_ANDROID) are removed

Also, updates TODOs to remove dependencies on mojo/ from UI code.

NOTE: media_router.mojom remains outside the mojo/ folder until dependencies
from the extensions system can be updated.

BUG=596999
==========

to

==========
[Media Router] Moves mojo-specific code into mojo/ folder

This moves code specific to the Mojo-based implementation of MR into a separate
folder.  As part of this change:

- Component-specific MediaRouterMetrics are split into MediaRouterMetricsMojo
- Mojo-specific mocks are moved into media_router_mojo_test.{h,cc}
- Various #ifdef defined(OS_ANDROID) are removed

Also, updates TODOs to remove dependencies on mojo/ from UI code.

NOTE: media_router.mojom remains outside the mojo/ folder until dependencies
from the extensions system can be updated.

BUG=596999

Committed: https://crrev.com/66389721bebe73b5de231cea0672b0f436acea8c
Cr-Commit-Position: refs/heads/master@{#384442}
==========

[commit-bot: I haz the power, 2016-04-01 00:11:39]

Patchset 5 (id:??) landed as
https://crrev.com/66389721bebe73b5de231cea0672b0f436acea8c
Cr-Commit-Position: refs/heads/master@{#384442}