Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2586)

Unified Diff: chrome/browser/media/router/mojo/media_router_mojo_metrics.cc

Issue 1826403002: [Media Router] Moves mojo-specific code into mojo/ folder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert change to media_router.mojom to fix compile Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/mojo/media_router_mojo_metrics.cc
diff --git a/chrome/browser/media/router/media_router_metrics.cc b/chrome/browser/media/router/mojo/media_router_mojo_metrics.cc
similarity index 55%
copy from chrome/browser/media/router/media_router_metrics.cc
copy to chrome/browser/media/router/mojo/media_router_mojo_metrics.cc
index 707a3a1f3d1646f851b14071e489e695fca56b1a..6937f32ad36b9ff8b637e0718bce95347e4a8a7e 100644
--- a/chrome/browser/media/router/media_router_metrics.cc
+++ b/chrome/browser/media/router/mojo/media_router_mojo_metrics.cc
@@ -1,66 +1,19 @@
-// Copyright 2015 The Chromium Authors. All rights reserved.
+// Copyright 2016 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/browser/media/router/media_router_metrics.h"
+#include "chrome/browser/media/router/mojo/media_router_mojo_metrics.h"
#include "base/macros.h"
#include "base/metrics/histogram_macros.h"
-#if !defined(OS_ANDROID)
#include "base/version.h"
#include "components/version_info/version_info.h"
#include "extensions/common/extension.h"
-#endif // !defined(OS_ANDROID)
namespace media_router {
// static
-void MediaRouterMetrics::RecordMediaRouterDialogOrigin(
- MediaRouterDialogOpenOrigin origin) {
- DCHECK_LT(static_cast<int>(origin),
- static_cast<int>(MediaRouterDialogOpenOrigin::TOTAL_COUNT));
- UMA_HISTOGRAM_ENUMERATION(
- "MediaRouter.Icon.Click.Location", static_cast<int>(origin),
- static_cast<int>(MediaRouterDialogOpenOrigin::TOTAL_COUNT));
-}
-
-// static
-void MediaRouterMetrics::RecordMediaRouterDialogPaint(
- const base::TimeDelta delta) {
- UMA_HISTOGRAM_TIMES("MediaRouter.Ui.Dialog.Paint",
- delta);
-}
-
-// static
-void MediaRouterMetrics::RecordMediaRouterDialogLoaded(
- const base::TimeDelta delta) {
- UMA_HISTOGRAM_TIMES("MediaRouter.Ui.Dialog.LoadedWithData",
- delta);
-}
-
-// static
-void MediaRouterMetrics::RecordMediaRouterInitialUserAction(
- MediaRouterUserAction action) {
- DCHECK_LT(static_cast<int>(action),
- static_cast<int>(MediaRouterUserAction::TOTAL_COUNT));
- UMA_HISTOGRAM_ENUMERATION(
- "MediaRouter.Ui.FirstAction", static_cast<int>(action),
- static_cast<int>(MediaRouterUserAction::TOTAL_COUNT));
-}
-
-// static
-void MediaRouterMetrics::RecordRouteCreationOutcome(
- MediaRouterRouteCreationOutcome outcome) {
- DCHECK_LT(static_cast<int>(outcome),
- static_cast<int>(MediaRouterRouteCreationOutcome::TOTAL_COUNT));
- UMA_HISTOGRAM_ENUMERATION(
- "MediaRouter.Route.CreationOutcome", static_cast<int>(outcome),
- static_cast<int>(MediaRouterRouteCreationOutcome::TOTAL_COUNT));
-}
-
-#if !defined(OS_ANDROID)
-// static
-void MediaRouterMetrics::RecordMediaRouteProviderWakeReason(
+void MediaRouterMojoMetrics::RecordMediaRouteProviderWakeReason(
MediaRouteProviderWakeReason reason) {
DCHECK_LT(static_cast<int>(reason),
static_cast<int>(MediaRouteProviderWakeReason::TOTAL_COUNT));
@@ -70,7 +23,7 @@ void MediaRouterMetrics::RecordMediaRouteProviderWakeReason(
}
// static
-void MediaRouterMetrics::RecordMediaRouteProviderVersion(
+void MediaRouterMojoMetrics::RecordMediaRouteProviderVersion(
const extensions::Extension& extension) {
MediaRouteProviderVersion version = MediaRouteProviderVersion::UNKNOWN;
const base::Version* extension_version = extension.version();
@@ -87,7 +40,7 @@ void MediaRouterMetrics::RecordMediaRouteProviderVersion(
}
// static
-void MediaRouterMetrics::RecordMediaRouteProviderWakeup(
+void MediaRouterMojoMetrics::RecordMediaRouteProviderWakeup(
MediaRouteProviderWakeup wakeup) {
DCHECK_LT(static_cast<int>(wakeup),
static_cast<int>(MediaRouteProviderWakeup::TOTAL_COUNT));
@@ -97,7 +50,7 @@ void MediaRouterMetrics::RecordMediaRouteProviderWakeup(
}
// static
-MediaRouteProviderVersion MediaRouterMetrics::GetMediaRouteProviderVersion(
+MediaRouteProviderVersion MediaRouterMojoMetrics::GetMediaRouteProviderVersion(
const base::Version& extension_version,
const base::Version& browser_version) {
if (!extension_version.IsValid() || extension_version.components().empty() ||
@@ -118,6 +71,5 @@ MediaRouteProviderVersion MediaRouterMetrics::GetMediaRouteProviderVersion(
return MediaRouteProviderVersion::MULTIPLE_VERSIONS_BEHIND_CHROME;
}
}
-#endif // !defined(OS_ANDROID)
} // namespace media_router

Powered by Google App Engine
This is Rietveld 408576698