chrome/browser/media/router/BUILD.gn - Issue 1826403002: [Media Router] Moves mojo-specific code into mojo/ folder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/router/BUILD.gn

Issue 1826403002: [Media Router] Moves mojo-specific code into mojo/ folder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert change to media_router.mojom to fix compile Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/chrome_mojo_service_registration.cc ('k') | chrome/browser/media/router/media_route_provider_util_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/router/BUILD.gn

diff --git a/chrome/browser/media/router/BUILD.gn b/chrome/browser/media/router/BUILD.gn

index 0ad5f57bc709f4774a596add2a8d20a26e1ffefd..00ff76d565dac2cdb0fd39e5e5191fba01402c52 100644

--- a/chrome/browser/media/router/BUILD.gn

+++ b/chrome/browser/media/router/BUILD.gn

@@ -45,8 +45,6 @@ mojom("mojo_bindings") {

source_set("test_support") {

testonly = true

deps = [

- # TODO(crbug.com/596999): Move non-Android code to mojo/

- ":mojo_bindings",

":router",

"//chrome/test:test_support",

"//testing/gmock",

@@ -55,7 +53,10 @@ source_set("test_support") {

".",

"//chrome/browser/media/router")

if (!is_android) {

- deps += [ "//extensions/common" ]

+ deps += [

+ ":mojo_bindings",

+ "//extensions/common",

+ ]

sources +=

rebase_path(gypi_values.media_router_non_android_test_support_sources,

".",