Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1052)

Unified Diff: Source/core/html/HTMLMediaElement.h

Issue 182613006: Remove media controls when not in use. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Track visibility in controls. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLMediaElement.h
diff --git a/Source/core/html/HTMLMediaElement.h b/Source/core/html/HTMLMediaElement.h
index c4df625a816d7280341172d594160b7dc9638965..5afd294b6853e4806858a861e142249a05d9a088 100644
--- a/Source/core/html/HTMLMediaElement.h
+++ b/Source/core/html/HTMLMediaElement.h
@@ -166,9 +166,13 @@ public:
void setMediaKeys(MediaKeys*, ExceptionState&);
DEFINE_ATTRIBUTE_EVENT_LISTENER(needkey);
- // controls
+ // This reflects the DOM attribute.
philipj_slow 2014/03/12 16:43:34 If you add [Reflect] to HTMLMediaElement.idl you c
bool controls() const;
void setControls(bool);
+
+ // This version takes scripting and full screen mode into account.
+ bool shouldDisplayControls() const;
philipj_slow 2014/03/12 16:43:34 Bikeshed: shouldShowControls() to go with MediaCon
+
virtual double volume() const OVERRIDE FINAL;
virtual void setVolume(double, ExceptionState&) OVERRIDE FINAL;
virtual bool muted() const OVERRIDE FINAL;
« no previous file with comments | « no previous file | Source/core/html/HTMLMediaElement.cpp » ('j') | Source/core/html/shadow/MediaControlsAndroid.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698