Remove media controls when not in use.

Source/core/html/HTMLMediaElement.h

 /*
  * Copyright (C) 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 148 matching lines @@
     DEFINE_ATTRIBUTE_EVENT_LISTENER(webkitkeyadded);
     DEFINE_ATTRIBUTE_EVENT_LISTENER(webkitkeyerror);
     DEFINE_ATTRIBUTE_EVENT_LISTENER(webkitkeymessage);
     DEFINE_ATTRIBUTE_EVENT_LISTENER(webkitneedkey);
 
     // encrypted media extensions (WD)
     MediaKeys* mediaKeys() const { return m_mediaKeys.get(); }
     void setMediaKeys(MediaKeys*, ExceptionState&);
     DEFINE_ATTRIBUTE_EVENT_LISTENER(needkey);
 
-    // controls
+    // This reflects the DOM attribute.

[philipj_slow, 2014/03/12 16:43:34]

If you add [Reflect] to HTMLMediaElement.idl you can remove both of these
instead, since neither are actually needed internally.

     bool controls() const;
     void setControls(bool);
+
+    // This version takes scripting and full screen mode into account.
+    bool shouldDisplayControls() const;

[philipj_slow, 2014/03/12 16:43:34]

Bikeshed: shouldShowControls() to go with MediaControls::show() and
HTMLMediaElement::showingTrackWithSameKind()?

+
     virtual double volume() const OVERRIDE FINAL;
     virtual void setVolume(double, ExceptionState&) OVERRIDE FINAL;
     virtual bool muted() const OVERRIDE FINAL;
     virtual void setMuted(bool) OVERRIDE FINAL;
 
     virtual void beginScrubbing() OVERRIDE FINAL;
     virtual void endScrubbing() OVERRIDE FINAL;
 
     virtual bool canPlay() const OVERRIDE FINAL;
 
@@ skipping 395 matching lines @@
 inline bool isHTMLMediaElement(const Node& node)
 {
     return node.isElementNode() && toElement(node).isMediaElement();
 }
 
 DEFINE_NODE_TYPE_CASTS_WITH_FUNCTION(HTMLMediaElement);
 
 } //namespace
 
 #endif