Remove media controls when not in use.

Source/core/html/shadow/MediaControlsAndroid.cpp

Index: Source/core/html/shadow/MediaControlsAndroid.cpp
diff --git a/Source/core/html/shadow/MediaControlsAndroid.cpp b/Source/core/html/shadow/MediaControlsAndroid.cpp
index 6943ae5f847da28221246aa63c2cba8c0265d5c2..9eedb8a12f76c5bfa8e93b832defb9e3837d9d90 100644
--- a/Source/core/html/shadow/MediaControlsAndroid.cpp
+++ b/Source/core/html/shadow/MediaControlsAndroid.cpp
@@ -66,6 +66,20 @@ void MediaControlsAndroid::setMediaController(MediaControllerInterface* controll
     MediaControls::setMediaController(controller);
 }
 
+void MediaControlsAndroid::show()
+{
+    m_overlayPlayButton->setVisible(true);
+    m_overlayPlayButton->updateDisplayType();
+    MediaControls::show();
+}
+
+void MediaControlsAndroid::hide()
+{
+    m_overlayPlayButton->setVisible(false);
+    m_overlayPlayButton->updateDisplayType();

[acolwell GONE FROM CHROMIUM, 2014/03/06 19:21:54]

nit: It seems like you could unconditionally hide here instead.

[philipj_slow, 2014/03/18 04:14:13]

Yes, when moving this into MediaControls.cpp try just if (m_overlayEnclosure)
m_overlayEnclosure->hide().

+    MediaControls::hide();
+}
+
 void MediaControlsAndroid::playbackStarted()
 {
     m_overlayPlayButton->updateDisplayType();

[acolwell GONE FROM CHROMIUM, 2014/03/06 19:21:54]

It seems like you could make this call and the one below conditionally based on
whether m_panel->m_isDisplayed is true. This could be hidden behind a
MediaControls::isDisplayed() helper.

Doing this avoids the extra bool and allows updates only when the controls as a
whole are supposed to be displayed.

[Fredrik Öhrn, 2014/03/07 09:45:45]

Problem is that MediaControlOverlayPlayButtonElement::defaultEventHandler() can
also call updateDisplayType() on itself, there MediaControls::isDisplayed() is
not available since the buttons don't have a pointer back it.