Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 18261015: Rename ScriptElement to ScriptLoader (Closed)

Created:
7 years, 5 months ago by Hajime Morrita
Modified:
7 years, 5 months ago
CC:
blink-reviews, eae+blinkwatch, dglazkov+blink, f(malita), adamk+blink_chromium.org, pdr, Stephen Chennney
Visibility:
Public.

Description

Rename ScriptElement to ScriptLoader This change renames ScriptElement to ScriptLoader. This also does related renames: - ScriptElementClient -> ScriptLoaderClient - HTMLScriptElement::m_scriptElement -> HTMLScriptElement::m_loader - Ditto for SVGScriptElement As a bonus, ScriptLoaderClient got its own header file which hides ScriptLoader from majority of core files. BUG=240592 TEST=none R=hayato@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153755

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -739 lines) Patch
M Source/core/core.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
D Source/core/dom/ScriptElement.h View 1 chunk +0 lines, -131 lines 0 comments Download
D Source/core/dom/ScriptElement.cpp View 1 chunk +0 lines, -432 lines 0 comments Download
A + Source/core/dom/ScriptLoader.h View 4 chunks +13 lines, -29 lines 0 comments Download
A + Source/core/dom/ScriptLoader.cpp View 14 chunks +54 lines, -51 lines 0 comments Download
A + Source/core/dom/ScriptLoaderClient.h View 2 chunks +21 lines, -22 lines 0 comments Download
M Source/core/dom/ScriptRunner.h View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/ScriptRunner.cpp View 5 chunks +9 lines, -9 lines 0 comments Download
M Source/core/html/HTMLOptionElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLScriptElement.h View 3 chunks +6 lines, -4 lines 0 comments Download
M Source/core/html/HTMLScriptElement.cpp View 6 chunks +9 lines, -8 lines 0 comments Download
M Source/core/html/parser/HTMLConstructionSite.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M Source/core/html/parser/HTMLScriptRunner.cpp View 5 chunks +15 lines, -14 lines 0 comments Download
M Source/core/svg/SVGScriptElement.h View 3 chunks +6 lines, -4 lines 0 comments Download
M Source/core/svg/SVGScriptElement.cpp View 6 chunks +9 lines, -8 lines 0 comments Download
M Source/core/xml/parser/XMLDocumentParser.cpp View 6 chunks +18 lines, -17 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Hajime Morrita
Could you rubberstamp? This is a sheer rename which follows https://src.chromium.org/viewvc/blink?view=revision&revision=153748
7 years, 5 months ago (2013-07-09 06:43:25 UTC) #1
hayato
LGTM
7 years, 5 months ago (2013-07-09 06:48:45 UTC) #2
Hajime Morrita
Committed patchset #1 manually as r153755 (presubmit successful).
7 years, 5 months ago (2013-07-09 07:10:19 UTC) #3
abarth-chromium
7 years, 5 months ago (2013-07-09 17:58:44 UTC) #4
Message was sent while issue was closed.
Thanks!!

Powered by Google App Engine
This is Rietveld 408576698