Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Unified Diff: Source/core/html/parser/HTMLScriptRunner.cpp

Issue 18261015: Rename ScriptElement to ScriptLoader (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/parser/HTMLConstructionSite.cpp ('k') | Source/core/svg/SVGScriptElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/parser/HTMLScriptRunner.cpp
diff --git a/Source/core/html/parser/HTMLScriptRunner.cpp b/Source/core/html/parser/HTMLScriptRunner.cpp
index 0429e96c6c5828782c84fe4cb622a17dd839ec25..3b8462d877e5715ececfb929c6a242fe99367919 100644
--- a/Source/core/html/parser/HTMLScriptRunner.cpp
+++ b/Source/core/html/parser/HTMLScriptRunner.cpp
@@ -31,7 +31,7 @@
#include "core/dom/Event.h"
#include "core/dom/IgnoreDestructiveWriteCountIncrementer.h"
#include "core/dom/Microtask.h"
-#include "core/dom/ScriptElement.h"
+#include "core/dom/ScriptLoader.h"
#include "core/html/parser/HTMLInputStream.h"
#include "core/html/parser/HTMLScriptRunnerHost.h"
#include "core/html/parser/NestingLevelIncrementer.h"
@@ -130,14 +130,14 @@ void HTMLScriptRunner::executePendingScriptAndDispatchEvent(PendingScript& pendi
// Clear the pending script before possible rentrancy from executeScript()
RefPtr<Element> element = pendingScript.releaseElementAndClear();
- if (ScriptElement* scriptElement = toScriptElementIfPossible(element.get())) {
+ if (ScriptLoader* scriptLoader = toScriptLoaderIfPossible(element.get())) {
NestingLevelIncrementer nestingLevelIncrementer(m_scriptNestingLevel);
IgnoreDestructiveWriteCountIncrementer ignoreDestructiveWriteCountIncrementer(m_document);
if (errorOccurred)
- scriptElement->dispatchErrorEvent();
+ scriptLoader->dispatchErrorEvent();
else {
ASSERT(isExecutingScript());
- scriptElement->executeScript(sourceCode);
+ scriptLoader->executeScript(sourceCode);
element->dispatchEvent(createScriptLoadEvent());
}
}
@@ -259,7 +259,7 @@ bool HTMLScriptRunner::requestPendingScript(PendingScript& pendingScript, Elemen
ASSERT(!pendingScript.element());
pendingScript.setElement(script);
// This should correctly return 0 for empty or invalid srcValues.
- CachedScript* cachedScript = toScriptElementIfPossible(script)->cachedScript().get();
+ CachedScript* cachedScript = toScriptLoaderIfPossible(script)->cachedScript().get();
if (!cachedScript) {
notImplemented(); // Dispatch error event.
return false;
@@ -275,14 +275,14 @@ void HTMLScriptRunner::runScript(Element* script, const TextPosition& scriptStar
ASSERT(m_document);
ASSERT(!hasParserBlockingScript());
{
- ScriptElement* scriptElement = toScriptElementIfPossible(script);
+ ScriptLoader* scriptLoader = toScriptLoaderIfPossible(script);
// This contains both and ASSERTION and a null check since we should not
// be getting into the case of a null script element, but seem to be from
// time to time. The assertion is left in to help find those cases and
// is being tracked by <https://bugs.webkit.org/show_bug.cgi?id=60559>.
- ASSERT(scriptElement);
- if (!scriptElement)
+ ASSERT(scriptLoader);
+ if (!scriptLoader)
return;
// FIXME: This may be too agressive as we always deliver mutations at
@@ -295,23 +295,24 @@ void HTMLScriptRunner::runScript(Element* script, const TextPosition& scriptStar
InsertionPointRecord insertionPointRecord(m_host->inputStream());
NestingLevelIncrementer nestingLevelIncrementer(m_scriptNestingLevel);
- scriptElement->prepareScript(scriptStartPosition);
+ scriptLoader->prepareScript(scriptStartPosition);
- if (!scriptElement->willBeParserExecuted())
+ if (!scriptLoader->willBeParserExecuted())
return;
- if (scriptElement->willExecuteWhenDocumentFinishedParsing())
+ if (scriptLoader->willExecuteWhenDocumentFinishedParsing()) {
requestDeferredScript(script);
- else if (scriptElement->readyToBeParserExecuted()) {
+ } else if (scriptLoader->readyToBeParserExecuted()) {
if (m_scriptNestingLevel == 1) {
m_parserBlockingScript.setElement(script);
m_parserBlockingScript.setStartingPosition(scriptStartPosition);
} else {
ScriptSourceCode sourceCode(script->textContent(), documentURLForScriptExecution(m_document), scriptStartPosition);
- scriptElement->executeScript(sourceCode);
+ scriptLoader->executeScript(sourceCode);
}
- } else
+ } else {
requestParsingBlockingScript(script);
+ }
}
}
« no previous file with comments | « Source/core/html/parser/HTMLConstructionSite.cpp ('k') | Source/core/svg/SVGScriptElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698