Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1825663002: Sk4x4f (Closed)

Created:
4 years, 9 months ago by mtklein_C
Modified:
4 years, 9 months ago
Reviewers:
herb_g, f(malita), mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Sk4x4f An API for loading and storing 4 Sk4f with transpose. This has SSSE3+ and portable versions. SSE2 and NEON versions to follow. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1825663002 Committed: https://skia.googlesource.com/skia/+/0e05f38502d4e499aabb0b8d07bfa0c531bc49c3

Patch Set 1 #

Patch Set 2 : cast #

Patch Set 3 : port srcover_n_srgb_bw #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -53 lines) Patch
A src/core/Sk4x4f.h View 1 1 chunk +137 lines, -0 lines 0 comments Download
M src/core/SkXfermode4f.cpp View 1 2 2 chunks +23 lines, -53 lines 0 comments Download
A tests/Sk4x4fTest.cpp View 1 chunk +54 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
mtklein_C
See if any of this looks evocative?
4 years, 9 months ago (2016-03-22 21:52:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1825663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1825663002/1
4 years, 9 months ago (2016-03-22 21:52:50 UTC) #6
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 9 months ago (2016-03-22 21:52:51 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/7310) Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, ...
4 years, 9 months ago (2016-03-22 21:57:40 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1825663002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1825663002/20001
4 years, 9 months ago (2016-03-22 22:00:39 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-22 22:12:20 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1825663002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1825663002/40001
4 years, 9 months ago (2016-03-22 23:40:13 UTC) #15
f(malita)
pretty, lgtm!
4 years, 9 months ago (2016-03-22 23:46:51 UTC) #16
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-22 23:52:01 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1825663002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1825663002/40001
4 years, 9 months ago (2016-03-23 00:16:29 UTC) #20
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 00:17:53 UTC) #22
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/0e05f38502d4e499aabb0b8d07bfa0c531bc49c3

Powered by Google App Engine
This is Rietveld 408576698