Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(996)

Unified Diff: third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.h

Issue 1825613005: More explicit SVGTextMetrics construction (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@svg-metrics-cleanup-2
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.h
diff --git a/third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.h b/third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.h
index a63d8a914bfd9fede5ee808df3adcd49f57e0b42..d7c07a512858e5b8d101c6a1255c3e6ec9dfc0d3 100644
--- a/third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.h
+++ b/third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.h
@@ -25,7 +25,6 @@
namespace blink {
enum class FontOrientation;
-class LineLayoutSVGInlineText;
class SVGTextMetrics {
DISALLOW_NEW_EXCEPT_PLACEMENT_NEW();
@@ -36,13 +35,11 @@ public:
SVGTextMetrics();
SVGTextMetrics(MetricsType);
- SVGTextMetrics(LineLayoutSVGInlineText, unsigned length, float width);
+ SVGTextMetrics(unsigned length, float width, float height);
bool isEmpty() const { return !m_width && !m_height && m_length <= 1; }
float width() const { return m_width; }
- void setWidth(float width) { m_width = width; }
-
float height() const { return m_height; }
// TODO(kojii): We should store logical width (advance) and height instead
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698