[Extensions] Convert APIs to use movable types [1]

[Extensions] Convert APIs to use movable types [1]

Generated extensions code used to rely on linked_ptrs for non-copyable types in
containers. Now, we can make these types movable. Update the following APIs
to use movable types in this CL:
- accessibility_features.json
- activity_log_private.json
- appview_tag.idl
- audio_modem.idl
- autofill_private.idl
- automation.idl
- automation_internal.idl
- autotest_private.idl
- bluetooth_low_energy.idl

BUG=595949
Committed: https://crrev.com/22abe73df650a8adaf0b78e02ebbbb4e670f3470
Cr-Commit-Position: refs/heads/master@{#384120}

[Devlin, 2016-03-22 22:37:04]

Description was changed from

==========
[Extensions] Convert APIs to use movable types

Generated extensions code used to rely on linked_ptrs for non-copyable types in
containers. Nowe, we can make these types movable. Update the following APIs
to use movable types in this CL:
- accessibility_features.json
- activity_log_private.json
- appview_tag.idl
- audio_modem.idl
- autofill_private.idl
- automation.idl
- automation_internal.idl
- autotest_private.idl
- bluetooth_low_energy.idl
- bookmark_manager_private.json

BUG=595949
==========

to

==========
[Extensions] Convert APIs to use movable types [1]

Generated extensions code used to rely on linked_ptrs for non-copyable types in
containers. Nowe, we can make these types movable. Update the following APIs
to use movable types in this CL:
- accessibility_features.json
- activity_log_private.json
- appview_tag.idl
- audio_modem.idl
- autofill_private.idl
- automation.idl
- automation_internal.idl
- autotest_private.idl
- bluetooth_low_energy.idl
- bookmark_manager_private.json

BUG=595949
==========

[Devlin, 2016-03-22 22:43:07]

Description was changed from

==========
[Extensions] Convert APIs to use movable types [1]

Generated extensions code used to rely on linked_ptrs for non-copyable types in
containers. Nowe, we can make these types movable. Update the following APIs
to use movable types in this CL:
- accessibility_features.json
- activity_log_private.json
- appview_tag.idl
- audio_modem.idl
- autofill_private.idl
- automation.idl
- automation_internal.idl
- autotest_private.idl
- bluetooth_low_energy.idl
- bookmark_manager_private.json

BUG=595949
==========

to

==========
[Extensions] Convert APIs to use movable types [1]

Generated extensions code used to rely on linked_ptrs for non-copyable types in
containers. Nowe, we can make these types movable. Update the following APIs
to use movable types in this CL:
- accessibility_features.json
- activity_log_private.json
- appview_tag.idl
- audio_modem.idl
- autofill_private.idl
- automation.idl
- automation_internal.idl
- autotest_private.idl
- bluetooth_low_energy.idl

BUG=595949
==========

[Devlin, 2016-03-23 14:15:57]

Patchset #1 (id:1) has been deleted

[Devlin, 2016-03-23 14:16:53]

Patchset #1 (id:20001) has been deleted

[Devlin, 2016-03-23 14:17:01]

Patchset #2 (id:60001) has been deleted

[Devlin, 2016-03-23 14:17:21]

Description was changed from

==========
[Extensions] Convert APIs to use movable types [1]

Generated extensions code used to rely on linked_ptrs for non-copyable types in
containers. Nowe, we can make these types movable. Update the following APIs
to use movable types in this CL:
- accessibility_features.json
- activity_log_private.json
- appview_tag.idl
- audio_modem.idl
- autofill_private.idl
- automation.idl
- automation_internal.idl
- autotest_private.idl
- bluetooth_low_energy.idl

BUG=595949
==========

to

==========
[Extensions] Convert APIs to use movable types [1]

Generated extensions code used to rely on linked_ptrs for non-copyable types in
containers. Now, we can make these types movable. Update the following APIs
to use movable types in this CL:
- accessibility_features.json
- activity_log_private.json
- appview_tag.idl
- audio_modem.idl
- autofill_private.idl
- automation.idl
- automation_internal.idl
- autotest_private.idl
- bluetooth_low_energy.idl

BUG=595949
==========

[Devlin, 2016-03-23 14:39:12]

Patchset #1 (id:40001) has been deleted

[Devlin, 2016-03-23 14:40:05]

rdevlin.cronin@chromium.org changed reviewers:
+ asargent@chromium.org

[Devlin, 2016-03-23 14:40:05]

Antony, mind taking a look?  (I'll be splitting these reviews between you and
Istiaque.)

[Devlin, 2016-03-29 21:23:01]

On 2016/03/23 14:40:05, Devlin wrote:
> Antony, mind taking a look?  (I'll be splitting these reviews between you and
> Istiaque.)

Friendly ping - I think this one slipped through the cracks. :)

[asargent_no_longer_on_chrome, 2016-03-30 19:26:40]

On 2016/03/29 21:23:01, Devlin wrote:
> On 2016/03/23 14:40:05, Devlin wrote:
> > Antony, mind taking a look?  (I'll be splitting these reviews between you
and
> > Istiaque.)
> 
> Friendly ping - I think this one slipped through the cracks. :)

Oops, sorry, yes it did. Looking now...

[asargent_no_longer_on_chrome, 2016-03-30 19:39:25]

lgtm

https://codereview.chromium.org/1825263002/diff/80001/chrome/browser/extensio...
File chrome/browser/extensions/api/audio_modem/audio_modem_api.cc (right):

https://codereview.chromium.org/1825263002/diff/80001/chrome/browser/extensio...
chrome/browser/extensions/api/audio_modem/audio_modem_api.cc:253: //
std::vector<ReceivedToken> since the same token can go to multiple
Something in this comment isn't quite right, or at least I'm confused about what
you're trying to say here. The thing I can't quite wrap my head around is "the
generated version takes std::vector<ReceivedToken>..." but you then say "we use
"std::vector<ReceivedToken>..." which is the same type. Can you fix or clarify?

Also, the code in this method is kind of confusing because |tokens| inside this
for loop shadows the function argument named |tokens|. Mind fixing that while
you're in here?

https://codereview.chromium.org/1825263002/diff/80001/chrome/common/extension...
File chrome/common/extensions/api/automation_internal.idl (right):

https://codereview.chromium.org/1825263002/diff/80001/chrome/common/extension...
chrome/common/extensions/api/automation_internal.idl:8:
[use_movable_types=true]namespace automationInternal {
nit: please add a space between closing ']' and 'namespace'

https://codereview.chromium.org/1825263002/diff/80001/chrome/common/extension...
File chrome/common/extensions/api/autotest_private.idl (right):

https://codereview.chromium.org/1825263002/diff/80001/chrome/common/extension...
chrome/common/extensions/api/autotest_private.idl:7:
[use_movable_types]namespace autotestPrivate {
same nit

https://codereview.chromium.org/1825263002/diff/80001/chrome/common/extension...
File chrome/common/extensions/api/bluetooth_low_energy.idl (right):

https://codereview.chromium.org/1825263002/diff/80001/chrome/common/extension...
chrome/common/extensions/api/bluetooth_low_energy.idl:9:
[use_movable_types=true]namespace bluetoothLowEnergy {
same nit

[Devlin, 2016-03-30 22:23:43]

https://codereview.chromium.org/1825263002/diff/80001/chrome/browser/extensio...
File chrome/browser/extensions/api/audio_modem/audio_modem_api.cc (right):

https://codereview.chromium.org/1825263002/diff/80001/chrome/browser/extensio...
chrome/browser/extensions/api/audio_modem/audio_modem_api.cc:253: //
std::vector<ReceivedToken> since the same token can go to multiple
On 2016/03/30 19:39:24, Antony Sargent wrote:
> Something in this comment isn't quite right, or at least I'm confused about
what
> you're trying to say here. The thing I can't quite wrap my head around is "the
> generated version takes std::vector<ReceivedToken>..." but you then say "we
use
> "std::vector<ReceivedToken>..." which is the same type. Can you fix or
clarify?
> 
> Also, the code in this method is kind of confusing because |tokens| inside
this
> for loop shadows the function argument named |tokens|. Mind fixing that while
> you're in here?

Heh whoops.  One of those was supposed to be a std::vector<ReceivedToken*>. I've
rephrased the comment to (hopefully) make it less confusing.

Also renamed tokens to app_tokens.

https://codereview.chromium.org/1825263002/diff/80001/chrome/common/extension...
File chrome/common/extensions/api/automation_internal.idl (right):

https://codereview.chromium.org/1825263002/diff/80001/chrome/common/extension...
chrome/common/extensions/api/automation_internal.idl:8:
[use_movable_types=true]namespace automationInternal {
On 2016/03/30 19:39:24, Antony Sargent wrote:
> nit: please add a space between closing ']' and 'namespace'

Done.

https://codereview.chromium.org/1825263002/diff/80001/chrome/common/extension...
File chrome/common/extensions/api/autotest_private.idl (right):

https://codereview.chromium.org/1825263002/diff/80001/chrome/common/extension...
chrome/common/extensions/api/autotest_private.idl:7:
[use_movable_types]namespace autotestPrivate {
On 2016/03/30 19:39:25, Antony Sargent wrote:
> same nit

Done.

https://codereview.chromium.org/1825263002/diff/80001/chrome/common/extension...
File chrome/common/extensions/api/bluetooth_low_energy.idl (right):

https://codereview.chromium.org/1825263002/diff/80001/chrome/common/extension...
chrome/common/extensions/api/bluetooth_low_energy.idl:9:
[use_movable_types=true]namespace bluetoothLowEnergy {
On 2016/03/30 19:39:25, Antony Sargent wrote:
> same nit

Done.

[Devlin, 2016-03-30 22:23:48]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2016-03-30 22:23:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
asargent@chromium.org
Link to the patchset: https://codereview.chromium.org/1825263002/#ps100001
(title: "Antony's")

[commit-bot: I haz the power, 2016-03-30 22:24:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1825263002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1825263002/100001

[commit-bot: I haz the power, 2016-03-30 22:36:19]

Description was changed from

==========
[Extensions] Convert APIs to use movable types [1]

Generated extensions code used to rely on linked_ptrs for non-copyable types in
containers. Now, we can make these types movable. Update the following APIs
to use movable types in this CL:
- accessibility_features.json
- activity_log_private.json
- appview_tag.idl
- audio_modem.idl
- autofill_private.idl
- automation.idl
- automation_internal.idl
- autotest_private.idl
- bluetooth_low_energy.idl

BUG=595949
==========

to

==========
[Extensions] Convert APIs to use movable types [1]

Generated extensions code used to rely on linked_ptrs for non-copyable types in
containers. Now, we can make these types movable. Update the following APIs
to use movable types in this CL:
- accessibility_features.json
- activity_log_private.json
- appview_tag.idl
- audio_modem.idl
- autofill_private.idl
- automation.idl
- automation_internal.idl
- autotest_private.idl
- bluetooth_low_energy.idl

BUG=595949
==========

[commit-bot: I haz the power, 2016-03-30 22:36:20]

Committed patchset #2 (id:100001)

[commit-bot: I haz the power, 2016-03-30 22:38:02]

Description was changed from

==========
[Extensions] Convert APIs to use movable types [1]

Generated extensions code used to rely on linked_ptrs for non-copyable types in
containers. Now, we can make these types movable. Update the following APIs
to use movable types in this CL:
- accessibility_features.json
- activity_log_private.json
- appview_tag.idl
- audio_modem.idl
- autofill_private.idl
- automation.idl
- automation_internal.idl
- autotest_private.idl
- bluetooth_low_energy.idl

BUG=595949
==========

to

==========
[Extensions] Convert APIs to use movable types [1]

Generated extensions code used to rely on linked_ptrs for non-copyable types in
containers. Now, we can make these types movable. Update the following APIs
to use movable types in this CL:
- accessibility_features.json
- activity_log_private.json
- appview_tag.idl
- audio_modem.idl
- autofill_private.idl
- automation.idl
- automation_internal.idl
- autotest_private.idl
- bluetooth_low_energy.idl

BUG=595949

Committed: https://crrev.com/22abe73df650a8adaf0b78e02ebbbb4e670f3470
Cr-Commit-Position: refs/heads/master@{#384120}
==========

[commit-bot: I haz the power, 2016-03-30 22:38:03]

Patchset 2 (id:??) landed as
https://crrev.com/22abe73df650a8adaf0b78e02ebbbb4e670f3470
Cr-Commit-Position: refs/heads/master@{#384120}