chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.h - Issue 1825263002: [Extensions] Convert APIs to use movable types [1]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.h

Issue 1825263002: [Extensions] Convert APIs to use movable types [1] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Antony's Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc ('k') | chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.h

diff --git a/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.h b/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.h

index 5658362f60182161c4b06d04dc01aa0ebadb7718..2498ad85f9f67051536f77e7e4649b21dd04e5a4 100644

--- a/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.h

+++ b/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.h

@@ -14,7 +14,6 @@

#include "base/callback.h"

#include "base/macros.h"

-#include "base/memory/linked_ptr.h"

#include "base/memory/weak_ptr.h"

#include "chrome/common/extensions/api/bluetooth_low_energy.h"

#include "content/public/browser/notification_observer.h"

@@ -128,8 +127,7 @@ class BluetoothLowEnergyEventRouter

// is found but it has no GATT services, then returns true and leaves

// |out_services| empty. Returns true, on success. |out_services| must not

// be NULL. If it is non-empty, then its contents will be cleared.

- typedef std::vector<linked_ptr<api::bluetooth_low_energy::Service>>

- ServiceList;

+ typedef std::vector<api::bluetooth_low_energy::Service> ServiceList;

bool GetServices(const std::string& device_address,

ServiceList* out_services) const;

@@ -154,7 +152,7 @@ class BluetoothLowEnergyEventRouter

// |out_characteristics| must not be NULL and if it is non-empty,

// then its contents will be cleared. |extension| is the extension that made

// the call.

- typedef std::vector<linked_ptr<api::bluetooth_low_energy::Characteristic>>

+ typedef std::vector<api::bluetooth_low_energy::Characteristic>

CharacteristicList;

Status GetCharacteristics(const Extension* extension,

const std::string& instance_id,

@@ -175,8 +173,7 @@ class BluetoothLowEnergyEventRouter

// |out_descriptors| must not be NULL and if it is non-empty,

// then its contents will be cleared. |extension| is the extension that made

// the call.

- typedef std::vector<linked_ptr<api::bluetooth_low_energy::Descriptor>>

- DescriptorList;

+ typedef std::vector<api::bluetooth_low_energy::Descriptor> DescriptorList;

Status GetDescriptors(const Extension* extension,

const std::string& instance_id,

DescriptorList* out_descriptors) const;