Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5150)

Unified Diff: chrome/browser/extensions/api/autofill_private/autofill_private_event_router.cc

Issue 1825263002: [Extensions] Convert APIs to use movable types [1] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Antony's Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/autofill_private/autofill_private_event_router.cc
diff --git a/chrome/browser/extensions/api/autofill_private/autofill_private_event_router.cc b/chrome/browser/extensions/api/autofill_private/autofill_private_event_router.cc
index e92504c9db5e95c8b28b5d4f6e68a269d34b27fb..17d0d6a27c31e6dcac5577dec3fde56b0ad783a4 100644
--- a/chrome/browser/extensions/api/autofill_private/autofill_private_event_router.cc
+++ b/chrome/browser/extensions/api/autofill_private/autofill_private_event_router.cc
@@ -19,11 +19,6 @@
#include "components/autofill/core/browser/personal_data_manager.h"
#include "content/public/browser/browser_context.h"
-using AddressEntryList = std::vector<linked_ptr<
- extensions::api::autofill_private::AddressEntry> >;
-using CreditCardEntryList = std::vector<linked_ptr<
- extensions::api::autofill_private::CreditCardEntry> >;
-
namespace extensions {
AutofillPrivateEventRouter::AutofillPrivateEventRouter(
@@ -79,22 +74,22 @@ void AutofillPrivateEventRouter::OnListenerRemoved(
void AutofillPrivateEventRouter::OnPersonalDataChanged() {
DCHECK(personal_data_ && personal_data_->IsDataLoaded());
- scoped_ptr<AddressEntryList> addressList =
+ autofill_util::AddressEntryList addressList =
extensions::autofill_util::GenerateAddressList(*personal_data_);
scoped_ptr<base::ListValue> args(
- api::autofill_private::OnAddressListChanged::Create(*addressList)
- .release());
+ api::autofill_private::OnAddressListChanged::Create(addressList)
+ .release());
scoped_ptr<Event> extension_event(
new Event(events::AUTOFILL_PRIVATE_ON_ADDRESS_LIST_CHANGED,
api::autofill_private::OnAddressListChanged::kEventName,
std::move(args)));
event_router_->BroadcastEvent(std::move(extension_event));
- scoped_ptr<CreditCardEntryList> creditCardList =
+ autofill_util::CreditCardEntryList creditCardList =
extensions::autofill_util::GenerateCreditCardList(*personal_data_);
args.reset(
- api::autofill_private::OnCreditCardListChanged::Create(*creditCardList)
- .release());
+ api::autofill_private::OnCreditCardListChanged::Create(creditCardList)
+ .release());
extension_event.reset(
new Event(events::AUTOFILL_PRIVATE_ON_CREDIT_CARD_LIST_CHANGED,
api::autofill_private::OnCreditCardListChanged::kEventName,

Powered by Google App Engine
This is Rietveld 408576698