Separate gfx_ipc into skia-dependent and non-skia-dependent parts

Separate gfx_ipc into skia-dependent and non-skia-dependent parts. This will simplify dependencies in gpu/ipc/common, as a part of the content/common/gpu --> gpu refactor.

BUG=596242
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69
Cr-Commit-Position: refs/heads/master@{#384351}

[Mark Dittmer, 2016-03-24 16:10:29]

Fix gn/gyp header deps for ui/gfx/ipc

[Mark Dittmer, 2016-03-24 17:51:30]

Fix up deps for iOS and Android builds

[Mark Dittmer, 2016-03-24 18:17:26]

Fix gn iOS dep; was in wrong branch of if/else

[Mark Dittmer, 2016-03-25 20:00:47]

Add and remove some deps to make bots happy

[Mark Dittmer, 2016-03-25 20:17:00]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-25 20:17:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1824993004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1824993004/80001

[commit-bot: I haz the power, 2016-03-25 20:47:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-25 20:47:23]

Dry run: Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mark Dittmer, 2016-03-26 01:38:03]

Add gfx ipc skia deps to cc

[Mark Dittmer, 2016-03-26 01:38:03]

Description was changed from

==========
Separate gfx_ipc into skia-dependent and non-skia-dependent parts

BUG=596242
==========

to

==========
Separate gfx_ipc into skia-dependent and non-skia-dependent parts

BUG=596242
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[Mark Dittmer, 2016-03-26 01:38:39]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-26 01:38:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1824993004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1824993004/100001

[commit-bot: I haz the power, 2016-03-26 02:02:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-26 02:02:21]

Dry run: Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mark Dittmer, 2016-03-26 23:42:14]

Add more deps to make bots happy; remove duplicate decl of SkBitmap ParamTraits

[Mark Dittmer, 2016-03-26 23:42:26]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-26 23:42:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1824993004/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1824993004/120001

[commit-bot: I haz the power, 2016-03-26 23:52:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-26 23:52:31]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mark Dittmer, 2016-03-27 00:42:17]

Add missing deps for extensions/utility/unpacker

[Mark Dittmer, 2016-03-27 00:42:48]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-27 00:43:00]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1824993004/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1824993004/140001

[commit-bot: I haz the power, 2016-03-27 00:49:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-27 00:49:46]

Dry run: Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/8...)
  linux_blink_oilpan_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_blink_oil...)

[Mark Dittmer, 2016-03-28 14:11:33]

Attempt to simplify deps by replacing (almost all) old deps with equivalent skia
version of new dep

[Mark Dittmer, 2016-03-28 14:11:42]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-28 14:11:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1824993004/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1824993004/160001

[commit-bot: I haz the power, 2016-03-28 14:13:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-28 14:14:00]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Mark Dittmer, 2016-03-28 14:40:15]

rebase

[Mark Dittmer, 2016-03-28 14:50:05]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-28 14:50:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1824993004/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1824993004/180001

[commit-bot: I haz the power, 2016-03-28 14:53:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-28 14:53:52]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)

[Mark Dittmer, 2016-03-28 15:10:59]

Switch skia deps to non-skia+skia

[Mark Dittmer, 2016-03-28 15:11:08]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-28 15:11:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1824993004/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1824993004/200001

[commit-bot: I haz the power, 2016-03-28 15:19:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-28 15:19:56]

Dry run: Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/8...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Mark Dittmer, 2016-03-28 16:04:34]

Add includes associated with new skia-only ui/gfx/ipc target

[Mark Dittmer, 2016-03-28 16:04:37]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-28 16:04:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1824993004/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1824993004/220001

[commit-bot: I haz the power, 2016-03-28 17:08:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-28 17:08:58]

Dry run: This issue passed the CQ dry run.

[Mark Dittmer, 2016-03-28 19:18:11]

Description was changed from

==========
Separate gfx_ipc into skia-dependent and non-skia-dependent parts

BUG=596242
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Separate gfx_ipc into skia-dependent and non-skia-dependent parts. This will
simplify dependencies in gpu/ipc/common, as a part of the content/common/gpu -->
gpu refactor.

BUG=596242
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[Mark Dittmer, 2016-03-28 19:55:20]

markdittmer@chromium.org changed reviewers:
+ kenrb@chromium.org, piman@chromium.org

[Mark Dittmer, 2016-03-28 19:55:50]

+piman@ +kenrb@ for OWNERS and security review.

[Mark Dittmer, 2016-03-28 19:58:01]

markdittmer@chromium.org changed reviewers:
+ dcheng@chromium.org
- kenrb@chromium.org

[Mark Dittmer, 2016-03-28 19:58:31]

Swap: -kenrb@, +dcheng@ (Ken's off for Easter Monday).

[piman, 2016-03-28 20:20:50]

LGTM, but you should get a ui/gfx owner to review.

[Mark Dittmer, 2016-03-28 20:28:19]

markdittmer@chromium.org changed reviewers:
+ danakj@chromium.org

[Mark Dittmer, 2016-03-28 20:28:40]

On 2016/03/28 20:20:50, piman wrote:
> LGTM, but you should get a ui/gfx owner to review.

+danakj@ for ui/gfx review.

[danakj, 2016-03-28 20:33:17]

https://codereview.chromium.org/1824993004/diff/220001/ui/gfx/ipc/gfx_skia_ip...
File ui/gfx/ipc/gfx_skia_ipc_export.h (right):

https://codereview.chromium.org/1824993004/diff/220001/ui/gfx/ipc/gfx_skia_ip...
ui/gfx/ipc/gfx_skia_ipc_export.h:1: // Copyright 2014 The Chromium Authors. All
rights reserved.
2016

https://codereview.chromium.org/1824993004/diff/220001/ui/gfx/ipc/gfx_skia_ip...
ui/gfx/ipc/gfx_skia_ipc_export.h:11: #if defined(GFX_SKIA_IPC_IMPLEMENTATION)
It's unusual to have 2 components in the same directory. ipc/skia/ ?

[Mark Dittmer, 2016-03-28 20:33:38]

markdittmer@chromium.org changed reviewers:
+ rjkroege@chromium.org

[Mark Dittmer, 2016-03-28 20:33:55]

+rjkroege@ for ui/ozone review

[Mark Dittmer, 2016-03-28 20:35:02]

markdittmer@chromium.org changed reviewers:
+ rdcronin@google.com

[Mark Dittmer, 2016-03-28 20:35:28]

+rdcronin@ for extensions review

[dcheng, 2016-03-28 20:37:55]

dcheng@chromium.org changed reviewers:
- rdcronin@google.com, rjkroege@chromium.org

[dcheng, 2016-03-28 20:37:57]

ipc bits look reasonable, with a few small nits (I know this is just moving
code, but may as well)

https://codereview.chromium.org/1824993004/diff/220001/ui/gfx/ipc/gfx_skia_pa...
File ui/gfx/ipc/gfx_skia_param_traits.cc (right):

https://codereview.chromium.org/1824993004/diff/220001/ui/gfx/ipc/gfx_skia_pa...
ui/gfx/ipc/gfx_skia_param_traits.cc:17: SkColorType fColorType;
I know this is just copied code, but shouldn't we be using Chromium-style
naming?

https://codereview.chromium.org/1824993004/diff/220001/ui/gfx/ipc/gfx_skia_pa...
File ui/gfx/ipc/gfx_skia_param_traits.h (right):

https://codereview.chromium.org/1824993004/diff/220001/ui/gfx/ipc/gfx_skia_pa...
ui/gfx/ipc/gfx_skia_param_traits.h:24: typedef SkBitmap param_type;
using

https://codereview.chromium.org/1824993004/diff/220001/ui/gfx/ipc/gfx_skia_pa...
ui/gfx/ipc/gfx_skia_param_traits.h:28: // r->SetConfig() and r->SetPixels() are
called.
Remove this comment, it's implied by the argument type.

[Devlin, 2016-03-28 21:01:50]

rdevlin.cronin@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[Devlin, 2016-03-28 21:01:51]

Maybe I'm missing something, but it doesn't look like most of these includes are
needed?

https://codereview.chromium.org/1824993004/diff/220001/chrome/browser/extensi...
File
chrome/browser/extensions/api/declarative_content/content_action_unittest.cc
(right):

https://codereview.chromium.org/1824993004/diff/220001/chrome/browser/extensi...
chrome/browser/extensions/api/declarative_content/content_action_unittest.cc:32:
#include "ui/gfx/ipc/gfx_skia_param_traits.h"
Are either of these needed here?  Or could we just remove gfx_param_traits.h
from this file instead?

https://codereview.chromium.org/1824993004/diff/220001/chrome/browser/extensi...
File chrome/browser/extensions/extension_action.cc (right):

https://codereview.chromium.org/1824993004/diff/220001/chrome/browser/extensi...
chrome/browser/extensions/extension_action.cc:38: #include
"ui/gfx/ipc/gfx_skia_param_traits.h"
ditto

https://codereview.chromium.org/1824993004/diff/220001/extensions/common/exte...
File extensions/common/extension_messages.h (right):

https://codereview.chromium.org/1824993004/diff/220001/extensions/common/exte...
extensions/common/extension_messages.h:33: #include
"ui/gfx/ipc/gfx_skia_param_traits.h"
ditto

https://codereview.chromium.org/1824993004/diff/220001/extensions/common/exte...
File extensions/common/extension_utility_messages.h (right):

https://codereview.chromium.org/1824993004/diff/220001/extensions/common/exte...
extensions/common/extension_utility_messages.h:14: #include
"ui/gfx/ipc/gfx_skia_param_traits.h"
ditto

https://codereview.chromium.org/1824993004/diff/220001/extensions/common/gues...
File extensions/common/guest_view/extensions_guest_view_messages.h (right):

https://codereview.chromium.org/1824993004/diff/220001/extensions/common/gues...
extensions/common/guest_view/extensions_guest_view_messages.h:13: #include
"ui/gfx/ipc/gfx_skia_param_traits.h"
Is skia needed here?

https://codereview.chromium.org/1824993004/diff/220001/extensions/renderer/se...
File extensions/renderer/set_icon_natives.cc (right):

https://codereview.chromium.org/1824993004/diff/220001/extensions/renderer/se...
extensions/renderer/set_icon_natives.cc:22: #include
"ui/gfx/ipc/gfx_skia_param_traits.h"
ditto

https://codereview.chromium.org/1824993004/diff/220001/extensions/utility/unp...
File extensions/utility/unpacker.cc (right):

https://codereview.chromium.org/1824993004/diff/220001/extensions/utility/unp...
extensions/utility/unpacker.cc:39: #include "ui/gfx/ipc/gfx_skia_param_traits.h"
ditto

[rjkroege, 2016-03-28 21:58:56]

rjkroege@chromium.org changed reviewers:
+ rjkroege@chromium.org

[rjkroege, 2016-03-28 21:58:58]

ui/ozone LGTM

[Mark Dittmer, 2016-03-29 17:40:48]

Addressed outstanding code review comments

[Mark Dittmer, 2016-03-29 17:41:25]

Comments addressed. danakj@, dcheng@, rdcronin@ PTAL.

https://codereview.chromium.org/1824993004/diff/220001/chrome/browser/extensi...
File
chrome/browser/extensions/api/declarative_content/content_action_unittest.cc
(right):

https://codereview.chromium.org/1824993004/diff/220001/chrome/browser/extensi...
chrome/browser/extensions/api/declarative_content/content_action_unittest.cc:32:
#include "ui/gfx/ipc/gfx_skia_param_traits.h"
On 2016/03/28 21:01:51, Devlin wrote:
> Are either of these needed here?  Or could we just remove gfx_param_traits.h
> from this file instead?

This file needs IPC::WriteParam<SkBitmap>.

https://codereview.chromium.org/1824993004/diff/220001/chrome/browser/extensi...
File chrome/browser/extensions/extension_action.cc (right):

https://codereview.chromium.org/1824993004/diff/220001/chrome/browser/extensi...
chrome/browser/extensions/extension_action.cc:38: #include
"ui/gfx/ipc/gfx_skia_param_traits.h"
On 2016/03/28 21:01:51, Devlin wrote:
> ditto

This file needs IPC::ParamTraits<SkBitmap>.

https://codereview.chromium.org/1824993004/diff/220001/extensions/common/exte...
File extensions/common/extension_messages.h (right):

https://codereview.chromium.org/1824993004/diff/220001/extensions/common/exte...
extensions/common/extension_messages.h:33: #include
"ui/gfx/ipc/gfx_skia_param_traits.h"
On 2016/03/28 21:01:51, Devlin wrote:
> ditto

Done.

https://codereview.chromium.org/1824993004/diff/220001/extensions/common/gues...
File extensions/common/guest_view/extensions_guest_view_messages.h (right):

https://codereview.chromium.org/1824993004/diff/220001/extensions/common/gues...
extensions/common/guest_view/extensions_guest_view_messages.h:13: #include
"ui/gfx/ipc/gfx_skia_param_traits.h"
On 2016/03/28 21:01:51, Devlin wrote:
> Is skia needed here?

Done.

https://codereview.chromium.org/1824993004/diff/220001/extensions/utility/unp...
File extensions/utility/unpacker.cc (right):

https://codereview.chromium.org/1824993004/diff/220001/extensions/utility/unp...
extensions/utility/unpacker.cc:39: #include "ui/gfx/ipc/gfx_skia_param_traits.h"
On 2016/03/28 21:01:51, Devlin wrote:
> ditto

Done.

https://codereview.chromium.org/1824993004/diff/220001/ui/gfx/ipc/gfx_skia_ip...
File ui/gfx/ipc/gfx_skia_ipc_export.h (right):

https://codereview.chromium.org/1824993004/diff/220001/ui/gfx/ipc/gfx_skia_ip...
ui/gfx/ipc/gfx_skia_ipc_export.h:1: // Copyright 2014 The Chromium Authors. All
rights reserved.
On 2016/03/28 20:33:16, danakj wrote:
> 2016

Done.

https://codereview.chromium.org/1824993004/diff/220001/ui/gfx/ipc/gfx_skia_ip...
ui/gfx/ipc/gfx_skia_ipc_export.h:11: #if defined(GFX_SKIA_IPC_IMPLEMENTATION)
On 2016/03/28 20:33:16, danakj wrote:
> It's unusual to have 2 components in the same directory. ipc/skia/ ?

Done.

https://codereview.chromium.org/1824993004/diff/220001/ui/gfx/ipc/gfx_skia_pa...
File ui/gfx/ipc/gfx_skia_param_traits.cc (right):

https://codereview.chromium.org/1824993004/diff/220001/ui/gfx/ipc/gfx_skia_pa...
ui/gfx/ipc/gfx_skia_param_traits.cc:17: SkColorType fColorType;
On 2016/03/28 20:37:56, dcheng wrote:
> I know this is just copied code, but shouldn't we be using Chromium-style
> naming?

Done.

https://codereview.chromium.org/1824993004/diff/220001/ui/gfx/ipc/gfx_skia_pa...
File ui/gfx/ipc/gfx_skia_param_traits.h (right):

https://codereview.chromium.org/1824993004/diff/220001/ui/gfx/ipc/gfx_skia_pa...
ui/gfx/ipc/gfx_skia_param_traits.h:24: typedef SkBitmap param_type;
On 2016/03/28 20:37:57, dcheng wrote:
> using

Done.

https://codereview.chromium.org/1824993004/diff/220001/ui/gfx/ipc/gfx_skia_pa...
ui/gfx/ipc/gfx_skia_param_traits.h:28: // r->SetConfig() and r->SetPixels() are
called.
On 2016/03/28 20:37:56, dcheng wrote:
> Remove this comment, it's implied by the argument type.

Done.

[Mark Dittmer, 2016-03-29 17:41:42]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-29 17:42:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1824993004/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1824993004/240001

[commit-bot: I haz the power, 2016-03-29 18:02:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-29 18:02:19]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mark Dittmer, 2016-03-29 18:40:42]

rebase

[Mark Dittmer, 2016-03-29 18:41:39]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-29 18:42:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1824993004/260001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1824993004/260001

[commit-bot: I haz the power, 2016-03-29 18:55:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-29 18:55:43]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[danakj, 2016-03-29 19:47:31]

https://codereview.chromium.org/1824993004/diff/260001/ui/gfx/ipc/gfx_ipc.gyp
File ui/gfx/ipc/gfx_ipc.gyp (right):

https://codereview.chromium.org/1824993004/diff/260001/ui/gfx/ipc/gfx_ipc.gyp...
ui/gfx/ipc/gfx_ipc.gyp:33: # GN version: //ui/gfx/ipc:skia_ipc
Still correct?

I think you have this in gyp twice now.

https://codereview.chromium.org/1824993004/diff/260001/ui/gfx/ipc/skia/gfx_sk...
File ui/gfx/ipc/skia/gfx_skia_param_traits.cc (right):

https://codereview.chromium.org/1824993004/diff/260001/ui/gfx/ipc/skia/gfx_sk...
ui/gfx/ipc/skia/gfx_skia_param_traits.cc:73: NOTREACHED();
Don't NOTREACHED() and return. Choose one of DCHECK or return. This is reading
IPC so you probably want just return?

[Devlin, 2016-03-29 20:01:56]

https://codereview.chromium.org/1824993004/diff/220001/chrome/browser/extensi...
File
chrome/browser/extensions/api/declarative_content/content_action_unittest.cc
(right):

https://codereview.chromium.org/1824993004/diff/220001/chrome/browser/extensi...
chrome/browser/extensions/api/declarative_content/content_action_unittest.cc:32:
#include "ui/gfx/ipc/gfx_skia_param_traits.h"
On 2016/03/29 17:41:24, Mark Dittmer wrote:
> On 2016/03/28 21:01:51, Devlin wrote:
> > Are either of these needed here?  Or could we just remove gfx_param_traits.h
> > from this file instead?
> 
> This file needs IPC::WriteParam<SkBitmap>.

But not gfx_param_traits.h now, right?  Sorry if I was unclear - I meant can we
check that
a) all places we add gfx_skia_param_traits.h need it, as well as
b) can we remove gfx_param_traits.h if we only use skia_param_traits now

[Mark Dittmer, 2016-03-30 22:04:03]

Addressed outstanding code review comments

[Mark Dittmer, 2016-03-30 22:04:41]

Comments addressed. danakj@, dcheng@, rdcronin@ PTAL.

https://codereview.chromium.org/1824993004/diff/220001/chrome/browser/extensi...
File
chrome/browser/extensions/api/declarative_content/content_action_unittest.cc
(right):

https://codereview.chromium.org/1824993004/diff/220001/chrome/browser/extensi...
chrome/browser/extensions/api/declarative_content/content_action_unittest.cc:32:
#include "ui/gfx/ipc/gfx_skia_param_traits.h"
On 2016/03/29 20:01:56, Devlin wrote:
> On 2016/03/29 17:41:24, Mark Dittmer wrote:
> > On 2016/03/28 21:01:51, Devlin wrote:
> > > Are either of these needed here?  Or could we just remove
gfx_param_traits.h
> > > from this file instead?
> > 
> > This file needs IPC::WriteParam<SkBitmap>.
> 
> But not gfx_param_traits.h now, right?  Sorry if I was unclear - I meant can
we
> check that
> a) all places we add gfx_skia_param_traits.h need it, as well as
> b) can we remove gfx_param_traits.h if we only use skia_param_traits now

I see. Yes. In this case, we don't need gfx_param_traits.h anymore.

https://codereview.chromium.org/1824993004/diff/220001/chrome/browser/extensi...
File chrome/browser/extensions/extension_action.cc (right):

https://codereview.chromium.org/1824993004/diff/220001/chrome/browser/extensi...
chrome/browser/extensions/extension_action.cc:38: #include
"ui/gfx/ipc/gfx_skia_param_traits.h"
On 2016/03/29 17:41:24, Mark Dittmer wrote:
> On 2016/03/28 21:01:51, Devlin wrote:
> > ditto
> 
> This file needs IPC::ParamTraits<SkBitmap>.

Removed unnecessary non-skia include.

https://codereview.chromium.org/1824993004/diff/220001/extensions/common/exte...
File extensions/common/extension_utility_messages.h (right):

https://codereview.chromium.org/1824993004/diff/220001/extensions/common/exte...
extensions/common/extension_utility_messages.h:14: #include
"ui/gfx/ipc/gfx_skia_param_traits.h"
On 2016/03/28 21:01:51, Devlin wrote:
> ditto

Removed unnecessary non-skia include.

https://codereview.chromium.org/1824993004/diff/220001/extensions/renderer/se...
File extensions/renderer/set_icon_natives.cc (right):

https://codereview.chromium.org/1824993004/diff/220001/extensions/renderer/se...
extensions/renderer/set_icon_natives.cc:22: #include
"ui/gfx/ipc/gfx_skia_param_traits.h"
On 2016/03/28 21:01:51, Devlin wrote:
> ditto

Removed both gfx ipc includes.

https://codereview.chromium.org/1824993004/diff/260001/ui/gfx/ipc/gfx_ipc.gyp
File ui/gfx/ipc/gfx_ipc.gyp (right):

https://codereview.chromium.org/1824993004/diff/260001/ui/gfx/ipc/gfx_ipc.gyp...
ui/gfx/ipc/gfx_ipc.gyp:33: # GN version: //ui/gfx/ipc:skia_ipc
On 2016/03/29 19:47:31, danakj wrote:
> Still correct?
> 
> I think you have this in gyp twice now.

Thanks! Fixed.

https://codereview.chromium.org/1824993004/diff/260001/ui/gfx/ipc/skia/gfx_sk...
File ui/gfx/ipc/skia/gfx_skia_param_traits.cc (right):

https://codereview.chromium.org/1824993004/diff/260001/ui/gfx/ipc/skia/gfx_sk...
ui/gfx/ipc/skia/gfx_skia_param_traits.cc:73: NOTREACHED();
On 2016/03/29 19:47:31, danakj wrote:
> Don't NOTREACHED() and return. Choose one of DCHECK or return. This is reading
> IPC so you probably want just return?

Switched to DCHECK(false).

[Devlin, 2016-03-30 22:07:13]

extensions lgtm

[Mark Dittmer, 2016-03-30 22:07:48]

markdittmer@chromium.org changed reviewers:
+ jam@chromium.org, nasko@chromium.org

[Mark Dittmer, 2016-03-30 22:08:11]

+nasko@, +jam@ for remaining owners review. PTAL.

[Mark Dittmer, 2016-03-30 22:08:37]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-30 22:09:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1824993004/280001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1824993004/280001

[danakj, 2016-03-30 22:11:41]

https://codereview.chromium.org/1824993004/diff/260001/ui/gfx/ipc/skia/gfx_sk...
File ui/gfx/ipc/skia/gfx_skia_param_traits.cc (right):

https://codereview.chromium.org/1824993004/diff/260001/ui/gfx/ipc/skia/gfx_sk...
ui/gfx/ipc/skia/gfx_skia_param_traits.cc:73: NOTREACHED();
On 2016/03/30 22:04:41, Mark Dittmer wrote:
> On 2016/03/29 19:47:31, danakj wrote:
> > Don't NOTREACHED() and return. Choose one of DCHECK or return. This is
reading
> > IPC so you probably want just return?
> 
> Switched to DCHECK(false).

Sorry that's not what I meant. I mean choose one:
a) early out/return
b) dcheck

Right now you have both. Writing DCHECK(false) or NOTREACHED are the same thing.

See
https://www.chromium.org/developers/coding-style#TOC-CHECK-DCHECK-and-NOTREAC...

[Mark Dittmer, 2016-03-30 22:18:16]

Return early instead of DCHECK/NOTREACHED

[Mark Dittmer, 2016-03-30 22:18:20]

https://codereview.chromium.org/1824993004/diff/260001/ui/gfx/ipc/skia/gfx_sk...
File ui/gfx/ipc/skia/gfx_skia_param_traits.cc (right):

https://codereview.chromium.org/1824993004/diff/260001/ui/gfx/ipc/skia/gfx_sk...
ui/gfx/ipc/skia/gfx_skia_param_traits.cc:73: NOTREACHED();
On 2016/03/30 22:11:41, danakj wrote:
> On 2016/03/30 22:04:41, Mark Dittmer wrote:
> > On 2016/03/29 19:47:31, danakj wrote:
> > > Don't NOTREACHED() and return. Choose one of DCHECK or return. This is
> reading
> > > IPC so you probably want just return?
> > 
> > Switched to DCHECK(false).
> 
> Sorry that's not what I meant. I mean choose one:
> a) early out/return
> b) dcheck
> 
> Right now you have both. Writing DCHECK(false) or NOTREACHED are the same
thing.
> 
> See
>
https://www.chromium.org/developers/coding-style#TOC-CHECK-DCHECK-and-NOTREAC...

I misunderstood. Thanks for clarifying. Now just returning false.

[Mark Dittmer, 2016-03-30 22:19:31]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-30 22:20:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1824993004/300001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1824993004/300001

[danakj, 2016-03-30 22:31:09]

Thanks! LGTM

[commit-bot: I haz the power, 2016-03-30 22:34:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-30 22:34:37]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mark Dittmer, 2016-03-31 14:23:44]

Rebase and move gfx::Transform traits to skia-included traits

[Mark Dittmer, 2016-03-31 14:25:45]

markdittmer@chromium.org changed reviewers:
+ tsepez@chromium.org
- nasko@chromium.org

[Mark Dittmer, 2016-03-31 14:28:49]

dcheng@, PTAL @ ipc
tsepez@, PTAL @ gfx*_param_traits
jam@, PTAL @ chrome+components+content

[Mark Dittmer, 2016-03-31 14:29:03]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-31 14:29:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1824993004/320001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1824993004/320001

[commit-bot: I haz the power, 2016-03-31 14:39:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 14:39:55]

Dry run: Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/8...)
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Mark Dittmer, 2016-03-31 15:45:08]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[Mark Dittmer, 2016-03-31 15:45:27]

The CQ bit was unchecked by markdittmer@chromium.org

[Mark Dittmer, 2016-03-31 15:46:56]

Fix up skia gfx::Transform param traits

[Tom Sepez, 2016-03-31 16:01:34]

lgtm

https://codereview.chromium.org/1824993004/diff/340001/content/content_tests....
File content/content_tests.gypi (right):

https://codereview.chromium.org/1824993004/diff/340001/content/content_tests....
content/content_tests.gypi:868: '../net/net.gyp:net_test_support',
nit: stray whitespace at end of line?

https://codereview.chromium.org/1824993004/diff/340001/content/content_tests....
content/content_tests.gypi:894:
'browser/speech/proto/speech_proto.gyp:speech_proto',
ditto

https://codereview.chromium.org/1824993004/diff/340001/ui/gfx/ipc/skia/gfx_sk...
File ui/gfx/ipc/skia/gfx_skia_param_traits.h (right):

https://codereview.chromium.org/1824993004/diff/340001/ui/gfx/ipc/skia/gfx_sk...
ui/gfx/ipc/skia/gfx_skia_param_traits.h:39: typedef gfx::Transform param_type;
nit: use "using" while we're at it.

[Mark Dittmer, 2016-03-31 16:04:56]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-31 16:05:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1824993004/340001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1824993004/340001

[commit-bot: I haz the power, 2016-03-31 16:08:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 16:08:12]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Mark Dittmer, 2016-03-31 16:19:03]

Address nits from tsepez@

[Mark Dittmer, 2016-03-31 16:20:17]

The CQ bit was checked by markdittmer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-31 16:20:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1824993004/360001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1824993004/360001

[Mark Dittmer, 2016-03-31 16:21:29]

https://codereview.chromium.org/1824993004/diff/340001/content/content_tests....
File content/content_tests.gypi (right):

https://codereview.chromium.org/1824993004/diff/340001/content/content_tests....
content/content_tests.gypi:868: '../net/net.gyp:net_test_support',
On 2016/03/31 16:01:33, Tom Sepez wrote:
> nit: stray whitespace at end of line?

Done.

https://codereview.chromium.org/1824993004/diff/340001/content/content_tests....
content/content_tests.gypi:894:
'browser/speech/proto/speech_proto.gyp:speech_proto',
On 2016/03/31 16:01:34, Tom Sepez wrote:
> ditto

Done.

https://codereview.chromium.org/1824993004/diff/340001/ui/gfx/ipc/skia/gfx_sk...
File ui/gfx/ipc/skia/gfx_skia_param_traits.h (right):

https://codereview.chromium.org/1824993004/diff/340001/ui/gfx/ipc/skia/gfx_sk...
ui/gfx/ipc/skia/gfx_skia_param_traits.h:39: typedef gfx::Transform param_type;
On 2016/03/31 16:01:34, Tom Sepez wrote:
> nit: use "using" while we're at it.

Done.

[commit-bot: I haz the power, 2016-03-31 16:34:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 16:34:13]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)

[dcheng, 2016-03-31 16:54:21]

lgtm

[jam, 2016-03-31 17:38:33]

lgtm

[Mark Dittmer, 2016-03-31 18:34:23]

The CQ bit was checked by markdittmer@chromium.org

[Mark Dittmer, 2016-03-31 18:34:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
rjkroege@chromium.org, piman@chromium.org, rdevlin.cronin@chromium.org,
danakj@chromium.org, tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/1824993004/#ps360001
(title: "Address nits from tsepez@")

[commit-bot: I haz the power, 2016-03-31 18:34:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1824993004/360001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1824993004/360001

[commit-bot: I haz the power, 2016-03-31 19:03:33]

Description was changed from

==========
Separate gfx_ipc into skia-dependent and non-skia-dependent parts. This will
simplify dependencies in gpu/ipc/common, as a part of the content/common/gpu -->
gpu refactor.

BUG=596242
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Separate gfx_ipc into skia-dependent and non-skia-dependent parts. This will
simplify dependencies in gpu/ipc/common, as a part of the content/common/gpu -->
gpu refactor.

BUG=596242
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-03-31 19:03:35]

Committed patchset #19 (id:360001)

[commit-bot: I haz the power, 2016-03-31 19:05:15]

Description was changed from

==========
Separate gfx_ipc into skia-dependent and non-skia-dependent parts. This will
simplify dependencies in gpu/ipc/common, as a part of the content/common/gpu -->
gpu refactor.

BUG=596242
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Separate gfx_ipc into skia-dependent and non-skia-dependent parts. This will
simplify dependencies in gpu/ipc/common, as a part of the content/common/gpu -->
gpu refactor.

BUG=596242
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69
Cr-Commit-Position: refs/heads/master@{#384351}
==========

[commit-bot: I haz the power, 2016-03-31 19:05:18]

Patchset 19 (id:??) landed as
https://crrev.com/99d77bf02c02eaa19848b709e53c88157467df69
Cr-Commit-Position: refs/heads/master@{#384351}

[qiangchen, 2016-04-07 19:41:42]

qiangchen@chromium.org changed reviewers:
+ qiangchen@chromium.org

[qiangchen, 2016-04-07 19:41:44]

Hi, Mark:

    I cannot compile Chrome for ChromeOS, following go/simplechrome. After
investigation, I think the reason is in this CL. I left a comment in your last
patch.

    Can you take a look? 
 
    P.S. I am not sure why the trybots can compile, but not on my local machine.

Qiang

https://codereview.chromium.org/1824993004/diff/360001/ui/ozone/ozone.gyp
File ui/ozone/ozone.gyp (right):

https://codereview.chromium.org/1824993004/diff/360001/ui/ozone/ozone.gyp#new...
ui/ozone/ozone.gyp:81: '<(DEPTH)/ui/gfx/ipc/skia/gfx_ipc_skia.gyp:gfx_ipc_skia',
You removed gfx_ipc here.

This is the reason that I cannot compile chrome for chromeos, following
go/simplechrome.

P.S. I am not sure why trybots can compile.

https://codereview.chromium.org/1824993004/diff/360001/ui/ozone/ozone.gyp#new...
ui/ozone/ozone.gyp:118:
'<(DEPTH)/ui/gfx/ipc/skia/gfx_ipc_skia.gyp:gfx_ipc_skia',
ditto

[Mark Dittmer, 2016-04-07 20:47:00]

On 2016/04/07 19:41:44, qiangchenC wrote:
> Hi, Mark:
> 
>     I cannot compile Chrome for ChromeOS, following go/simplechrome. After
> investigation, I think the reason is in this CL. I left a comment in your last
> patch.
> 
>     Can you take a look? 
>  
>     P.S. I am not sure why the trybots can compile, but not on my local
machine.
> 
> Qiang
> 
> https://codereview.chromium.org/1824993004/diff/360001/ui/ozone/ozone.gyp
> File ui/ozone/ozone.gyp (right):
> 
>
https://codereview.chromium.org/1824993004/diff/360001/ui/ozone/ozone.gyp#new...
> ui/ozone/ozone.gyp:81:
'<(DEPTH)/ui/gfx/ipc/skia/gfx_ipc_skia.gyp:gfx_ipc_skia',
> You removed gfx_ipc here.
> 
> This is the reason that I cannot compile chrome for chromeos, following
> go/simplechrome.
> 
> P.S. I am not sure why trybots can compile.
> 
>
https://codereview.chromium.org/1824993004/diff/360001/ui/ozone/ozone.gyp#new...
> ui/ozone/ozone.gyp:118:
> '<(DEPTH)/ui/gfx/ipc/skia/gfx_ipc_skia.gyp:gfx_ipc_skia',
> ditto

Thanks for bringing this to my attention, Qiang. I think I see the source of the
issue. I'll try to address it first thing tomorrow morning.

[Mark Dittmer, 2016-04-08 15:21:02]

On 2016/04/07 20:47:00, Mark Dittmer wrote:
> On 2016/04/07 19:41:44, qiangchenC wrote:
> > Hi, Mark:
> > 
> >     I cannot compile Chrome for ChromeOS, following go/simplechrome. After
> > investigation, I think the reason is in this CL. I left a comment in your
last
> > patch.
> > 
> >     Can you take a look? 
> >  
> >     P.S. I am not sure why the trybots can compile, but not on my local
> machine.
> > 
> > Qiang
> > 
> > https://codereview.chromium.org/1824993004/diff/360001/ui/ozone/ozone.gyp
> > File ui/ozone/ozone.gyp (right):
> > 
> >
>
https://codereview.chromium.org/1824993004/diff/360001/ui/ozone/ozone.gyp#new...
> > ui/ozone/ozone.gyp:81:
> '<(DEPTH)/ui/gfx/ipc/skia/gfx_ipc_skia.gyp:gfx_ipc_skia',
> > You removed gfx_ipc here.
> > 
> > This is the reason that I cannot compile chrome for chromeos, following
> > go/simplechrome.
> > 
> > P.S. I am not sure why trybots can compile.
> > 
> >
>
https://codereview.chromium.org/1824993004/diff/360001/ui/ozone/ozone.gyp#new...
> > ui/ozone/ozone.gyp:118:
> > '<(DEPTH)/ui/gfx/ipc/skia/gfx_ipc_skia.gyp:gfx_ipc_skia',
> > ditto
> 
> Thanks for bringing this to my attention, Qiang. I think I see the source of
the
> issue. I'll try to address it first thing tomorrow morning.

Building simple chrome works for me. Could you please post your configuration
and the command you're using to setup and build?

[qiangchen, 2016-04-08 16:32:24]

On 2016/04/08 15:21:02, Mark Dittmer wrote:
> On 2016/04/07 20:47:00, Mark Dittmer wrote:
> > On 2016/04/07 19:41:44, qiangchenC wrote:
> > > Hi, Mark:
> > > 
> > >     I cannot compile Chrome for ChromeOS, following go/simplechrome. After
> > > investigation, I think the reason is in this CL. I left a comment in your
> last
> > > patch.
> > > 
> > >     Can you take a look? 
> > >  
> > >     P.S. I am not sure why the trybots can compile, but not on my local
> > machine.
> > > 
> > > Qiang
> > > 
> > > https://codereview.chromium.org/1824993004/diff/360001/ui/ozone/ozone.gyp
> > > File ui/ozone/ozone.gyp (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/1824993004/diff/360001/ui/ozone/ozone.gyp#new...
> > > ui/ozone/ozone.gyp:81:
> > '<(DEPTH)/ui/gfx/ipc/skia/gfx_ipc_skia.gyp:gfx_ipc_skia',
> > > You removed gfx_ipc here.
> > > 
> > > This is the reason that I cannot compile chrome for chromeos, following
> > > go/simplechrome.
> > > 
> > > P.S. I am not sure why trybots can compile.
> > > 
> > >
> >
>
https://codereview.chromium.org/1824993004/diff/360001/ui/ozone/ozone.gyp#new...
> > > ui/ozone/ozone.gyp:118:
> > > '<(DEPTH)/ui/gfx/ipc/skia/gfx_ipc_skia.gyp:gfx_ipc_skia',
> > > ditto
> > 
> > Thanks for bringing this to my attention, Qiang. I think I see the source of
> the
> > issue. I'll try to address it first thing tomorrow morning.
> 
> Building simple chrome works for me. Could you please post your configuration
> and the command you're using to setup and build?

I just run "cros chrome-sdk --board=veyron_speedy", and I did not change any
settings from default.

The GYP_DEFINES is (default value, I did not change anything)

use_ozone=1 remoting=1 ozone_platform_gbm=1 use_brlapi=1 linux_use_gold_flags=1
arm_neon=1 chromeos=1 linux_use_debug_fission=0 use_vtable_verify=0 host_clang=1
disable_nacl=0 gomadir=/work/chromium/.cros_cache/common/goma+2
use_evdev_gestures=1 use_goma=1 release_extra_cflags=-g1 arm_float_abi=hard
target_arch=arm clang_use_chrome_plugins=0 system_libdir=lib use_cras=1
sysroot=/work/chromium/.cros_cache/chrome-sdk/tarballs/veyron_speedy+8157.0.0+sysroot_chromeos-base_chromeos-chrome.tar.xz
linux_link_libbrlapi=1 use_v4l2_codec=1 use_xkbcommon=1 clang=0
linux_use_bundled_binutils=0 arm_fpu=neon use_v4lplugin=1
linux_use_bundled_gold=0 icu_use_data_file_flag=1 asan=0
use_mesa_platform_null=1 use_system_minigbm=1 ozone_auto_platforms=0
use_vgem_map=1 internal_khronos_glcts_tests=1 ozone_platform=gbm



The error is a link error:
../../ipc/ipc_message_utils.h:111: error: undefined reference to
'IPC::ParamTraits<gfx::Point>::Read(base::Pickle const*, base::PickleIterator*,
gfx::Point*)'

The claimed undefined function is actually defined in
"ui/gfx/ipc/gfx_param_traits.cc"

After I added "<(DEPTH)/ui/gfx/ipc/gfx_ipc.gyp:gfx_ipc" in ozone.gyp, it can
successfully compile.

Do you have an idea of what's wrong, or what should I set?

[Mark Dittmer, 2016-04-08 20:40:33]

On 2016/04/08 16:32:24, qiangchenC wrote:
> On 2016/04/08 15:21:02, Mark Dittmer wrote:
> > On 2016/04/07 20:47:00, Mark Dittmer wrote:
> > > On 2016/04/07 19:41:44, qiangchenC wrote:
> > > > Hi, Mark:
> > > > 
> > > >     I cannot compile Chrome for ChromeOS, following go/simplechrome.
After
> > > > investigation, I think the reason is in this CL. I left a comment in
your
> > last
> > > > patch.
> > > > 
> > > >     Can you take a look? 
> > > >  
> > > >     P.S. I am not sure why the trybots can compile, but not on my local
> > > machine.
> > > > 
> > > > Qiang
> > > > 
> > > >
https://codereview.chromium.org/1824993004/diff/360001/ui/ozone/ozone.gyp
> > > > File ui/ozone/ozone.gyp (right):
> > > > 
> > > >
> > >
> >
>
https://codereview.chromium.org/1824993004/diff/360001/ui/ozone/ozone.gyp#new...
> > > > ui/ozone/ozone.gyp:81:
> > > '<(DEPTH)/ui/gfx/ipc/skia/gfx_ipc_skia.gyp:gfx_ipc_skia',
> > > > You removed gfx_ipc here.
> > > > 
> > > > This is the reason that I cannot compile chrome for chromeos, following
> > > > go/simplechrome.
> > > > 
> > > > P.S. I am not sure why trybots can compile.
> > > > 
> > > >
> > >
> >
>
https://codereview.chromium.org/1824993004/diff/360001/ui/ozone/ozone.gyp#new...
> > > > ui/ozone/ozone.gyp:118:
> > > > '<(DEPTH)/ui/gfx/ipc/skia/gfx_ipc_skia.gyp:gfx_ipc_skia',
> > > > ditto
> > > 
> > > Thanks for bringing this to my attention, Qiang. I think I see the source
of
> > the
> > > issue. I'll try to address it first thing tomorrow morning.
> > 
> > Building simple chrome works for me. Could you please post your
configuration
> > and the command you're using to setup and build?
> 
> I just run "cros chrome-sdk --board=veyron_speedy", and I did not change any
> settings from default.
> 
> The GYP_DEFINES is (default value, I did not change anything)
> 
> use_ozone=1 remoting=1 ozone_platform_gbm=1 use_brlapi=1
linux_use_gold_flags=1
> arm_neon=1 chromeos=1 linux_use_debug_fission=0 use_vtable_verify=0
host_clang=1
> disable_nacl=0 gomadir=/work/chromium/.cros_cache/common/goma+2
> use_evdev_gestures=1 use_goma=1 release_extra_cflags=-g1 arm_float_abi=hard
> target_arch=arm clang_use_chrome_plugins=0 system_libdir=lib use_cras=1
>
sysroot=/work/chromium/.cros_cache/chrome-sdk/tarballs/veyron_speedy+8157.0.0+sysroot_chromeos-base_chromeos-chrome.tar.xz
> linux_link_libbrlapi=1 use_v4l2_codec=1 use_xkbcommon=1 clang=0
> linux_use_bundled_binutils=0 arm_fpu=neon use_v4lplugin=1
> linux_use_bundled_gold=0 icu_use_data_file_flag=1 asan=0
> use_mesa_platform_null=1 use_system_minigbm=1 ozone_auto_platforms=0
> use_vgem_map=1 internal_khronos_glcts_tests=1 ozone_platform=gbm
> 
> 
> 
> The error is a link error:
> ../../ipc/ipc_message_utils.h:111: error: undefined reference to
> 'IPC::ParamTraits<gfx::Point>::Read(base::Pickle const*,
base::PickleIterator*,
> gfx::Point*)'
> 
> The claimed undefined function is actually defined in
> "ui/gfx/ipc/gfx_param_traits.cc"
> 
> After I added "<(DEPTH)/ui/gfx/ipc/gfx_ipc.gyp:gfx_ipc" in ozone.gyp, it can
> successfully compile.
> 
> Do you have an idea of what's wrong, or what should I set?

I can't seem to reproduce this issue with the same board name and GYP_DEFINES.
+rjkroege@. Rob, what other configuration differences might cause me and Qiang
to see different results?

[qiangchen, 2016-04-08 21:01:44]

On 2016/04/08 20:40:33, Mark Dittmer wrote:
> On 2016/04/08 16:32:24, qiangchenC wrote:
> > On 2016/04/08 15:21:02, Mark Dittmer wrote:
> > > On 2016/04/07 20:47:00, Mark Dittmer wrote:
> > > > On 2016/04/07 19:41:44, qiangchenC wrote:
> > > > > Hi, Mark:
> > > > > 
> > > > >     I cannot compile Chrome for ChromeOS, following go/simplechrome.
> After
> > > > > investigation, I think the reason is in this CL. I left a comment in
> your
> > > last
> > > > > patch.
> > > > > 
> > > > >     Can you take a look? 
> > > > >  
> > > > >     P.S. I am not sure why the trybots can compile, but not on my
local
> > > > machine.
> > > > > 
> > > > > Qiang
> > > > > 
> > > > >
> https://codereview.chromium.org/1824993004/diff/360001/ui/ozone/ozone.gyp
> > > > > File ui/ozone/ozone.gyp (right):
> > > > > 
> > > > >
> > > >
> > >
> >
>
https://codereview.chromium.org/1824993004/diff/360001/ui/ozone/ozone.gyp#new...
> > > > > ui/ozone/ozone.gyp:81:
> > > > '<(DEPTH)/ui/gfx/ipc/skia/gfx_ipc_skia.gyp:gfx_ipc_skia',
> > > > > You removed gfx_ipc here.
> > > > > 
> > > > > This is the reason that I cannot compile chrome for chromeos,
following
> > > > > go/simplechrome.
> > > > > 
> > > > > P.S. I am not sure why trybots can compile.
> > > > > 
> > > > >
> > > >
> > >
> >
>
https://codereview.chromium.org/1824993004/diff/360001/ui/ozone/ozone.gyp#new...
> > > > > ui/ozone/ozone.gyp:118:
> > > > > '<(DEPTH)/ui/gfx/ipc/skia/gfx_ipc_skia.gyp:gfx_ipc_skia',
> > > > > ditto
> > > > 
> > > > Thanks for bringing this to my attention, Qiang. I think I see the
source
> of
> > > the
> > > > issue. I'll try to address it first thing tomorrow morning.
> > > 
> > > Building simple chrome works for me. Could you please post your
> configuration
> > > and the command you're using to setup and build?
> > 
> > I just run "cros chrome-sdk --board=veyron_speedy", and I did not change any
> > settings from default.
> > 
> > The GYP_DEFINES is (default value, I did not change anything)
> > 
> > use_ozone=1 remoting=1 ozone_platform_gbm=1 use_brlapi=1
> linux_use_gold_flags=1
> > arm_neon=1 chromeos=1 linux_use_debug_fission=0 use_vtable_verify=0
> host_clang=1
> > disable_nacl=0 gomadir=/work/chromium/.cros_cache/common/goma+2
> > use_evdev_gestures=1 use_goma=1 release_extra_cflags=-g1 arm_float_abi=hard
> > target_arch=arm clang_use_chrome_plugins=0 system_libdir=lib use_cras=1
> >
>
sysroot=/work/chromium/.cros_cache/chrome-sdk/tarballs/veyron_speedy+8157.0.0+sysroot_chromeos-base_chromeos-chrome.tar.xz
> > linux_link_libbrlapi=1 use_v4l2_codec=1 use_xkbcommon=1 clang=0
> > linux_use_bundled_binutils=0 arm_fpu=neon use_v4lplugin=1
> > linux_use_bundled_gold=0 icu_use_data_file_flag=1 asan=0
> > use_mesa_platform_null=1 use_system_minigbm=1 ozone_auto_platforms=0
> > use_vgem_map=1 internal_khronos_glcts_tests=1 ozone_platform=gbm
> > 
> > 
> > 
> > The error is a link error:
> > ../../ipc/ipc_message_utils.h:111: error: undefined reference to
> > 'IPC::ParamTraits<gfx::Point>::Read(base::Pickle const*,
> base::PickleIterator*,
> > gfx::Point*)'
> > 
> > The claimed undefined function is actually defined in
> > "ui/gfx/ipc/gfx_param_traits.cc"
> > 
> > After I added "<(DEPTH)/ui/gfx/ipc/gfx_ipc.gyp:gfx_ipc" in ozone.gyp, it can
> > successfully compile.
> > 
> > Do you have an idea of what's wrong, or what should I set?
> 
> I can't seem to reproduce this issue with the same board name and GYP_DEFINES.
> +rjkroege@. Rob, what other configuration differences might cause me and Qiang
> to see different results?

Did you try the full build? (Delete the out folder, run gclient sync, then
ninja)
Incremental build over a good build may not incur the error.

[rjkroege, 2016-04-08 21:31:43]

On 2016/04/08 20:40:33, Mark Dittmer wrote:
> On 2016/04/08 16:32:24, qiangchenC wrote:
> > On 2016/04/08 15:21:02, Mark Dittmer wrote:
> > > On 2016/04/07 20:47:00, Mark Dittmer wrote:
> > > > On 2016/04/07 19:41:44, qiangchenC wrote:
> > > > > Hi, Mark:
> > > > > 
> > > > >     I cannot compile Chrome for ChromeOS, following go/simplechrome.
> After
> > > > > investigation, I think the reason is in this CL. I left a comment in
> your
> > > last
> > > > > patch.
> > > > > 
> > > > >     Can you take a look? 
> > > > >  
> > > > >     P.S. I am not sure why the trybots can compile, but not on my
local
> > > > machine.
> > > > > 
> > > > > Qiang
> > > > > 
> > > > >
> https://codereview.chromium.org/1824993004/diff/360001/ui/ozone/ozone.gyp
> > > > > File ui/ozone/ozone.gyp (right):
> > > > > 
> > > > >
> > > >
> > >
> >
>
https://codereview.chromium.org/1824993004/diff/360001/ui/ozone/ozone.gyp#new...
> > > > > ui/ozone/ozone.gyp:81:
> > > > '<(DEPTH)/ui/gfx/ipc/skia/gfx_ipc_skia.gyp:gfx_ipc_skia',
> > > > > You removed gfx_ipc here.
> > > > > 
> > > > > This is the reason that I cannot compile chrome for chromeos,
following
> > > > > go/simplechrome.
> > > > > 
> > > > > P.S. I am not sure why trybots can compile.
> > > > > 
> > > > >
> > > >
> > >
> >
>
https://codereview.chromium.org/1824993004/diff/360001/ui/ozone/ozone.gyp#new...
> > > > > ui/ozone/ozone.gyp:118:
> > > > > '<(DEPTH)/ui/gfx/ipc/skia/gfx_ipc_skia.gyp:gfx_ipc_skia',
> > > > > ditto
> > > > 
> > > > Thanks for bringing this to my attention, Qiang. I think I see the
source
> of
> > > the
> > > > issue. I'll try to address it first thing tomorrow morning.
> > > 
> > > Building simple chrome works for me. Could you please post your
> configuration
> > > and the command you're using to setup and build?
> > 
> > I just run "cros chrome-sdk --board=veyron_speedy", and I did not change any
> > settings from default.
> > 
> > The GYP_DEFINES is (default value, I did not change anything)
> > 
> > use_ozone=1 remoting=1 ozone_platform_gbm=1 use_brlapi=1
> linux_use_gold_flags=1
> > arm_neon=1 chromeos=1 linux_use_debug_fission=0 use_vtable_verify=0
> host_clang=1
> > disable_nacl=0 gomadir=/work/chromium/.cros_cache/common/goma+2
> > use_evdev_gestures=1 use_goma=1 release_extra_cflags=-g1 arm_float_abi=hard
> > target_arch=arm clang_use_chrome_plugins=0 system_libdir=lib use_cras=1
> >
>
sysroot=/work/chromium/.cros_cache/chrome-sdk/tarballs/veyron_speedy+8157.0.0+sysroot_chromeos-base_chromeos-chrome.tar.xz
> > linux_link_libbrlapi=1 use_v4l2_codec=1 use_xkbcommon=1 clang=0
> > linux_use_bundled_binutils=0 arm_fpu=neon use_v4lplugin=1
> > linux_use_bundled_gold=0 icu_use_data_file_flag=1 asan=0
> > use_mesa_platform_null=1 use_system_minigbm=1 ozone_auto_platforms=0
> > use_vgem_map=1 internal_khronos_glcts_tests=1 ozone_platform=gbm
> > 
> > 
> > 
> > The error is a link error:
> > ../../ipc/ipc_message_utils.h:111: error: undefined reference to
> > 'IPC::ParamTraits<gfx::Point>::Read(base::Pickle const*,
> base::PickleIterator*,
> > gfx::Point*)'
> > 
> > The claimed undefined function is actually defined in
> > "ui/gfx/ipc/gfx_param_traits.cc"
> > 
> > After I added "<(DEPTH)/ui/gfx/ipc/gfx_ipc.gyp:gfx_ipc" in ozone.gyp, it can
> > successfully compile.
> > 
> > Do you have an idea of what's wrong, or what should I set?
> 
> I can't seem to reproduce this issue with the same board name and GYP_DEFINES.
> +rjkroege@. Rob, what other configuration differences might cause me and Qiang
> to see different results?

Are you using the same sysroot version? It can change the compiler?

[Mark Dittmer, 2016-04-11 14:11:31]

On 2016/04/08 21:31:43, rjkroege wrote:
> On 2016/04/08 20:40:33, Mark Dittmer wrote:
> > On 2016/04/08 16:32:24, qiangchenC wrote:
> > > On 2016/04/08 15:21:02, Mark Dittmer wrote:
> > > > On 2016/04/07 20:47:00, Mark Dittmer wrote:
> > > > > On 2016/04/07 19:41:44, qiangchenC wrote:
> > > > > > Hi, Mark:
> > > > > > 
> > > > > >     I cannot compile Chrome for ChromeOS, following go/simplechrome.
> > After
> > > > > > investigation, I think the reason is in this CL. I left a comment in
> > your
> > > > last
> > > > > > patch.
> > > > > > 
> > > > > >     Can you take a look? 
> > > > > >  
> > > > > >     P.S. I am not sure why the trybots can compile, but not on my
> local
> > > > > machine.
> > > > > > 
> > > > > > Qiang
> > > > > > 
> > > > > >
> > https://codereview.chromium.org/1824993004/diff/360001/ui/ozone/ozone.gyp
> > > > > > File ui/ozone/ozone.gyp (right):
> > > > > > 
> > > > > >
> > > > >
> > > >
> > >
> >
>
https://codereview.chromium.org/1824993004/diff/360001/ui/ozone/ozone.gyp#new...
> > > > > > ui/ozone/ozone.gyp:81:
> > > > > '<(DEPTH)/ui/gfx/ipc/skia/gfx_ipc_skia.gyp:gfx_ipc_skia',
> > > > > > You removed gfx_ipc here.
> > > > > > 
> > > > > > This is the reason that I cannot compile chrome for chromeos,
> following
> > > > > > go/simplechrome.
> > > > > > 
> > > > > > P.S. I am not sure why trybots can compile.
> > > > > > 
> > > > > >
> > > > >
> > > >
> > >
> >
>
https://codereview.chromium.org/1824993004/diff/360001/ui/ozone/ozone.gyp#new...
> > > > > > ui/ozone/ozone.gyp:118:
> > > > > > '<(DEPTH)/ui/gfx/ipc/skia/gfx_ipc_skia.gyp:gfx_ipc_skia',
> > > > > > ditto
> > > > > 
> > > > > Thanks for bringing this to my attention, Qiang. I think I see the
> source
> > of
> > > > the
> > > > > issue. I'll try to address it first thing tomorrow morning.
> > > > 
> > > > Building simple chrome works for me. Could you please post your
> > configuration
> > > > and the command you're using to setup and build?
> > > 
> > > I just run "cros chrome-sdk --board=veyron_speedy", and I did not change
any
> > > settings from default.
> > > 
> > > The GYP_DEFINES is (default value, I did not change anything)
> > > 
> > > use_ozone=1 remoting=1 ozone_platform_gbm=1 use_brlapi=1
> > linux_use_gold_flags=1
> > > arm_neon=1 chromeos=1 linux_use_debug_fission=0 use_vtable_verify=0
> > host_clang=1
> > > disable_nacl=0 gomadir=/work/chromium/.cros_cache/common/goma+2
> > > use_evdev_gestures=1 use_goma=1 release_extra_cflags=-g1
arm_float_abi=hard
> > > target_arch=arm clang_use_chrome_plugins=0 system_libdir=lib use_cras=1
> > >
> >
>
sysroot=/work/chromium/.cros_cache/chrome-sdk/tarballs/veyron_speedy+8157.0.0+sysroot_chromeos-base_chromeos-chrome.tar.xz
> > > linux_link_libbrlapi=1 use_v4l2_codec=1 use_xkbcommon=1 clang=0
> > > linux_use_bundled_binutils=0 arm_fpu=neon use_v4lplugin=1
> > > linux_use_bundled_gold=0 icu_use_data_file_flag=1 asan=0
> > > use_mesa_platform_null=1 use_system_minigbm=1 ozone_auto_platforms=0
> > > use_vgem_map=1 internal_khronos_glcts_tests=1 ozone_platform=gbm
> > > 
> > > 
> > > 
> > > The error is a link error:
> > > ../../ipc/ipc_message_utils.h:111: error: undefined reference to
> > > 'IPC::ParamTraits<gfx::Point>::Read(base::Pickle const*,
> > base::PickleIterator*,
> > > gfx::Point*)'
> > > 
> > > The claimed undefined function is actually defined in
> > > "ui/gfx/ipc/gfx_param_traits.cc"
> > > 
> > > After I added "<(DEPTH)/ui/gfx/ipc/gfx_ipc.gyp:gfx_ipc" in ozone.gyp, it
can
> > > successfully compile.
> > > 
> > > Do you have an idea of what's wrong, or what should I set?
> > 
> > I can't seem to reproduce this issue with the same board name and
GYP_DEFINES.
> > +rjkroege@. Rob, what other configuration differences might cause me and
Qiang
> > to see different results?
> 
> Are you using the same sysroot version? It can change the compiler?

Here are my prompt and PATH:

(sdk veyron_speedy R51-8161.0.0) markdittmer@mditty: ~/src/chromium/src $

/usr/local/google/home/markdittmer/src/chromium/.cros_cache/common/gsutil_4.12.tar.gz/gsutil:/usr/local/google/home/markdittmer/src/chromium/src/third_party/chromite/bin:/usr/local/google/home/markdittmer/src/chromium/.cros_cache/chrome-sdk/tarballs/veyron_speedy+8161.0.0+target_toolchain/bin:/usr/lib/google-golang/bin:/usr/local/google/home/markdittmer/bin/goma:/usr/local/google/home/markdittmer/bin:/usr/local/google/home/markdittmer/.cabal/bin:/usr/local/buildtools/java/jdk/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/local/google/home/markdittmer/src/depot_tools:/usr/local/google/home/markdittmer/.fzf/bin


How do these compare to yours, Qiang?

[qiangchen, 2016-04-11 18:39:36]

On 2016/04/11 14:11:31, Mark Dittmer wrote:
> On 2016/04/08 21:31:43, rjkroege wrote:
> > On 2016/04/08 20:40:33, Mark Dittmer wrote:
> > > On 2016/04/08 16:32:24, qiangchenC wrote:
> > > > On 2016/04/08 15:21:02, Mark Dittmer wrote:
> > > > > On 2016/04/07 20:47:00, Mark Dittmer wrote:
> > > > > > On 2016/04/07 19:41:44, qiangchenC wrote:
> > > > > > > Hi, Mark:
> > > > > > > 
> > > > > > >     I cannot compile Chrome for ChromeOS, following
go/simplechrome.
> > > After
> > > > > > > investigation, I think the reason is in this CL. I left a comment
in
> > > your
> > > > > last
> > > > > > > patch.
> > > > > > > 
> > > > > > >     Can you take a look? 
> > > > > > >  
> > > > > > >     P.S. I am not sure why the trybots can compile, but not on my
> > local
> > > > > > machine.
> > > > > > > 
> > > > > > > Qiang
> > > > > > > 
> > > > > > >
> > > https://codereview.chromium.org/1824993004/diff/360001/ui/ozone/ozone.gyp
> > > > > > > File ui/ozone/ozone.gyp (right):
> > > > > > > 
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
https://codereview.chromium.org/1824993004/diff/360001/ui/ozone/ozone.gyp#new...
> > > > > > > ui/ozone/ozone.gyp:81:
> > > > > > '<(DEPTH)/ui/gfx/ipc/skia/gfx_ipc_skia.gyp:gfx_ipc_skia',
> > > > > > > You removed gfx_ipc here.
> > > > > > > 
> > > > > > > This is the reason that I cannot compile chrome for chromeos,
> > following
> > > > > > > go/simplechrome.
> > > > > > > 
> > > > > > > P.S. I am not sure why trybots can compile.
> > > > > > > 
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
https://codereview.chromium.org/1824993004/diff/360001/ui/ozone/ozone.gyp#new...
> > > > > > > ui/ozone/ozone.gyp:118:
> > > > > > > '<(DEPTH)/ui/gfx/ipc/skia/gfx_ipc_skia.gyp:gfx_ipc_skia',
> > > > > > > ditto
> > > > > > 
> > > > > > Thanks for bringing this to my attention, Qiang. I think I see the
> > source
> > > of
> > > > > the
> > > > > > issue. I'll try to address it first thing tomorrow morning.
> > > > > 
> > > > > Building simple chrome works for me. Could you please post your
> > > configuration
> > > > > and the command you're using to setup and build?
> > > > 
> > > > I just run "cros chrome-sdk --board=veyron_speedy", and I did not change
> any
> > > > settings from default.
> > > > 
> > > > The GYP_DEFINES is (default value, I did not change anything)
> > > > 
> > > > use_ozone=1 remoting=1 ozone_platform_gbm=1 use_brlapi=1
> > > linux_use_gold_flags=1
> > > > arm_neon=1 chromeos=1 linux_use_debug_fission=0 use_vtable_verify=0
> > > host_clang=1
> > > > disable_nacl=0 gomadir=/work/chromium/.cros_cache/common/goma+2
> > > > use_evdev_gestures=1 use_goma=1 release_extra_cflags=-g1
> arm_float_abi=hard
> > > > target_arch=arm clang_use_chrome_plugins=0 system_libdir=lib use_cras=1
> > > >
> > >
> >
>
sysroot=/work/chromium/.cros_cache/chrome-sdk/tarballs/veyron_speedy+8157.0.0+sysroot_chromeos-base_chromeos-chrome.tar.xz
> > > > linux_link_libbrlapi=1 use_v4l2_codec=1 use_xkbcommon=1 clang=0
> > > > linux_use_bundled_binutils=0 arm_fpu=neon use_v4lplugin=1
> > > > linux_use_bundled_gold=0 icu_use_data_file_flag=1 asan=0
> > > > use_mesa_platform_null=1 use_system_minigbm=1 ozone_auto_platforms=0
> > > > use_vgem_map=1 internal_khronos_glcts_tests=1 ozone_platform=gbm
> > > > 
> > > > 
> > > > 
> > > > The error is a link error:
> > > > ../../ipc/ipc_message_utils.h:111: error: undefined reference to
> > > > 'IPC::ParamTraits<gfx::Point>::Read(base::Pickle const*,
> > > base::PickleIterator*,
> > > > gfx::Point*)'
> > > > 
> > > > The claimed undefined function is actually defined in
> > > > "ui/gfx/ipc/gfx_param_traits.cc"
> > > > 
> > > > After I added "<(DEPTH)/ui/gfx/ipc/gfx_ipc.gyp:gfx_ipc" in ozone.gyp, it
> can
> > > > successfully compile.
> > > > 
> > > > Do you have an idea of what's wrong, or what should I set?
> > > 
> > > I can't seem to reproduce this issue with the same board name and
> GYP_DEFINES.
> > > +rjkroege@. Rob, what other configuration differences might cause me and
> Qiang
> > > to see different results?
> > 
> > Are you using the same sysroot version? It can change the compiler?
> 
> Here are my prompt and PATH:
> 
> (sdk veyron_speedy R51-8161.0.0) markdittmer@mditty: ~/src/chromium/src $
> 
>
/usr/local/google/home/markdittmer/src/chromium/.cros_cache/common/gsutil_4.12.tar.gz/gsutil:/usr/local/google/home/markdittmer/src/chromium/src/third_party/chromite/bin:/usr/local/google/home/markdittmer/src/chromium/.cros_cache/chrome-sdk/tarballs/veyron_speedy+8161.0.0+target_toolchain/bin:/usr/lib/google-golang/bin:/usr/local/google/home/markdittmer/bin/goma:/usr/local/google/home/markdittmer/bin:/usr/local/google/home/markdittmer/.cabal/bin:/usr/local/buildtools/java/jdk/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/local/google/home/markdittmer/src/depot_tools:/usr/local/google/home/markdittmer/.fzf/bin
> 
> 
> How do these compare to yours, Qiang?

(sdk veyron_speedy R51-8163.0.0) qiangchen@qiangchen: /work/chromium/src $ echo
$PATH
/work/chromium/.cros_cache/common/gsutil_4.12.tar.gz/gsutil:/work/chromium/src/third_party/chromite/bin:/work/chromium/.cros_cache/chrome-sdk/tarballs/veyron_speedy+8164.0.0+target_toolchain/bin:/work/depot_tools:/work/gsutil/gsutil:/usr/lib/google-golang/bin:/usr/local/buildtools/java/jdk/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin

I just updated my local code base today. I cannot see any significant
difference. I let one of my office mates try compiling on his machine. He can
compile it!
Or maybe I can add two lines in my local files to force it compile successfully.
Thanks for investigation of this issue.