ui/gfx/ipc/gfx_skia_ipc_export.h - Issue 1824993004: Separate gfx_ipc into skia-dependent and non-skia-dependent parts

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/gfx/ipc/gfx_skia_ipc_export.h

Issue 1824993004: Separate gfx_ipc into skia-dependent and non-skia-dependent parts (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add includes associated with new skia-only ui/gfx/ipc target Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.
	danakj 2016/03/28 20:33:16 2016 2016 Mark Dittmer 2016/03/29 17:41:25 Done. Show quoted text On 2016/03/28 20:33:16, danakj wrote: > 2016 Done.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef UI_GFX_IPC_GFX_SKIA_IPC_EXPORT_H_

	6 #define UI_GFX_IPC_GFX_SKIA_IPC_EXPORT_H_

	7

	8 #if defined(COMPONENT_BUILD)

	9 #if defined(WIN32)

	10

	11 #if defined(GFX_SKIA_IPC_IMPLEMENTATION)
	danakj 2016/03/28 20:33:16 It's unusual to have 2 components in the same dire It's unusual to have 2 components in the same directory. ipc/skia/ ? Mark Dittmer 2016/03/29 17:41:25 Done. Show quoted text On 2016/03/28 20:33:16, danakj wrote: > It's unusual to have 2 components in the same directory. ipc/skia/ ? Done.
	12 #define GFX_SKIA_IPC_EXPORT __declspec(dllexport)

	13 #else

	14 #define GFX_SKIA_IPC_EXPORT __declspec(dllimport)

	15 #endif // defined(GFX_SKIA_IPC_IMPLEMENTATION)

	16

	17 #else // defined(WIN32)

	18 #if defined(GFX_SKIA_IPC_IMPLEMENTATION)

	19 #define GFX_SKIA_IPC_EXPORT __attribute__((visibility("default")))

	20 #else

	21 #define GFX_SKIA_IPC_EXPORT

	22 #endif

	23 #endif

	24

	25 #else // defined(COMPONENT_BUILD)

	26 #define GFX_SKIA_IPC_EXPORT

	27 #endif

	28

	29 #endif // UI_GFX_IPC_GFX_SKIA_IPC_EXPORT_H_

OLD	NEW

« extensions/utility/unpacker.cc ('K') | « ui/gfx/ipc/gfx_param_traits.cc ('k') | ui/gfx/ipc/gfx_skia_param_traits.h » ('j') | ui/gfx/ipc/gfx_skia_param_traits.h » ('J')