Separate gfx_ipc into skia-dependent and non-skia-dependent parts

chrome/browser/extensions/api/declarative_content/content_action_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/declarative_content/content_action.h"
 
 #include <stdint.h>
 
 #include "base/base64.h"
 #include "base/run_loop.h"
@@ skipping 11 matching lines @@
 #include "extensions/common/extension.h"
 #include "extensions/common/extension_builder.h"
 #include "extensions/common/feature_switch.h"
 #include "extensions/common/value_builder.h"
 #include "ipc/ipc_message_utils.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "ui/gfx/image/image.h"
 #include "ui/gfx/ipc/gfx_param_traits.h"
+#include "ui/gfx/ipc/gfx_skia_param_traits.h"

[Devlin, 2016/03/28 21:01:51]

Are either of these needed here?  Or could we just remove gfx_param_traits.h
from this file instead?

[Mark Dittmer, 2016/03/29 17:41:24]

This file needs IPC::WriteParam<SkBitmap>.

[Devlin, 2016/03/29 20:01:56]

But not gfx_param_traits.h now, right?  Sorry if I was unclear - I meant can we
check that
a) all places we add gfx_skia_param_traits.h need it, as well as
b) can we remove gfx_param_traits.h if we only use skia_param_traits now

[Mark Dittmer, 2016/03/30 22:04:41]

I see. Yes. In this case, we don't need gfx_param_traits.h anymore.

 
 namespace extensions {
 namespace {
 
 using base::test::ParseJson;
 using testing::HasSubstr;
 
 
 scoped_ptr<base::DictionaryValue> SimpleManifest() {
   return DictionaryBuilder()
@@ skipping 302 matching lines @@
           "  \"instanceType\": \"declarativeContent.RequestContentScript\",\n"
           "  \"js\": [\"script.js\"],\n"
           "  \"matchAboutBlank\": null\n"
           "}"),
       &error);
   ASSERT_FALSE(result.get());
 }
 
 }  // namespace
 }  // namespace extensions