Mojom backend: Stop re-computing version info and field packing data.

Mojom backend: Stop re-computing version info and field packing data.

We have removed most of the logic from pack.py because these computations are now being performed
in the front end. What remains in pack.py is some logic to re-organize the data from the
intermediate representation into a form that the code generators want. As we start to build
new-generation backends we can re-visit the exact shape of the data we put into the
intermediate representation and perhaps some more of this reorganization logic might be
moved to the front end:
 - We left the PackedStruct object because this is what the code generators expect.
  It is mostly populated now by copying data from the intermediate representation.
 - We left the function GetByteLayout(). This function synthesizes the byte layout for a struct based on
equivalent data in the intermediate representation.
 - The utility function GetPad() seems to be used directly by some of the code generators.

Summary of changes:

- In pack.py we delete GetAlignmentForKind, GetFieldOffset, GetVersionInfo, and most of the logic in the PackedStruct
  constructor.

- We delete pack_tests.py and pack_unittest.py. These tests have been ported to Go tests in the frontend
  in https://codereview.chromium.org/1833593002/.

- In mojom_translator.py we translate the version_info field of a struct and the offset, bit and
  min_version fields of a struct field.

- In generator.py we stop creating synthetic request and response parameter structs and instead use
  the ones translated from the intermediate representation. Similarly we stop computing struct.versions.

- We modify the logic in mojom_go_generatory.py so that rather than constructing a new object
  to represent a synthetic parameter struct instead we use the object that has been translated
  from the intermediate representation, because that object contains the packing data.

- In module.py we eliminate the min_versions property getter because the min_version property is now
  part of the intermediate representation.

BUG=#713
R=azani@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/2c2910c3e4821732b7660e362fad1f413c2f7349

[rudominer, 2016-03-24 16:55:41]

Patchset #1 (id:1) has been deleted

[rudominer, 2016-03-24 16:55:49]

Patchset #1 (id:20001) has been deleted

[rudominer, 2016-03-24 16:55:55]

Patchset #1 (id:40001) has been deleted

[rudominer, 2016-03-24 16:56:03]

Patchset #1 (id:60001) has been deleted

[rudominer, 2016-03-24 16:56:09]

Patchset #1 (id:80001) has been deleted

[rudominer, 2016-03-24 16:56:16]

Patchset #1 (id:100001) has been deleted

[rudominer, 2016-03-24 21:12:17]

Description was changed from

==========
Mojom backend: Stop re-computing version info and field packing data.

We have removed most of the logic from pack.py because these computations are
now being performed
in the front end. We have left the PackedStruct object because this is what the
code generators expect
but it is mostly populated now by copying data from the intermediate
representation. What remains in pack.py are two kinds of things:
- The function GetByteLayout(). This function synthesizes the byte layout for a
struct based on
equivalent data in the intermediate representation. This can be considered a
utility function that
backends need to implement. We might consider adding the byte layout to the
intermediate representation
but it would be redundant.
- The utility function GetPad() seems to be used directly by some of the code
generators.

 We would not want to add this redundant information to the intermediate
representation and so
we should just let

- struct.versions is
- the synthetic request and response structs for a method

BUG=#713
==========

to

==========
Mojom backend: Stop re-computing version info and field packing data.

We have removed most of the logic from pack.py because these computations are
now being performed
in the front end. We have left the PackedStruct object because this is what the
code generators expect
but it is mostly populated now by copying data from the intermediate
representation. What remains in pack.py are two kinds of things:
- The function GetByteLayout(). This function synthesizes the byte layout for a
struct based on
equivalent data in the intermediate representation. This can be considered a
utility function that
backends need to implement. We might consider adding the byte layout to the
intermediate representation
but it would be redundant.
- The utility function GetPad() seems to be used directly by some of the code
generators.

 We would not want to add this redundant information to the intermediate
representation and so
we should just let

- In pack.py we delete GetAlignmentForKind, GetFieldOffset, GetVersionInfo, and
most of the logic in the PackedStruct
  constructor.

- We delete pack_tests.py and pack_unittest.py. These tests have been ported to
Go tests in the frontend
  in https://codereview.chromium.org/1833593002/.

- In mojom_translator.py we translate the version_info field of a struct and the
offset, bit and
  min_version fields of a struct field.

- In generator.py we stop creating synthetic request and response parameter
structs and instead use
  the ones translated from the intermediate representation. Similarly we stop
computing struct.versions.

- We modify the logic in mojom_go_generatory.py so that rather than constructing
a new object
  to represent a synthetic parameter struct instead we use the object that has
been translated
  from the intermediate representation, because that object contains the packing
data.

- In module.py we eliminate the min_versions property getter because the
min_version property is not
  part of the intermediate representation.

BUG=#713
==========

[rudominer, 2016-03-24 21:23:29]

Description was changed from

==========
Mojom backend: Stop re-computing version info and field packing data.

We have removed most of the logic from pack.py because these computations are
now being performed
in the front end. We have left the PackedStruct object because this is what the
code generators expect
but it is mostly populated now by copying data from the intermediate
representation. What remains in pack.py are two kinds of things:
- The function GetByteLayout(). This function synthesizes the byte layout for a
struct based on
equivalent data in the intermediate representation. This can be considered a
utility function that
backends need to implement. We might consider adding the byte layout to the
intermediate representation
but it would be redundant.
- The utility function GetPad() seems to be used directly by some of the code
generators.

 We would not want to add this redundant information to the intermediate
representation and so
we should just let

- In pack.py we delete GetAlignmentForKind, GetFieldOffset, GetVersionInfo, and
most of the logic in the PackedStruct
  constructor.

- We delete pack_tests.py and pack_unittest.py. These tests have been ported to
Go tests in the frontend
  in https://codereview.chromium.org/1833593002/.

- In mojom_translator.py we translate the version_info field of a struct and the
offset, bit and
  min_version fields of a struct field.

- In generator.py we stop creating synthetic request and response parameter
structs and instead use
  the ones translated from the intermediate representation. Similarly we stop
computing struct.versions.

- We modify the logic in mojom_go_generatory.py so that rather than constructing
a new object
  to represent a synthetic parameter struct instead we use the object that has
been translated
  from the intermediate representation, because that object contains the packing
data.

- In module.py we eliminate the min_versions property getter because the
min_version property is not
  part of the intermediate representation.

BUG=#713
==========

to

==========
Mojom backend: Stop re-computing version info and field packing data.

We have removed most of the logic from pack.py because these computations are
now being performed
in the front end. What remains in pack.py is some additional re-organization of
the data from the
intermediate representation. As we start to build new-generation backends we can
re-visit the exact
shape of the data we put into the intermediate representation and perhaps some
more of this
reorganization logic might be moved to the front end:
 - We left the PackedStruct object because this is what the code generators
expect.
  It is mostly populated now by copying data from the intermediate
representation. 
 - We left the function GetByteLayout(). This function synthesizes the byte
layout for a struct based on
equivalent data in the intermediate representation. 
 - The utility function GetPad() seems to be used directly by some of the code
generators.

Summary of changes:

- In pack.py we delete GetAlignmentForKind, GetFieldOffset, GetVersionInfo, and
most of the logic in the PackedStruct
  constructor.

- We delete pack_tests.py and pack_unittest.py. These tests have been ported to
Go tests in the frontend
  in https://codereview.chromium.org/1833593002/.

- In mojom_translator.py we translate the version_info field of a struct and the
offset, bit and
  min_version fields of a struct field.

- In generator.py we stop creating synthetic request and response parameter
structs and instead use
  the ones translated from the intermediate representation. Similarly we stop
computing struct.versions.

- We modify the logic in mojom_go_generatory.py so that rather than constructing
a new object
  to represent a synthetic parameter struct instead we use the object that has
been translated
  from the intermediate representation, because that object contains the packing
data.

- In module.py we eliminate the min_versions property getter because the
min_version property is not
  part of the intermediate representation.

BUG=#713
==========

[rudominer, 2016-03-24 21:24:52]

Description was changed from

==========
Mojom backend: Stop re-computing version info and field packing data.

We have removed most of the logic from pack.py because these computations are
now being performed
in the front end. What remains in pack.py is some additional re-organization of
the data from the
intermediate representation. As we start to build new-generation backends we can
re-visit the exact
shape of the data we put into the intermediate representation and perhaps some
more of this
reorganization logic might be moved to the front end:
 - We left the PackedStruct object because this is what the code generators
expect.
  It is mostly populated now by copying data from the intermediate
representation. 
 - We left the function GetByteLayout(). This function synthesizes the byte
layout for a struct based on
equivalent data in the intermediate representation. 
 - The utility function GetPad() seems to be used directly by some of the code
generators.

Summary of changes:

- In pack.py we delete GetAlignmentForKind, GetFieldOffset, GetVersionInfo, and
most of the logic in the PackedStruct
  constructor.

- We delete pack_tests.py and pack_unittest.py. These tests have been ported to
Go tests in the frontend
  in https://codereview.chromium.org/1833593002/.

- In mojom_translator.py we translate the version_info field of a struct and the
offset, bit and
  min_version fields of a struct field.

- In generator.py we stop creating synthetic request and response parameter
structs and instead use
  the ones translated from the intermediate representation. Similarly we stop
computing struct.versions.

- We modify the logic in mojom_go_generatory.py so that rather than constructing
a new object
  to represent a synthetic parameter struct instead we use the object that has
been translated
  from the intermediate representation, because that object contains the packing
data.

- In module.py we eliminate the min_versions property getter because the
min_version property is not
  part of the intermediate representation.

BUG=#713
==========

to

==========
Mojom backend: Stop re-computing version info and field packing data.

We have removed most of the logic from pack.py because these computations are
now being performed
in the front end. What remains in pack.py is some logic to re-organize the data
from the
intermediate representation into a form that the code generators want. As we
start to build 
new-generation backends we can re-visit the exact shape of the data we put into
the 
intermediate representation and perhaps some more of this reorganization logic
might be
moved to the front end:
 - We left the PackedStruct object because this is what the code generators
expect.
  It is mostly populated now by copying data from the intermediate
representation. 
 - We left the function GetByteLayout(). This function synthesizes the byte
layout for a struct based on
equivalent data in the intermediate representation. 
 - The utility function GetPad() seems to be used directly by some of the code
generators.

Summary of changes:

- In pack.py we delete GetAlignmentForKind, GetFieldOffset, GetVersionInfo, and
most of the logic in the PackedStruct
  constructor.

- We delete pack_tests.py and pack_unittest.py. These tests have been ported to
Go tests in the frontend
  in https://codereview.chromium.org/1833593002/.

- In mojom_translator.py we translate the version_info field of a struct and the
offset, bit and
  min_version fields of a struct field.

- In generator.py we stop creating synthetic request and response parameter
structs and instead use
  the ones translated from the intermediate representation. Similarly we stop
computing struct.versions.

- We modify the logic in mojom_go_generatory.py so that rather than constructing
a new object
  to represent a synthetic parameter struct instead we use the object that has
been translated
  from the intermediate representation, because that object contains the packing
data.

- In module.py we eliminate the min_versions property getter because the
min_version property is not
  part of the intermediate representation.

BUG=#713
==========

[rudominer, 2016-03-24 21:26:37]

Description was changed from

==========
Mojom backend: Stop re-computing version info and field packing data.

We have removed most of the logic from pack.py because these computations are
now being performed
in the front end. What remains in pack.py is some logic to re-organize the data
from the
intermediate representation into a form that the code generators want. As we
start to build 
new-generation backends we can re-visit the exact shape of the data we put into
the 
intermediate representation and perhaps some more of this reorganization logic
might be
moved to the front end:
 - We left the PackedStruct object because this is what the code generators
expect.
  It is mostly populated now by copying data from the intermediate
representation. 
 - We left the function GetByteLayout(). This function synthesizes the byte
layout for a struct based on
equivalent data in the intermediate representation. 
 - The utility function GetPad() seems to be used directly by some of the code
generators.

Summary of changes:

- In pack.py we delete GetAlignmentForKind, GetFieldOffset, GetVersionInfo, and
most of the logic in the PackedStruct
  constructor.

- We delete pack_tests.py and pack_unittest.py. These tests have been ported to
Go tests in the frontend
  in https://codereview.chromium.org/1833593002/.

- In mojom_translator.py we translate the version_info field of a struct and the
offset, bit and
  min_version fields of a struct field.

- In generator.py we stop creating synthetic request and response parameter
structs and instead use
  the ones translated from the intermediate representation. Similarly we stop
computing struct.versions.

- We modify the logic in mojom_go_generatory.py so that rather than constructing
a new object
  to represent a synthetic parameter struct instead we use the object that has
been translated
  from the intermediate representation, because that object contains the packing
data.

- In module.py we eliminate the min_versions property getter because the
min_version property is not
  part of the intermediate representation.

BUG=#713
==========

to

==========
Mojom backend: Stop re-computing version info and field packing data.

We have removed most of the logic from pack.py because these computations are
now being performed
in the front end. What remains in pack.py is some logic to re-organize the data
from the
intermediate representation into a form that the code generators want. As we
start to build 
new-generation backends we can re-visit the exact shape of the data we put into
the 
intermediate representation and perhaps some more of this reorganization logic
might be
moved to the front end:
 - We left the PackedStruct object because this is what the code generators
expect.
  It is mostly populated now by copying data from the intermediate
representation. 
 - We left the function GetByteLayout(). This function synthesizes the byte
layout for a struct based on
equivalent data in the intermediate representation. 
 - The utility function GetPad() seems to be used directly by some of the code
generators.

Summary of changes:

- In pack.py we delete GetAlignmentForKind, GetFieldOffset, GetVersionInfo, and
most of the logic in the PackedStruct
  constructor.

- We delete pack_tests.py and pack_unittest.py. These tests have been ported to
Go tests in the frontend
  in https://codereview.chromium.org/1833593002/.

- In mojom_translator.py we translate the version_info field of a struct and the
offset, bit and
  min_version fields of a struct field.

- In generator.py we stop creating synthetic request and response parameter
structs and instead use
  the ones translated from the intermediate representation. Similarly we stop
computing struct.versions.

- We modify the logic in mojom_go_generatory.py so that rather than constructing
a new object
  to represent a synthetic parameter struct instead we use the object that has
been translated
  from the intermediate representation, because that object contains the packing
data.

- In module.py we eliminate the min_versions property getter because the
min_version property is now
  part of the intermediate representation.

BUG=#713
==========

[rudominer, 2016-03-24 21:26:57]

Patchset #1 (id:120001) has been deleted

[rudominer, 2016-03-24 21:27:06]

Patchset #1 (id:140001) has been deleted

[rudominer, 2016-03-24 21:27:14]

Patchset #1 (id:160001) has been deleted

[rudominer, 2016-03-25 07:01:32]

Patchset #2 (id:200001) has been deleted

[rudominer, 2016-03-25 07:01:41]

Patchset #2 (id:220001) has been deleted

[rudominer, 2016-03-25 07:18:18]

Patchset #1 (id:180001) has been deleted

[rudominer, 2016-03-25 15:14:35]

rudominer@chromium.org changed reviewers:
+ azani@chromium.org

[rudominer, 2016-03-25 15:14:36]

Hi Alex, ptal.

[azani, 2016-03-25 19:14:26]

lgtm

[rudominer, 2016-03-25 20:32:28]

Description was changed from

==========
Mojom backend: Stop re-computing version info and field packing data.

We have removed most of the logic from pack.py because these computations are
now being performed
in the front end. What remains in pack.py is some logic to re-organize the data
from the
intermediate representation into a form that the code generators want. As we
start to build 
new-generation backends we can re-visit the exact shape of the data we put into
the 
intermediate representation and perhaps some more of this reorganization logic
might be
moved to the front end:
 - We left the PackedStruct object because this is what the code generators
expect.
  It is mostly populated now by copying data from the intermediate
representation. 
 - We left the function GetByteLayout(). This function synthesizes the byte
layout for a struct based on
equivalent data in the intermediate representation. 
 - The utility function GetPad() seems to be used directly by some of the code
generators.

Summary of changes:

- In pack.py we delete GetAlignmentForKind, GetFieldOffset, GetVersionInfo, and
most of the logic in the PackedStruct
  constructor.

- We delete pack_tests.py and pack_unittest.py. These tests have been ported to
Go tests in the frontend
  in https://codereview.chromium.org/1833593002/.

- In mojom_translator.py we translate the version_info field of a struct and the
offset, bit and
  min_version fields of a struct field.

- In generator.py we stop creating synthetic request and response parameter
structs and instead use
  the ones translated from the intermediate representation. Similarly we stop
computing struct.versions.

- We modify the logic in mojom_go_generatory.py so that rather than constructing
a new object
  to represent a synthetic parameter struct instead we use the object that has
been translated
  from the intermediate representation, because that object contains the packing
data.

- In module.py we eliminate the min_versions property getter because the
min_version property is now
  part of the intermediate representation.

BUG=#713
==========

to

==========
Mojom backend: Stop re-computing version info and field packing data.

We have removed most of the logic from pack.py because these computations are
now being performed
in the front end. What remains in pack.py is some logic to re-organize the data
from the
intermediate representation into a form that the code generators want. As we
start to build
new-generation backends we can re-visit the exact shape of the data we put into
the
intermediate representation and perhaps some more of this reorganization logic
might be
moved to the front end:
 - We left the PackedStruct object because this is what the code generators
expect.
  It is mostly populated now by copying data from the intermediate
representation.
 - We left the function GetByteLayout(). This function synthesizes the byte
layout for a struct based on
equivalent data in the intermediate representation.
 - The utility function GetPad() seems to be used directly by some of the code
generators.

Summary of changes:

- In pack.py we delete GetAlignmentForKind, GetFieldOffset, GetVersionInfo, and
most of the logic in the PackedStruct
  constructor.

- We delete pack_tests.py and pack_unittest.py. These tests have been ported to
Go tests in the frontend
  in https://codereview.chromium.org/1833593002/.

- In mojom_translator.py we translate the version_info field of a struct and the
offset, bit and
  min_version fields of a struct field.

- In generator.py we stop creating synthetic request and response parameter
structs and instead use
  the ones translated from the intermediate representation. Similarly we stop
computing struct.versions.

- We modify the logic in mojom_go_generatory.py so that rather than constructing
a new object
  to represent a synthetic parameter struct instead we use the object that has
been translated
  from the intermediate representation, because that object contains the packing
data.

- In module.py we eliminate the min_versions property getter because the
min_version property is now
  part of the intermediate representation.

BUG=#713
R=azani@chromium.org

Committed:
https://chromium.googlesource.com/external/mojo/+/2c2910c3e4821732b7660e362fa...
==========

[rudominer, 2016-03-25 20:32:30]

Committed patchset #1 (id:240001) manually as
2c2910c3e4821732b7660e362fad1f413c2f7349 (presubmit successful).