Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: mojo/public/tools/bindings/pylib/mojom/generate/module.py

Issue 1824263002: Mojom backend: Stop re-computing version info and field packing data. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/tools/bindings/pylib/mojom/generate/module.py
diff --git a/mojo/public/tools/bindings/pylib/mojom/generate/module.py b/mojo/public/tools/bindings/pylib/mojom/generate/module.py
index 089ba8dee416d2bd3ad311d6bd5dabdb1aff183f..b4aa9d94916f50a2a76fba4e3905648029e99691 100644
--- a/mojo/public/tools/bindings/pylib/mojom/generate/module.py
+++ b/mojo/public/tools/bindings/pylib/mojom/generate/module.py
@@ -130,9 +130,6 @@ PRIMITIVES = (
)
-ATTRIBUTE_MIN_VERSION = 'MinVersion'
-
-
class NamedValue(object):
def __init__(self, module=None, parent_kind=None, name=None):
self.module = module
@@ -195,11 +192,6 @@ class Field(object):
self.default = default
self.attributes = attributes
- @property
- def min_version(self):
- return self.attributes.get(ATTRIBUTE_MIN_VERSION) \
- if self.attributes else None
-
class StructField(Field): pass
@@ -333,11 +325,6 @@ class Parameter(object):
self.default = default
self.attributes = attributes
- @property
- def min_version(self):
- return self.attributes.get(ATTRIBUTE_MIN_VERSION) \
- if self.attributes else None
-
class Method(object):
def __init__(self, interface, name, ordinal=None, attributes=None):
@@ -362,11 +349,6 @@ class Method(object):
self.response_parameters.append(parameter)
return parameter
- @property
- def min_version(self):
- return self.attributes.get(ATTRIBUTE_MIN_VERSION) \
- if self.attributes else None
-
class Interface(ReferenceKind):
ReferenceKind.AddSharedProperty('module')
@@ -411,11 +393,6 @@ class EnumField(object):
self.attributes = attributes
self.numeric_value = numeric_value
- @property
- def min_version(self):
- return self.attributes.get(ATTRIBUTE_MIN_VERSION) \
- if self.attributes else None
-
class Enum(Kind):
def __init__(self, name=None, module=None, attributes=None):

Powered by Google App Engine
This is Rietveld 408576698