Mojom backend: Stop re-computing version info and field packing data.

mojo/public/tools/bindings/pylib/mojom/generate/module.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This module's classes provide an interface to mojo modules. Modules are
 # collections of interfaces and structs to be used by mojo ipc clients and
 # servers.
 #
 # A simple interface would be created this way:
 # module = mojom.generate.module.Module('Foo')
@@ skipping 112 matching lines @@
   SHAREDBUFFER,
   NULLABLE_STRING,
   NULLABLE_HANDLE,
   NULLABLE_DCPIPE,
   NULLABLE_DPPIPE,
   NULLABLE_MSGPIPE,
   NULLABLE_SHAREDBUFFER
 )
 
 
-ATTRIBUTE_MIN_VERSION = 'MinVersion'
-
-
 class NamedValue(object):
   def __init__(self, module=None, parent_kind=None, name=None):
     self.module = module
     if module:
       self.namespace = module.namespace
     self.parent_kind = parent_kind
     self.name = name
     self.imported_from = None
 
   def GetSpec(self):
@@ skipping 42 matching lines @@
   def __init__(self, name=None, kind=None, ordinal=None, default=None,
                attributes=None):
     if self.__class__.__name__ == 'Field':
       raise Exception()
     self.name = name
     self.kind = kind
     self.ordinal = ordinal
     self.default = default
     self.attributes = attributes
 
-  @property
-  def min_version(self):
-    return self.attributes.get(ATTRIBUTE_MIN_VERSION) \
-        if self.attributes else None
-
 
 class StructField(Field): pass
 
 
 class UnionField(Field): pass
 
 
 class Struct(ReferenceKind):
   ReferenceKind.AddSharedProperty('name')
   ReferenceKind.AddSharedProperty('module')
@@ skipping 113 matching lines @@
 
 class Parameter(object):
   def __init__(self, name=None, kind=None, ordinal=None, default=None,
                attributes=None):
     self.name = name
     self.ordinal = ordinal
     self.kind = kind
     self.default = default
     self.attributes = attributes
 
-  @property
-  def min_version(self):
-    return self.attributes.get(ATTRIBUTE_MIN_VERSION) \
-        if self.attributes else None
-
 
 class Method(object):
   def __init__(self, interface, name, ordinal=None, attributes=None):
     self.interface = interface
     self.name = name
     self.ordinal = ordinal
     self.parameters = []
     self.response_parameters = None
     self.attributes = attributes
 
   def AddParameter(self, name, kind, ordinal=None, default=None,
                    attributes=None):
     parameter = Parameter(name, kind, ordinal, default, attributes)
     self.parameters.append(parameter)
     return parameter
 
   def AddResponseParameter(self, name, kind, ordinal=None, default=None,
                            attributes=None):
     if self.response_parameters == None:
       self.response_parameters = []
     parameter = Parameter(name, kind, ordinal, default, attributes)
     self.response_parameters.append(parameter)
     return parameter
 
-  @property
-  def min_version(self):
-    return self.attributes.get(ATTRIBUTE_MIN_VERSION) \
-        if self.attributes else None
-
 
 class Interface(ReferenceKind):
   ReferenceKind.AddSharedProperty('module')
   ReferenceKind.AddSharedProperty('name')
   ReferenceKind.AddSharedProperty('imported_from')
   ReferenceKind.AddSharedProperty('methods')
   ReferenceKind.AddSharedProperty('attributes')
   ReferenceKind.AddSharedProperty('constants')
   ReferenceKind.AddSharedProperty('enums')
   ReferenceKind.AddSharedProperty('type_key')
@@ skipping 24 matching lines @@
 
 
 class EnumField(object):
   def __init__(self, name=None, value=None, attributes=None,
                numeric_value=None):
     self.name = name
     self.value = value
     self.attributes = attributes
     self.numeric_value = numeric_value
 
-  @property
-  def min_version(self):
-    return self.attributes.get(ATTRIBUTE_MIN_VERSION) \
-        if self.attributes else None
-
 
 class Enum(Kind):
   def __init__(self, name=None, module=None, attributes=None):
     self.module = module
     self.name = name
     self.imported_from = None
     if name is not None:
       spec = 'x:' + name
     else:
       spec = None
@@ skipping 175 matching lines @@
 
 def IsCloneableKind(kind):
   return not ContainsHandles(kind, set())
 
 
 def HasCallbacks(interface):
   for method in interface.methods:
     if method.response_parameters != None:
       return True
   return False