Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 182383012: Have positionInParentBeforeNode() / positionInParentAfterNode() take a reference (Closed)

Created:
6 years, 9 months ago by Inactive
Modified:
6 years, 9 months ago
Reviewers:
adamk
CC:
blink-reviews, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, rwlbuis
Visibility:
Public.

Description

Have positionInParentBeforeNode() / positionInParentAfterNode() take a reference Have positionInParentBeforeNode() / positionInParentAfterNode() take a reference as the implementation expected the pointer to be non-null. This makes the code look safer. R=adamk@chromium.org, adamk Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168420

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -102 lines) Patch
M Source/core/dom/Position.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/dom/Position.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/PositionIterator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/ApplyStyleCommand.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/editing/CompositeEditCommand.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/CompositeEditCommand.cpp View 5 chunks +10 lines, -9 lines 0 comments Download
M Source/core/editing/CreateLinkCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/DeleteSelectionCommand.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M Source/core/editing/FormatBlockCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/FrameSelection.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/IndentOutdentCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/InsertLineBreakCommand.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/InsertListCommand.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/InsertListCommand.cpp View 6 chunks +11 lines, -10 lines 0 comments Download
M Source/core/editing/InsertParagraphSeparatorCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/InsertTextCommand.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/editing/ReplaceSelectionCommand.cpp View 7 chunks +13 lines, -12 lines 0 comments Download
M Source/core/editing/VisibleSelection.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/htmlediting.h View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/htmlediting.cpp View 9 chunks +26 lines, -30 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Inactive
6 years, 9 months ago (2014-03-04 05:11:10 UTC) #1
adamk
lgtm
6 years, 9 months ago (2014-03-04 19:50:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/182383012/1
6 years, 9 months ago (2014-03-04 19:51:22 UTC) #3
Inactive
6 years, 9 months ago (2014-03-05 03:00:26 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 manually as r168420 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698