Source/core/editing/FormatBlockCommand.cpp - Issue 182383012: Have positionInParentBeforeNode() / positionInParentAfterNode() take a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/FormatBlockCommand.cpp

Issue 182383012: Have positionInParentBeforeNode() / positionInParentAfterNode() take a reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/FormatBlockCommand.cpp

diff --git a/Source/core/editing/FormatBlockCommand.cpp b/Source/core/editing/FormatBlockCommand.cpp

index 5b3d1837ea1f29d74f7e6177d0ab8e8978cfd2a0..ac397a9ebf0ad8855764e157a02f368a0dbdc281 100644

--- a/Source/core/editing/FormatBlockCommand.cpp

+++ b/Source/core/editing/FormatBlockCommand.cpp

@@ -73,7 +73,7 @@ void FormatBlockCommand::formatRange(const Position& start, const Position& end,

RefPtr<Range> range = Range::create(document(), start, endOfSelection);

if (isElementForFormatBlock(refNode->tagQName()) && VisiblePosition(start) == startOfBlock(VisiblePosition(start))

- && (VisiblePosition(end) == endOfBlock(VisiblePosition(end)) || isNodeVisiblyContainedWithin(refNode, range.get()))

+ && (VisiblePosition(end) == endOfBlock(VisiblePosition(end)) || isNodeVisiblyContainedWithin(*refNode, *range))

&& refNode != root && !root->isDescendantOf(refNode)) {

// Already in a block element that only contains the current paragraph

if (refNode->hasTagName(tagName()))

« no previous file with comments | « Source/core/editing/DeleteSelectionCommand.cpp ('k') | Source/core/editing/FrameSelection.cpp » ('j') | no next file with comments »