Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: Source/core/editing/VisibleUnits.cpp

Issue 182383012: Have positionInParentBeforeNode() / positionInParentAfterNode() take a reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/editing/VisibleSelection.cpp ('k') | Source/core/editing/htmlediting.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/VisibleUnits.cpp
diff --git a/Source/core/editing/VisibleUnits.cpp b/Source/core/editing/VisibleUnits.cpp
index 8214b42adfb3e9bfbbf0b42e3721e9bc5bba7bcf..723a7c3e4acdb54e0924fd81f80c9d1b2d148f7e 100644
--- a/Source/core/editing/VisibleUnits.cpp
+++ b/Source/core/editing/VisibleUnits.cpp
@@ -952,7 +952,7 @@ VisiblePosition previousLinePosition(const VisiblePosition &visiblePosition, int
RenderObject& renderer = root->closestLeafChildForPoint(pointInLine, isEditablePosition(p))->renderer();
Node* node = renderer.node();
if (node && editingIgnoresContent(node))
- return VisiblePosition(positionInParentBeforeNode(node));
+ return VisiblePosition(positionInParentBeforeNode(*node));
return VisiblePosition(renderer.positionForPoint(pointInLine));
}
@@ -1010,7 +1010,7 @@ VisiblePosition nextLinePosition(const VisiblePosition &visiblePosition, int lin
RenderObject& renderer = root->closestLeafChildForPoint(pointInLine, isEditablePosition(p))->renderer();
Node* node = renderer.node();
if (node && editingIgnoresContent(node))
- return VisiblePosition(positionInParentBeforeNode(node));
+ return VisiblePosition(positionInParentBeforeNode(*node));
return VisiblePosition(renderer.positionForPoint(pointInLine));
}
« no previous file with comments | « Source/core/editing/VisibleSelection.cpp ('k') | Source/core/editing/htmlediting.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698