Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1823073004: Pass the time parameter to PrefServiceBridge.clearBrowsingData() explicitly. (Closed)

Created:
4 years, 9 months ago by msramek
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews, tim+watch_chromium.org, maxbogue+watch_chromium.org, plaree+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Pass the time parameter to PrefServiceBridge.clearBrowsingData() explicitly. The browsing data deletion on Android relied on the prefs::kDeleteTimePeriod to determine the time period selection, similarly as we do on Desktop. However, this is incorrect with respect to callsites in ChromeApplication and ConfirmImportSyncDataDialog, that rely on the time period used being EVERYTHING. Pass the time time period parameter explicitly, so that different callsites can specify which time period to use. BUG=595876 Review URL: https://codereview.chromium.org/1823593002 Cr-Commit-Position: refs/heads/master@{#382317} (cherry picked from commit 5f5b82dc246c721ceb634983719494519694e57b) Committed: https://chromium.googlesource.com/chromium/src/+/92a45e7a6ec4eaf2e37e7cc76aeadd6789a86b76

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
msramek
4 years, 9 months ago (2016-03-22 16:58:41 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
92a45e7a6ec4eaf2e37e7cc76aeadd6789a86b76.

Powered by Google App Engine
This is Rietveld 408576698