Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1016)

Side by Side Diff: chrome/browser/android/preferences/pref_service_bridge.cc

Issue 1823073004: Pass the time parameter to PrefServiceBridge.clearBrowsingData() explicitly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2661
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/sync/ui/ConfirmImportSyncDataDialog.java ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/preferences/pref_service_bridge.h" 5 #include "chrome/browser/android/preferences/pref_service_bridge.h"
6 6
7 #include <jni.h> 7 #include <jni.h>
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 534 matching lines...) Expand 10 before | Expand all | Expand 10 after
545 JNIEnv* env, 545 JNIEnv* env,
546 const JavaParamRef<jobject>& obj, 546 const JavaParamRef<jobject>& obj,
547 jint time_period) { 547 jint time_period) {
548 DCHECK_GE(time_period, 0); 548 DCHECK_GE(time_period, 0);
549 DCHECK_LE(time_period, BrowsingDataRemover::TIME_PERIOD_LAST); 549 DCHECK_LE(time_period, BrowsingDataRemover::TIME_PERIOD_LAST);
550 GetPrefService()->SetInteger(prefs::kDeleteTimePeriod, time_period); 550 GetPrefService()->SetInteger(prefs::kDeleteTimePeriod, time_period);
551 } 551 }
552 552
553 static void ClearBrowsingData(JNIEnv* env, 553 static void ClearBrowsingData(JNIEnv* env,
554 const JavaParamRef<jobject>& obj, 554 const JavaParamRef<jobject>& obj,
555 const JavaParamRef<jintArray>& data_types) { 555 const JavaParamRef<jintArray>& data_types,
556 jint time_period) {
556 BrowsingDataRemover* browsing_data_remover = 557 BrowsingDataRemover* browsing_data_remover =
557 BrowsingDataRemoverFactory::GetForBrowserContext(GetOriginalProfile()); 558 BrowsingDataRemoverFactory::GetForBrowserContext(GetOriginalProfile());
558 // ClearBrowsingDataObserver deletes itself when |browsing_data_remover| is 559 // ClearBrowsingDataObserver deletes itself when |browsing_data_remover| is
559 // done. 560 // done.
560 new ClearBrowsingDataObserver(env, obj, browsing_data_remover); 561 new ClearBrowsingDataObserver(env, obj, browsing_data_remover);
561 562
562 std::vector<int> data_types_vector; 563 std::vector<int> data_types_vector;
563 base::android::JavaIntArrayToIntVector(env, data_types, &data_types_vector); 564 base::android::JavaIntArrayToIntVector(env, data_types, &data_types_vector);
564 565
565 int remove_mask = 0; 566 int remove_mask = 0;
(...skipping 17 matching lines...) Expand all
583 break; 584 break;
584 case BOOKMARKS: 585 case BOOKMARKS:
585 // Bookmarks are deleted separately on the Java side. 586 // Bookmarks are deleted separately on the Java side.
586 NOTREACHED(); 587 NOTREACHED();
587 break; 588 break;
588 case NUM_TYPES: 589 case NUM_TYPES:
589 NOTREACHED(); 590 NOTREACHED();
590 } 591 }
591 } 592 }
592 593
593 int period_selected = GetPrefService()->GetInteger(prefs::kDeleteTimePeriod);
594 browsing_data_remover->Remove( 594 browsing_data_remover->Remove(
595 BrowsingDataRemover::Period( 595 BrowsingDataRemover::Period(
596 static_cast<BrowsingDataRemover::TimePeriod>(period_selected)), 596 static_cast<BrowsingDataRemover::TimePeriod>(time_period)),
597 remove_mask, BrowsingDataHelper::UNPROTECTED_WEB); 597 remove_mask, BrowsingDataHelper::UNPROTECTED_WEB);
598 } 598 }
599 599
600 static jboolean CanDeleteBrowsingHistory(JNIEnv* env, 600 static jboolean CanDeleteBrowsingHistory(JNIEnv* env,
601 const JavaParamRef<jobject>& obj) { 601 const JavaParamRef<jobject>& obj) {
602 return GetPrefService()->GetBoolean(prefs::kAllowDeletingBrowserHistory); 602 return GetPrefService()->GetBoolean(prefs::kAllowDeletingBrowserHistory);
603 } 603 }
604 604
605 static void SetAllowCookiesEnabled(JNIEnv* env, 605 static void SetAllowCookiesEnabled(JNIEnv* env,
606 const JavaParamRef<jobject>& obj, 606 const JavaParamRef<jobject>& obj,
(...skipping 429 matching lines...) Expand 10 before | Expand all | Expand 10 after
1036 1036
1037 return ConvertJavaStringToUTF8(android_permission); 1037 return ConvertJavaStringToUTF8(android_permission);
1038 } 1038 }
1039 1039
1040 static void SetSupervisedUserId(JNIEnv* env, 1040 static void SetSupervisedUserId(JNIEnv* env,
1041 const JavaParamRef<jobject>& obj, 1041 const JavaParamRef<jobject>& obj,
1042 const JavaParamRef<jstring>& pref) { 1042 const JavaParamRef<jstring>& pref) {
1043 GetPrefService()->SetString(prefs::kSupervisedUserId, 1043 GetPrefService()->SetString(prefs::kSupervisedUserId,
1044 ConvertJavaStringToUTF8(env, pref)); 1044 ConvertJavaStringToUTF8(env, pref));
1045 } 1045 }
OLDNEW
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/sync/ui/ConfirmImportSyncDataDialog.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698