Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: chrome/browser/android/preferences/pref_service_bridge.cc

Issue 1823073004: Pass the time parameter to PrefServiceBridge.clearBrowsingData() explicitly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2661
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/sync/ui/ConfirmImportSyncDataDialog.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/preferences/pref_service_bridge.cc
diff --git a/chrome/browser/android/preferences/pref_service_bridge.cc b/chrome/browser/android/preferences/pref_service_bridge.cc
index 6675341cd65bf26a19c256161904bce2b5f6cbed..2ab177e9eda131ee4191459b905450cb2fd00c80 100644
--- a/chrome/browser/android/preferences/pref_service_bridge.cc
+++ b/chrome/browser/android/preferences/pref_service_bridge.cc
@@ -552,7 +552,8 @@ static void SetBrowsingDataDeletionTimePeriod(
static void ClearBrowsingData(JNIEnv* env,
const JavaParamRef<jobject>& obj,
- const JavaParamRef<jintArray>& data_types) {
+ const JavaParamRef<jintArray>& data_types,
+ jint time_period) {
BrowsingDataRemover* browsing_data_remover =
BrowsingDataRemoverFactory::GetForBrowserContext(GetOriginalProfile());
// ClearBrowsingDataObserver deletes itself when |browsing_data_remover| is
@@ -590,10 +591,9 @@ static void ClearBrowsingData(JNIEnv* env,
}
}
- int period_selected = GetPrefService()->GetInteger(prefs::kDeleteTimePeriod);
browsing_data_remover->Remove(
BrowsingDataRemover::Period(
- static_cast<BrowsingDataRemover::TimePeriod>(period_selected)),
+ static_cast<BrowsingDataRemover::TimePeriod>(time_period)),
remove_mask, BrowsingDataHelper::UNPROTECTED_WEB);
}
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/sync/ui/ConfirmImportSyncDataDialog.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698