Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1822723003:
Add initial implementation of GrShape and GrStyle classes and tests (Closed)
DescriptionAdd initial implementation of GrShape and GrStyle classes and tests
The initial intent is to use GrShape to simplify the mask blur code paths. However, I also want to use this to explore a more unified drawing code flow for different geometry types. The goal is to have a single representation for geometries+styling that attempts to always keep the geometry in the simplest form (e.g. preferring rrects to paths). It also allows for converting styling information into modified geometry and for computing consistent keys.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1822723003
Committed: https://skia.googlesource.com/skia/+/c885dacfe4625af8b0e2e5c6e8a8ae8dc2d620a8
Committed: https://skia.googlesource.com/skia/+/824e58fc6df8fc149d9675f577f7deeaba698b09
Committed: https://skia.googlesource.com/skia/+/47cc7691181e3c9d74f7d66d5bc3c0b7ac7855d5
Patch Set 1 #Patch Set 2 : cleanup #Patch Set 3 : more cleanup #
Total comments: 38
Patch Set 4 : Address comments #Patch Set 5 : Attempt to address windows complaint with SkTLazy #Patch Set 6 : Give up on union #Patch Set 7 : more post-union cleanup #Patch Set 8 : rm extra test_basic call #Patch Set 9 : Fix MSVC error for no message to SkFail #Patch Set 10 : Attempt to satisfy MSVC errors #Patch Set 11 : Attempt to fix VS2013 build #Patch Set 12 : Fix dumb SkDEBUGCODE mistake #
Dependent Patchsets: Messages
Total messages: 49 (27 generated)
Description was changed from ========== working on tests BUG=skia: ========== to ========== working on tests BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== working on tests BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Add GrShape and GrStyle classes and tests The initial intent is to use GrShape to simplify the mask blur code paths. However, I also want to use this to explore a more unified drawing code flow for different geometry types. The goal is to have a single representation for geometries+styling that attempts to always keep the geometry in the simplest form (e.g. preferring rrects to paths). It also allows for converting styling information into modified geometry and for computing consistent keys. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Patchset #4 (id:60001) has been deleted
Patchset #3 (id:40001) has been deleted
Patchset #2 (id:20001) has been deleted
Patchset #1 (id:1) has been deleted
Description was changed from ========== Add GrShape and GrStyle classes and tests The initial intent is to use GrShape to simplify the mask blur code paths. However, I also want to use this to explore a more unified drawing code flow for different geometry types. The goal is to have a single representation for geometries+styling that attempts to always keep the geometry in the simplest form (e.g. preferring rrects to paths). It also allows for converting styling information into modified geometry and for computing consistent keys. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Add initial implementation of GrShape and GrStyle classes and tests The initial intent is to use GrShape to simplify the mask blur code paths. However, I also want to use this to explore a more unified drawing code flow for different geometry types. The goal is to have a single representation for geometries+styling that attempts to always keep the geometry in the simplest form (e.g. preferring rrects to paths). It also allows for converting styling information into modified geometry and for computing consistent keys. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
bsalomon@google.com changed reviewers: + egdaniel@google.com, robertphillips@google.com
This is just a starting point. There is much more functionality and testing remaining to be implemented. I mostly am concerned about the interfaces and the overall idea. To use this even just for the mask filter code more functionality is required (e.g. I don't currently allow a shape to be publicly constructed from a path directly or detect paths that are actually simpler shapes). One advantage of this approach is that all the styling/keying stuff is much easier to unit test than our current implementations embedded in rendering routines.
Not quite done yet ... https://codereview.chromium.org/1822723003/diff/120001/src/gpu/GrShape.cpp File src/gpu/GrShape.cpp (right): https://codereview.chromium.org/1822723003/diff/120001/src/gpu/GrShape.cpp#ne... src/gpu/GrShape.cpp:124: memcpy(&key[i], intervals, intervalByteCnt); I'm not sure what this comment is saying https://codereview.chromium.org/1822723003/diff/120001/src/gpu/GrShape.cpp#ne... src/gpu/GrShape.cpp:139: rm this space ? https://codereview.chromium.org/1822723003/diff/120001/src/gpu/GrShape.h File src/gpu/GrShape.h (right): https://codereview.chromium.org/1822723003/diff/120001/src/gpu/GrShape.h#newc... src/gpu/GrShape.h:24: * when styling information is applied to produce a new shape then the style has been converted shapes -> shape's https://codereview.chromium.org/1822723003/diff/120001/src/gpu/GrShape.h#newc... src/gpu/GrShape.h:71: /** fully ? https://codereview.chromium.org/1822723003/diff/120001/src/gpu/GrShape.h#newc... src/gpu/GrShape.h:72: * Returns a GrShape where the shape's geometry full reflects the original shape's GrStyle. shap -> shape ? https://codereview.chromium.org/1822723003/diff/120001/src/gpu/GrStyle.h File src/gpu/GrStyle.h (right): https://codereview.chromium.org/1822723003/diff/120001/src/gpu/GrStyle.h#newc... src/gpu/GrStyle.h:21: * This object does not support stroke-and-fill styling. It is expected that stroking and filling separately https://codereview.chromium.org/1822723003/diff/120001/src/gpu/GrStyle.h#newc... src/gpu/GrStyle.h:36: Do we need the init of fStrokeRec? https://codereview.chromium.org/1822723003/diff/120001/src/gpu/GrStyle.h#newc... src/gpu/GrStyle.h:41: explicit GrStyle(const SkPaint& paint) put this on line above ?
lgtm https://codereview.chromium.org/1822723003/diff/120001/src/gpu/GrShape.cpp File src/gpu/GrShape.cpp (right): https://codereview.chromium.org/1822723003/diff/120001/src/gpu/GrShape.cpp#ne... src/gpu/GrShape.cpp:167: // The full key is structured as geo,path_effect,stroke. get get, -> get geo, ? Maybe a paren or "" delimiters around the key (like you do lower down) to offset it from the rest of the text? https://codereview.chromium.org/1822723003/diff/120001/src/gpu/GrShape.cpp#ne... src/gpu/GrShape.cpp:168: // If we do ApplyPathEffect we get get,path_effect as the inherited key. If we then as into -> into ? https://codereview.chromium.org/1822723003/diff/120001/src/gpu/GrShape.cpp#ne... src/gpu/GrShape.cpp:171: int parentCnt = parent.fInheritedKey.count(); rm extra ' ' ? https://codereview.chromium.org/1822723003/diff/120001/src/gpu/GrShape.cpp#ne... src/gpu/GrShape.cpp:233: fPath.~SkPath(); won't falling through here be bad ? https://codereview.chromium.org/1822723003/diff/120001/tests/GrShapeTest.cpp File tests/GrShapeTest.cpp (right): https://codereview.chromium.org/1822723003/diff/120001/tests/GrShapeTest.cpp#... tests/GrShapeTest.cpp:81: REPORTER_ASSERT(reporter, fAppliedPEThenStrokeKey == one line ? https://codereview.chromium.org/1822723003/diff/120001/tests/GrShapeTest.cpp#... tests/GrShapeTest.cpp:109: REPORTER_ASSERT(reporter, fAppliedPEKey != that.fAppliedPEKey); 1 line ? + the 3 clones below ? https://codereview.chromium.org/1822723003/diff/120001/tests/GrShapeTest.cpp#... tests/GrShapeTest.cpp:134: static ? https://codereview.chromium.org/1822723003/diff/120001/tests/GrShapeTest.cpp#... tests/GrShapeTest.cpp:140: static ? https://codereview.chromium.org/1822723003/diff/120001/tests/GrShapeTest.cpp#... tests/GrShapeTest.cpp:298: test_basic(reporter, rr); why two test_basic(reporter, rr) calls ? https://codereview.chromium.org/1822723003/diff/120001/tests/GrShapeTest.cpp#... tests/GrShapeTest.cpp:301: test_null_dash(reporter, rr); setting modifying -> modifying ?
https://codereview.chromium.org/1822723003/diff/120001/src/gpu/GrShape.cpp File src/gpu/GrShape.cpp (right): https://codereview.chromium.org/1822723003/diff/120001/src/gpu/GrShape.cpp#ne... src/gpu/GrShape.cpp:124: memcpy(&key[i], intervals, intervalByteCnt); On 2016/04/24 23:00:44, robertphillips wrote: > I'm not sure what this comment is saying I'll just rm it. I think it came in when I lifted some code from GrStrokeInfo and it may have made more sense there. Seems obvious enough. https://codereview.chromium.org/1822723003/diff/120001/src/gpu/GrShape.cpp#ne... src/gpu/GrShape.cpp:139: On 2016/04/24 23:00:44, robertphillips wrote: > rm this space ? Done. https://codereview.chromium.org/1822723003/diff/120001/src/gpu/GrShape.cpp#ne... src/gpu/GrShape.cpp:167: // The full key is structured as geo,path_effect,stroke. On 2016/04/25 12:07:06, robertphillips wrote: > get get, -> get geo, ? > > Maybe a paren or "" delimiters around the key (like you do lower down) to offset > it from the rest of the text? Done. https://codereview.chromium.org/1822723003/diff/120001/src/gpu/GrShape.cpp#ne... src/gpu/GrShape.cpp:168: // If we do ApplyPathEffect we get get,path_effect as the inherited key. If we then On 2016/04/25 12:07:06, robertphillips wrote: > as into -> into ? Done. https://codereview.chromium.org/1822723003/diff/120001/src/gpu/GrShape.cpp#ne... src/gpu/GrShape.cpp:171: int parentCnt = parent.fInheritedKey.count(); On 2016/04/25 12:07:06, robertphillips wrote: > rm extra ' ' ? Done. https://codereview.chromium.org/1822723003/diff/120001/src/gpu/GrShape.cpp#ne... src/gpu/GrShape.cpp:233: fPath.~SkPath(); On 2016/04/25 12:07:06, robertphillips wrote: > won't falling through here be bad ? Yes, added return. I'll add a unit test for this in the next round of changes. https://codereview.chromium.org/1822723003/diff/120001/src/gpu/GrShape.h File src/gpu/GrShape.h (right): https://codereview.chromium.org/1822723003/diff/120001/src/gpu/GrShape.h#newc... src/gpu/GrShape.h:24: * when styling information is applied to produce a new shape then the style has been converted On 2016/04/24 23:00:44, robertphillips wrote: > shapes -> shape's Done. https://codereview.chromium.org/1822723003/diff/120001/src/gpu/GrShape.h#newc... src/gpu/GrShape.h:71: /** On 2016/04/24 23:00:44, robertphillips wrote: > fully ? Done. https://codereview.chromium.org/1822723003/diff/120001/src/gpu/GrShape.h#newc... src/gpu/GrShape.h:72: * Returns a GrShape where the shape's geometry full reflects the original shape's GrStyle. On 2016/04/24 23:00:44, robertphillips wrote: > shap -> shape ? Done. https://codereview.chromium.org/1822723003/diff/120001/src/gpu/GrStyle.h File src/gpu/GrStyle.h (right): https://codereview.chromium.org/1822723003/diff/120001/src/gpu/GrStyle.h#newc... src/gpu/GrStyle.h:21: * This object does not support stroke-and-fill styling. It is expected that stroking and filling On 2016/04/24 23:00:44, robertphillips wrote: > separately Done. https://codereview.chromium.org/1822723003/diff/120001/src/gpu/GrStyle.h#newc... src/gpu/GrStyle.h:36: On 2016/04/24 23:00:44, robertphillips wrote: > Do we need the init of fStrokeRec? Yep, it has no default cons. https://codereview.chromium.org/1822723003/diff/120001/src/gpu/GrStyle.h#newc... src/gpu/GrStyle.h:41: explicit GrStyle(const SkPaint& paint) On 2016/04/24 23:00:44, robertphillips wrote: > put this on line above ? Done. https://codereview.chromium.org/1822723003/diff/120001/tests/GrShapeTest.cpp File tests/GrShapeTest.cpp (right): https://codereview.chromium.org/1822723003/diff/120001/tests/GrShapeTest.cpp#... tests/GrShapeTest.cpp:81: REPORTER_ASSERT(reporter, fAppliedPEThenStrokeKey == On 2016/04/25 12:07:06, robertphillips wrote: > one line ? Done. https://codereview.chromium.org/1822723003/diff/120001/tests/GrShapeTest.cpp#... tests/GrShapeTest.cpp:109: REPORTER_ASSERT(reporter, fAppliedPEKey != that.fAppliedPEKey); On 2016/04/25 12:07:06, robertphillips wrote: > 1 line ? + the 3 clones below ? Done. https://codereview.chromium.org/1822723003/diff/120001/tests/GrShapeTest.cpp#... tests/GrShapeTest.cpp:134: On 2016/04/25 12:07:06, robertphillips wrote: > static ? Done. https://codereview.chromium.org/1822723003/diff/120001/tests/GrShapeTest.cpp#... tests/GrShapeTest.cpp:140: On 2016/04/25 12:07:06, robertphillips wrote: > static ? Done. https://codereview.chromium.org/1822723003/diff/120001/tests/GrShapeTest.cpp#... tests/GrShapeTest.cpp:298: test_basic(reporter, rr); On 2016/04/25 12:07:06, robertphillips wrote: > why two test_basic(reporter, rr) calls ? Done. https://codereview.chromium.org/1822723003/diff/120001/tests/GrShapeTest.cpp#... tests/GrShapeTest.cpp:301: test_null_dash(reporter, rr); On 2016/04/25 12:07:06, robertphillips wrote: > setting modifying -> modifying ? Done.
The CQ bit was checked by bsalomon@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1822723003/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1822723003/140001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)
The CQ bit was checked by bsalomon@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1822723003/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1822723003/160001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)
The CQ bit was checked by bsalomon@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1822723003/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1822723003/200001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...) Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)
The CQ bit was checked by bsalomon@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1822723003/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1822723003/240001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)
https://codereview.chromium.org/1822723003/diff/120001/src/gpu/GrStyle.h File src/gpu/GrStyle.h (right): https://codereview.chromium.org/1822723003/diff/120001/src/gpu/GrStyle.h#newc... src/gpu/GrStyle.h:36: On 2016/04/25 13:32:27, bsalomon wrote: > On 2016/04/24 23:00:44, robertphillips wrote: > > Do we need the init of fStrokeRec? > > Yep, it has no default cons. But aren't we just going to overwrite anything it does?
https://codereview.chromium.org/1822723003/diff/120001/src/gpu/GrStyle.h File src/gpu/GrStyle.h (right): https://codereview.chromium.org/1822723003/diff/120001/src/gpu/GrStyle.h#newc... src/gpu/GrStyle.h:36: On 2016/04/25 14:13:44, robertphillips wrote: > On 2016/04/25 13:32:27, bsalomon wrote: > > On 2016/04/24 23:00:44, robertphillips wrote: > > > Do we need the init of fStrokeRec? > > > > Yep, it has no default cons. > > But aren't we just going to overwrite anything it does? Ah, forget it - I looked at the class.
The CQ bit was checked by bsalomon@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from robertphillips@google.com Link to the patchset: https://codereview.chromium.org/1822723003/#ps260001 (title: "Attempt to satisfy MSVC errors")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1822723003/260001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1822723003/260001
Message was sent while issue was closed.
Description was changed from ========== Add initial implementation of GrShape and GrStyle classes and tests The initial intent is to use GrShape to simplify the mask blur code paths. However, I also want to use this to explore a more unified drawing code flow for different geometry types. The goal is to have a single representation for geometries+styling that attempts to always keep the geometry in the simplest form (e.g. preferring rrects to paths). It also allows for converting styling information into modified geometry and for computing consistent keys. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Add initial implementation of GrShape and GrStyle classes and tests The initial intent is to use GrShape to simplify the mask blur code paths. However, I also want to use this to explore a more unified drawing code flow for different geometry types. The goal is to have a single representation for geometries+styling that attempts to always keep the geometry in the simplest form (e.g. preferring rrects to paths). It also allows for converting styling information into modified geometry and for computing consistent keys. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/c885dacfe4625af8b0e2e5c6e8a8ae8dc2d620a8 ==========
Message was sent while issue was closed.
Committed patchset #10 (id:260001) as https://skia.googlesource.com/skia/+/c885dacfe4625af8b0e2e5c6e8a8ae8dc2d620a8
Message was sent while issue was closed.
A revert of this CL (patchset #10 id:260001) has been created in https://codereview.chromium.org/1918203002/ by robertphillips@google.com. The reason for reverting is: From what I can tell, this compiles on 2015 but not 2013..
Message was sent while issue was closed.
Description was changed from ========== Add initial implementation of GrShape and GrStyle classes and tests The initial intent is to use GrShape to simplify the mask blur code paths. However, I also want to use this to explore a more unified drawing code flow for different geometry types. The goal is to have a single representation for geometries+styling that attempts to always keep the geometry in the simplest form (e.g. preferring rrects to paths). It also allows for converting styling information into modified geometry and for computing consistent keys. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/c885dacfe4625af8b0e2e5c6e8a8ae8dc2d620a8 ========== to ========== Add initial implementation of GrShape and GrStyle classes and tests The initial intent is to use GrShape to simplify the mask blur code paths. However, I also want to use this to explore a more unified drawing code flow for different geometry types. The goal is to have a single representation for geometries+styling that attempts to always keep the geometry in the simplest form (e.g. preferring rrects to paths). It also allows for converting styling information into modified geometry and for computing consistent keys. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/c885dacfe4625af8b0e2e5c6e8a8ae8dc2d620a8 ==========
The CQ bit was checked by bsalomon@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from robertphillips@google.com Link to the patchset: https://codereview.chromium.org/1822723003/#ps280001 (title: "Attempt to fix VS2013 build")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1822723003/280001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1822723003/280001
Message was sent while issue was closed.
Description was changed from ========== Add initial implementation of GrShape and GrStyle classes and tests The initial intent is to use GrShape to simplify the mask blur code paths. However, I also want to use this to explore a more unified drawing code flow for different geometry types. The goal is to have a single representation for geometries+styling that attempts to always keep the geometry in the simplest form (e.g. preferring rrects to paths). It also allows for converting styling information into modified geometry and for computing consistent keys. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/c885dacfe4625af8b0e2e5c6e8a8ae8dc2d620a8 ========== to ========== Add initial implementation of GrShape and GrStyle classes and tests The initial intent is to use GrShape to simplify the mask blur code paths. However, I also want to use this to explore a more unified drawing code flow for different geometry types. The goal is to have a single representation for geometries+styling that attempts to always keep the geometry in the simplest form (e.g. preferring rrects to paths). It also allows for converting styling information into modified geometry and for computing consistent keys. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/c885dacfe4625af8b0e2e5c6e8a8ae8dc2d620a8 Committed: https://skia.googlesource.com/skia/+/824e58fc6df8fc149d9675f577f7deeaba698b09 ==========
Message was sent while issue was closed.
Committed patchset #11 (id:280001) as https://skia.googlesource.com/skia/+/824e58fc6df8fc149d9675f577f7deeaba698b09
Message was sent while issue was closed.
A revert of this CL (patchset #11 id:280001) has been created in https://codereview.chromium.org/1919243002/ by bsalomon@google.com. The reason for reverting is: test failing.
Message was sent while issue was closed.
Description was changed from ========== Add initial implementation of GrShape and GrStyle classes and tests The initial intent is to use GrShape to simplify the mask blur code paths. However, I also want to use this to explore a more unified drawing code flow for different geometry types. The goal is to have a single representation for geometries+styling that attempts to always keep the geometry in the simplest form (e.g. preferring rrects to paths). It also allows for converting styling information into modified geometry and for computing consistent keys. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/c885dacfe4625af8b0e2e5c6e8a8ae8dc2d620a8 Committed: https://skia.googlesource.com/skia/+/824e58fc6df8fc149d9675f577f7deeaba698b09 ========== to ========== Add initial implementation of GrShape and GrStyle classes and tests The initial intent is to use GrShape to simplify the mask blur code paths. However, I also want to use this to explore a more unified drawing code flow for different geometry types. The goal is to have a single representation for geometries+styling that attempts to always keep the geometry in the simplest form (e.g. preferring rrects to paths). It also allows for converting styling information into modified geometry and for computing consistent keys. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/c885dacfe4625af8b0e2e5c6e8a8ae8dc2d620a8 Committed: https://skia.googlesource.com/skia/+/824e58fc6df8fc149d9675f577f7deeaba698b09 ==========
The CQ bit was checked by bsalomon@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from robertphillips@google.com Link to the patchset: https://codereview.chromium.org/1822723003/#ps300001 (title: "Fix dumb SkDEBUGCODE mistake")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1822723003/300001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1822723003/300001
Message was sent while issue was closed.
Description was changed from ========== Add initial implementation of GrShape and GrStyle classes and tests The initial intent is to use GrShape to simplify the mask blur code paths. However, I also want to use this to explore a more unified drawing code flow for different geometry types. The goal is to have a single representation for geometries+styling that attempts to always keep the geometry in the simplest form (e.g. preferring rrects to paths). It also allows for converting styling information into modified geometry and for computing consistent keys. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/c885dacfe4625af8b0e2e5c6e8a8ae8dc2d620a8 Committed: https://skia.googlesource.com/skia/+/824e58fc6df8fc149d9675f577f7deeaba698b09 ========== to ========== Add initial implementation of GrShape and GrStyle classes and tests The initial intent is to use GrShape to simplify the mask blur code paths. However, I also want to use this to explore a more unified drawing code flow for different geometry types. The goal is to have a single representation for geometries+styling that attempts to always keep the geometry in the simplest form (e.g. preferring rrects to paths). It also allows for converting styling information into modified geometry and for computing consistent keys. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/c885dacfe4625af8b0e2e5c6e8a8ae8dc2d620a8 Committed: https://skia.googlesource.com/skia/+/824e58fc6df8fc149d9675f577f7deeaba698b09 Committed: https://skia.googlesource.com/skia/+/47cc7691181e3c9d74f7d66d5bc3c0b7ac7855d5 ==========
Message was sent while issue was closed.
Committed patchset #12 (id:300001) as https://skia.googlesource.com/skia/+/47cc7691181e3c9d74f7d66d5bc3c0b7ac7855d5 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
