Add support for building GrShape from SkPath and more tests

Add support for building GrShape from SkPath and more tests
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1922713002

Committed: https://skia.googlesource.com/skia/+/72dc51c288169f38177c71081090581c5ff415b1

[bsalomon, 2016-04-25 20:37:48]

Description was changed from

==========
Add support for building GrShape from SkPath and more tests
==========

to

==========
Add support for building GrShape from SkPath and more tests
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-04-26 13:09:52]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-26 13:09:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1922713002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1922713002/1

[commit-bot: I haz the power, 2016-04-26 13:11:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-26 13:11:07]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_...)
  Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)
  Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[bsalomon, 2016-04-26 21:00:35]

bsalomon@google.com changed reviewers:
+ egdaniel@google.com, robertphilips@google.com

[bsalomon, 2016-04-26 21:01:10]

Description was changed from

==========
Add support for building GrShape from SkPath and more tests
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add support for building GrShape from SkPath and more tests
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2016-04-26 21:01:10]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com
- robertphilips@google.com

[bsalomon, 2016-04-26 21:15:17]

The CQ bit was checked by bsalomon@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-26 21:15:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1922713002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1922713002/60001

[commit-bot: I haz the power, 2016-04-26 21:28:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-26 21:28:58]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-04-26 22:18:32]

lgtm

https://codereview.chromium.org/1922713002/diff/60001/src/gpu/GrShape.h
File src/gpu/GrShape.h (right):

https://codereview.chromium.org/1922713002/diff/60001/src/gpu/GrShape.h#newco...
src/gpu/GrShape.h:39: explicit GrShape(const SkRect& rect) :
fType(Type::kRRect), fRRect(SkRRect::MakeRect(rect)) {}
No un-styled variants ?

https://codereview.chromium.org/1922713002/diff/60001/tests/GrShapeTest.cpp
File tests/GrShapeTest.cpp (right):

https://codereview.chromium.org/1922713002/diff/60001/tests/GrShapeTest.cpp#n...
tests/GrShapeTest.cpp:436: /** This path effect should make the keys invalid
when it is applied. */
Could you expand on this a bit?

https://codereview.chromium.org/1922713002/diff/60001/tests/GrShapeTest.cpp#n...
tests/GrShapeTest.cpp:508: const SkPath& path = testPath.fPath;
Theses tests all that the ?

[bsalomon, 2016-04-27 13:27:54]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-04-27 13:27:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1922713002/#ps80001
(title: "Address comments")

[commit-bot: I haz the power, 2016-04-27 13:28:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1922713002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1922713002/80001

[commit-bot: I haz the power, 2016-04-27 13:46:26]

Description was changed from

==========
Add support for building GrShape from SkPath and more tests
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add support for building GrShape from SkPath and more tests
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/72dc51c288169f38177c71081090581c5ff415b1
==========

[commit-bot: I haz the power, 2016-04-27 13:46:27]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/72dc51c288169f38177c71081090581c5ff415b1

[bsalomon, 2016-04-29 23:12:06]

https://codereview.chromium.org/1922713002/diff/60001/src/gpu/GrShape.h
File src/gpu/GrShape.h (right):

https://codereview.chromium.org/1922713002/diff/60001/src/gpu/GrShape.h#newco...
src/gpu/GrShape.h:39: explicit GrShape(const SkRect& rect) :
fType(Type::kRRect), fRRect(SkRRect::MakeRect(rect)) {}
On 2016/04/26 22:18:32, robertphillips wrote:
> No un-styled variants ?

Done.

https://codereview.chromium.org/1922713002/diff/60001/tests/GrShapeTest.cpp
File tests/GrShapeTest.cpp (right):

https://codereview.chromium.org/1922713002/diff/60001/tests/GrShapeTest.cpp#n...
tests/GrShapeTest.cpp:436: /** This path effect should make the keys invalid
when it is applied. */
On 2016/04/26 22:18:32, robertphillips wrote:
> Could you expand on this a bit?

Done.

     // This path effect should make the keys invalid when it is applied. We
only produce a pathe
     // effect key for dash path effects. So the only way another arbitrary path
effect can produce
     // a styled result with a key is to produce a non-path shape that has a
purely geometric key.

https://codereview.chromium.org/1922713002/diff/60001/tests/GrShapeTest.cpp#n...
tests/GrShapeTest.cpp:508: const SkPath& path = testPath.fPath;
On 2016/04/26 22:18:32, robertphillips wrote:
> Theses tests all that the ?

Done.

"These tests all assume that"