Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 1822663002: [es6] Rebaseline tests of 'instanceof' error messages. (Closed)

Created:
4 years, 9 months ago by Michael Starzinger
Modified:
4 years, 9 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_instanceof-prepare-tests-1
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Rebaseline tests of 'instanceof' error messages. This rebaselines all our internal tests for error messages thrown by the implementation of 'instanceof' to the new ES6 semantics. It also applies a minor rephrasing to the messages in question. R=rossberg@chromium.org BUG=v8:4447 LOG=n Committed: https://crrev.com/02a015b1c163f2242b969b4ebe20a32a85986ac2 Cr-Commit-Position: refs/heads/master@{#34940}

Patch Set 1 #

Patch Set 2 : One more test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -14 lines) Patch
M src/messages.h View 3 chunks +4 lines, -2 lines 0 comments Download
M test/message/instanceof-noncallable.out View 1 chunk +2 lines, -2 lines 0 comments Download
M test/message/instanceof-nonobject.out View 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/messages.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/exception-for-nonobject.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/webkit/exception-for-nonobject-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/instance-of-immediates.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/webkit/instance-of-immediates-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
Michael Starzinger
4 years, 9 months ago (2016-03-21 12:40:26 UTC) #1
rossberg
lgtm
4 years, 9 months ago (2016-03-21 12:41:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1822663002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1822663002/20001
4 years, 9 months ago (2016-03-21 13:38:28 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-21 14:00:47 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 14:02:00 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/02a015b1c163f2242b969b4ebe20a32a85986ac2
Cr-Commit-Position: refs/heads/master@{#34940}

Powered by Google App Engine
This is Rietveld 408576698