Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1816063002: [interpreter] Prepare for shipping --harmony-instanceof. (Closed)

Created:
4 years, 9 months ago by Michael Starzinger
Modified:
4 years, 9 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Prepare for shipping --harmony-instanceof. R=rmcilroy@chromium.org TEST=cctest/test-interpreter/InterpreterInstanceOf BUG=v8:4447 LOG=n Committed: https://crrev.com/f1d04af52fb7c06b8ae23e6e68ce5a2f820df579 Cr-Commit-Position: refs/heads/master@{#34933}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 1 chunk +5 lines, -0 lines 2 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (2 generated)
Michael Starzinger
4 years, 9 months ago (2016-03-21 10:41:01 UTC) #1
rmcilroy
LGTM, thanks. https://codereview.chromium.org/1816063002/diff/1/test/cctest/interpreter/test-interpreter.cc File test/cctest/interpreter/test-interpreter.cc (right): https://codereview.chromium.org/1816063002/diff/1/test/cctest/interpreter/test-interpreter.cc#newcode1457 test/cctest/interpreter/test-interpreter.cc:1457: FLAG_harmony_instanceof = false; (fine to do this ...
4 years, 9 months ago (2016-03-21 11:53:26 UTC) #2
Michael Starzinger
https://codereview.chromium.org/1816063002/diff/1/test/cctest/interpreter/test-interpreter.cc File test/cctest/interpreter/test-interpreter.cc (right): https://codereview.chromium.org/1816063002/diff/1/test/cctest/interpreter/test-interpreter.cc#newcode1457 test/cctest/interpreter/test-interpreter.cc:1457: FLAG_harmony_instanceof = false; On 2016/03/21 11:53:26, rmcilroy wrote: > ...
4 years, 9 months ago (2016-03-21 12:00:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1816063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1816063002/1
4 years, 9 months ago (2016-03-21 12:00:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-21 12:08:22 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 12:09:17 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f1d04af52fb7c06b8ae23e6e68ce5a2f820df579
Cr-Commit-Position: refs/heads/master@{#34933}

Powered by Google App Engine
This is Rietveld 408576698