Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: src/messages.h

Issue 1822663002: [es6] Rebaseline tests of 'instanceof' error messages. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_instanceof-prepare-tests-1
Patch Set: One more test. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/message/instanceof-noncallable.out » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/messages.h
diff --git a/src/messages.h b/src/messages.h
index 2a5748c039f975c9821fd93c316fd359d50c5846..23aab886ce34f96690b548e6fea8df424981334e 100644
--- a/src/messages.h
+++ b/src/messages.h
@@ -94,7 +94,8 @@ class CallSite {
T(ArrayFunctionsOnSealed, "Cannot add/remove sealed array elements") \
T(ArrayNotSubclassable, "Subclassing Arrays is not currently supported.") \
T(CalledNonCallable, "% is not a function") \
- T(CalledNonCallableInstanceOf, "right-hand side is not a function") \
+ T(CalledNonCallableInstanceOf, \
+ "Right-hand side of 'instanceof' is not callable") \
T(CalledOnNonObject, "% called on non-object") \
T(CalledOnNullOrUndefined, "% called on null or undefined") \
T(CallSiteExpectsFunction, \
@@ -147,6 +148,8 @@ class CallSite {
T(NoAccess, "no access") \
T(NonCoercible, "Cannot match against 'undefined' or 'null'.") \
T(NonExtensibleProto, "% is not extensible") \
+ T(NonObjectInInstanceOfCheck, \
+ "Right-hand side of 'instanceof' is not an object") \
T(NonObjectPropertyLoad, "Cannot read property '%' of %") \
T(NonObjectPropertyStore, "Cannot set property '%' of %") \
T(NoSetterInCallback, "Cannot set property % of % which has only a getter") \
@@ -461,7 +464,6 @@ class CallSite {
T(UnterminatedTemplate, "Unterminated template literal") \
T(UnterminatedTemplateExpr, "Missing } in template expression") \
T(FoundNonCallableHasInstance, "Found non-callable @@hasInstance") \
- T(NonObjectInInstanceOfCheck, "right-hand side is not an object") \
/* EvalError */ \
T(CodeGenFromStrings, "%") \
/* URIError */ \
« no previous file with comments | « no previous file | test/message/instanceof-noncallable.out » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698