Remove most uses of UnescapeRule::URL_SPECIAL_CHARS outside net/.

Remove some uses of UnescapeRule::URL_SPECIAL_CHARS outside net/.

We're removing this, in favor of PATH_SEPARATORS and
URL_SPECIAL_CHARS_EXCEPT_PATH_SEPARATORS, to reduce the
risk of security issues when unescaping, going forward.

BUG=589257
Committed: https://crrev.com/7447f3680fa750cec9dbe27e062a51b5cf8a7e57
Cr-Commit-Position: refs/heads/master@{#382935}

[mmenke, 2016-03-23 16:17:45]

Description was changed from

==========
Remove most uses of UnescapeRule::URL_SPECIAL_CHARS outside net/.

We're removing this, in favor of PATH_SEPARATORS and
URL_SPECIAL_CHARS_EXCEPT_PATH_SEPARATORS, to reduce the
risk of security issues when unescaping, going forward.

BUG=589257
==========

to

==========
Remove some uses of UnescapeRule::URL_SPECIAL_CHARS outside net/.

We're removing this, in favor of PATH_SEPARATORS and
URL_SPECIAL_CHARS_EXCEPT_PATH_SEPARATORS, to reduce the
risk of security issues when unescaping, going forward.

BUG=589257
==========

[mmenke, 2016-03-23 16:22:29]

mmenke@chromium.org changed reviewers:
+ avi@chromium.org, estade@chromium.org, rogerta@chromium.org

[mmenke, 2016-03-23 16:22:30]

[avi]:  Please review content/ (3 files, no change in behavior, only
	content/browser/web_contents/web_drag_source_mac.mm isn't a test-only class)
[rogerta]:  Please review
google_apis/gcm/engine/registration_request_unittest.cc.
[estade]:  Please review ui/base/webui/web_ui_util.cc.

https://codereview.chromium.org/1820333003/diff/10001/content/browser/web_con...
File content/browser/web_contents/web_drag_source_mac.mm (right):

https://codereview.chromium.org/1820333003/diff/10001/content/browser/web_con...
content/browser/web_contents/web_drag_source_mac.mm:178:
net::UnescapeRule::URL_SPECIAL_CHARS_EXCEPT_PATH_SEPARATORS |
Unescaping path separators is always fine for Javascript URLs.

https://codereview.chromium.org/1820333003/diff/10001/ui/base/webui/web_ui_ut...
File ui/base/webui/web_ui_util.cc (right):

https://codereview.chromium.org/1820333003/diff/10001/ui/base/webui/web_ui_ut...
ui/base/webui/web_ui_util.cc:96:
(net::UnescapeRule::URL_SPECIAL_CHARS_EXCEPT_PATH_SEPARATORS |
I don't think unescaping "/" and "\" gets us anything here, though happy to add
them, if I'm missing something.

[Avi (use Gerrit), 2016-03-23 16:30:59]

content lgtm

[Roger Tawa OOO till Jul 10th, 2016-03-23 16:40:17]

google_apis lgtm

[Evan Stade, 2016-03-23 18:58:08]

lgtm

https://codereview.chromium.org/1820333003/diff/10001/ui/base/webui/web_ui_ut...
File ui/base/webui/web_ui_util.cc (right):

https://codereview.chromium.org/1820333003/diff/10001/ui/base/webui/web_ui_ut...
ui/base/webui/web_ui_util.cc:96:
(net::UnescapeRule::URL_SPECIAL_CHARS_EXCEPT_PATH_SEPARATORS |
nit: there is an extra set of parens around the bits

I am not sure offhand, but EXCEPT_PATH_SEPARATORS is probably fine

[mmenke, 2016-03-23 19:06:30]

Thanks!

https://codereview.chromium.org/1820333003/diff/10001/ui/base/webui/web_ui_ut...
File ui/base/webui/web_ui_util.cc (right):

https://codereview.chromium.org/1820333003/diff/10001/ui/base/webui/web_ui_ut...
ui/base/webui/web_ui_util.cc:96:
(net::UnescapeRule::URL_SPECIAL_CHARS_EXCEPT_PATH_SEPARATORS |
On 2016/03/23 18:58:08, Evan Stade wrote:
> nit: there is an extra set of parens around the bits
> 
> I am not sure offhand, but EXCEPT_PATH_SEPARATORS is probably fine

I just kept the extra parens from before...  I'll go ahead and remove them.

I looked at the code, and it had no special handling of "/", "\", or "%", so
unescaping path separators seemed unnecessary.

[mmenke, 2016-03-23 19:07:33]

The CQ bit was checked by mmenke@chromium.org

[mmenke, 2016-03-23 19:07:33]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org,
rogerta@chromium.org, estade@chromium.org
Link to the patchset: https://codereview.chromium.org/1820333003/#ps50001
(title: "Oops...format")

[commit-bot: I haz the power, 2016-03-23 19:08:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1820333003/50001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1820333003/50001

[commit-bot: I haz the power, 2016-03-23 22:06:53]

Description was changed from

==========
Remove some uses of UnescapeRule::URL_SPECIAL_CHARS outside net/.

We're removing this, in favor of PATH_SEPARATORS and
URL_SPECIAL_CHARS_EXCEPT_PATH_SEPARATORS, to reduce the
risk of security issues when unescaping, going forward.

BUG=589257
==========

to

==========
Remove some uses of UnescapeRule::URL_SPECIAL_CHARS outside net/.

We're removing this, in favor of PATH_SEPARATORS and
URL_SPECIAL_CHARS_EXCEPT_PATH_SEPARATORS, to reduce the
risk of security issues when unescaping, going forward.

BUG=589257
==========

[commit-bot: I haz the power, 2016-03-23 22:06:54]

Committed patchset #4 (id:50001)

[commit-bot: I haz the power, 2016-03-23 22:08:16]

Description was changed from

==========
Remove some uses of UnescapeRule::URL_SPECIAL_CHARS outside net/.

We're removing this, in favor of PATH_SEPARATORS and
URL_SPECIAL_CHARS_EXCEPT_PATH_SEPARATORS, to reduce the
risk of security issues when unescaping, going forward.

BUG=589257
==========

to

==========
Remove some uses of UnescapeRule::URL_SPECIAL_CHARS outside net/.

We're removing this, in favor of PATH_SEPARATORS and
URL_SPECIAL_CHARS_EXCEPT_PATH_SEPARATORS, to reduce the
risk of security issues when unescaping, going forward.

BUG=589257

Committed: https://crrev.com/7447f3680fa750cec9dbe27e062a51b5cf8a7e57
Cr-Commit-Position: refs/heads/master@{#382935}
==========

[commit-bot: I haz the power, 2016-03-23 22:08:17]

Patchset 4 (id:??) landed as
https://crrev.com/7447f3680fa750cec9dbe27e062a51b5cf8a7e57
Cr-Commit-Position: refs/heads/master@{#382935}