Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Side by Side Diff: google_apis/gcm/engine/registration_request_unittest.cc

Issue 1820333003: Remove most uses of UnescapeRule::URL_SPECIAL_CHARS outside net/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Oops...format Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/test/mock_google_streaming_server.cc ('k') | ui/base/webui/web_ui_util.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stdint.h> 5 #include <stdint.h>
6 #include <map> 6 #include <map>
7 #include <string> 7 #include <string>
8 #include <utility> 8 #include <utility>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 174
175 // Verify data was formatted properly. 175 // Verify data was formatted properly.
176 std::string upload_data = fetcher->upload_data(); 176 std::string upload_data = fetcher->upload_data();
177 base::StringTokenizer data_tokenizer(upload_data, "&="); 177 base::StringTokenizer data_tokenizer(upload_data, "&=");
178 178
179 // Skip all tokens until you hit entry for senders. 179 // Skip all tokens until you hit entry for senders.
180 while (data_tokenizer.GetNext() && data_tokenizer.token() != "sender") 180 while (data_tokenizer.GetNext() && data_tokenizer.token() != "sender")
181 continue; 181 continue;
182 182
183 ASSERT_TRUE(data_tokenizer.GetNext()); 183 ASSERT_TRUE(data_tokenizer.GetNext());
184 std::string senders(net::UnescapeURLComponent(data_tokenizer.token(), 184 std::string senders(net::UnescapeURLComponent(
185 net::UnescapeRule::URL_SPECIAL_CHARS)); 185 data_tokenizer.token(),
186 net::UnescapeRule::PATH_SEPARATORS |
187 net::UnescapeRule::URL_SPECIAL_CHARS_EXCEPT_PATH_SEPARATORS));
186 base::StringTokenizer sender_tokenizer(senders, ","); 188 base::StringTokenizer sender_tokenizer(senders, ",");
187 ASSERT_TRUE(sender_tokenizer.GetNext()); 189 ASSERT_TRUE(sender_tokenizer.GetNext());
188 EXPECT_EQ("sender1", sender_tokenizer.token()); 190 EXPECT_EQ("sender1", sender_tokenizer.token());
189 ASSERT_TRUE(sender_tokenizer.GetNext()); 191 ASSERT_TRUE(sender_tokenizer.GetNext());
190 EXPECT_EQ("sender2@gmail.com", sender_tokenizer.token()); 192 EXPECT_EQ("sender2@gmail.com", sender_tokenizer.token());
191 } 193 }
192 194
193 TEST_F(GCMRegistrationRequestTest, ResponseParsing) { 195 TEST_F(GCMRegistrationRequestTest, ResponseParsing) {
194 CreateRequest("sender1,sender2"); 196 CreateRequest("sender1,sender2");
195 request_->Start(); 197 request_->Start();
(...skipping 316 matching lines...) Expand 10 before | Expand all | Expand 10 after
512 514
513 SetResponse(net::HTTP_OK, "token=2501"); 515 SetResponse(net::HTTP_OK, "token=2501");
514 CompleteFetch(); 516 CompleteFetch();
515 517
516 EXPECT_TRUE(callback_called_); 518 EXPECT_TRUE(callback_called_);
517 EXPECT_EQ(RegistrationRequest::SUCCESS, status_); 519 EXPECT_EQ(RegistrationRequest::SUCCESS, status_);
518 EXPECT_EQ("2501", registration_id_); 520 EXPECT_EQ("2501", registration_id_);
519 } 521 }
520 522
521 } // namespace gcm 523 } // namespace gcm
OLDNEW
« no previous file with comments | « content/test/mock_google_streaming_server.cc ('k') | ui/base/webui/web_ui_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698