Issue 1820083005: Remove platform/NotImplemented.*.

Issue 1820083005: Remove platform/NotImplemented.*. (Closed)

Created:
4 years, 9 months ago by tkent

Modified:
4 years, 9 months ago

Reviewers:
haraken, Yuta Kitamura

CC:
blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-events_chromium.org, blink-reviews-html_chromium.org, blink-reviews-platform-graphics_chromium.org, blink-worker-reviews_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dcheng, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, dtapuska+blinkwatch_chromium.org, eae+blinkwatch, falken, f(malita), horo+watch_chromium.org, jsbell+serviceworker_chromium.org, Justin Novosad, kinuko+serviceworker, kinuko+watch, kinuko+worker_chromium.org, michaeln, mlamouri+watch-blink_chromium.org, nhiroki, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, serviceworker-reviews, tzik

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove platform/NotImplemented.*. We can use NOTIMPLEMENTED() macro, defined in base/logging.h, in Blink. BUG=596760 Committed: https://crrev.com/cdc755c0552ebca53e2a86d678a3dd7f7f5dbcf6 Cr-Commit-Position: refs/heads/master@{#383029}

Patch Set 1 : #

Total comments: 1

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -158 lines)			Patch
M	third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	third_party/WebKit/Source/core/html/parser/HTMLTokenizer.cpp	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp	View	6 chunks	+5 lines, -6 lines	0 comments	Download
M	third_party/WebKit/Source/core/workers/WorkerObjectProxy.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	third_party/WebKit/Source/modules/mediacapturefromelement/CanvasCaptureMediaStreamTrack.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	third_party/WebKit/Source/modules/mediacapturefromelement/HTMLMediaElementCapture.cpp	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.cpp	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp	View	3 chunks	+2 lines, -3 lines	0 comments	Download
M	third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp	View	5 chunks	+4 lines, -5 lines	0 comments	Download
M	third_party/WebKit/Source/platform/Logging.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	third_party/WebKit/Source/platform/Logging.cpp	View	2 chunks	+0 lines, -4 lines	0 comments	Download
D	third_party/WebKit/Source/platform/NotImplemented.h	View	1 chunk	+0 lines, -50 lines	0 comments	Download
D	third_party/WebKit/Source/platform/NotImplemented.cpp	View	1 chunk	+0 lines, -41 lines	0 comments	Download
M	third_party/WebKit/Source/platform/PlatformKeyboardEvent.cpp	View	3 chunks	+2 lines, -4 lines	0 comments	Download
M	third_party/WebKit/Source/platform/blink_platform.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	third_party/WebKit/Source/web/WebViewImpl.cpp	View	2 chunks	+1 line, -2 lines	1 comment	Download
M	third_party/WebKit/Source/wtf/Assertions.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	third_party/WebKit/Source/wtf/Assertions.cpp	View	1 chunk	+0 lines, -13 lines	0 comments	Download

Messages

Total messages: 19 (10 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

haraken

LGTM https://codereview.chromium.org/1820083005/diff/20001/third_party/WebKit/Source/web/WebViewImpl.cpp File third_party/WebKit/Source/web/WebViewImpl.cpp (right): https://codereview.chromium.org/1820083005/diff/20001/third_party/WebKit/Source/web/WebViewImpl.cpp#newcode2705 third_party/WebKit/Source/web/WebViewImpl.cpp:2705: NOTIMPLEMENTED(); Not related to this CL, most of ...

4 years, 9 months ago (2016-03-24 04:09:58 UTC) #9

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1820083005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1820083005/20001

4 years, 9 months ago (2016-03-24 04:20:04 UTC) #12

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/cdc755c0552ebca53e2a86d678a3dd7f7f5dbcf6 Cr-Commit-Position: refs/heads/master@{#383029}

4 years, 9 months ago (2016-03-24 04:28:46 UTC) #15

Evan Stade

On 2016/03/24 04:28:46, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...

4 years, 9 months ago (2016-03-24 18:12:09 UTC) #16

Message was sent while issue was closed.

On 2016/03/24 04:28:46, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/cdc755c0552ebca53e2a86d678a3dd7f7f5dbcf6
> Cr-Commit-Position: refs/heads/master@{#383029}

this CL is causing insane amounts of logspam in my console:

[1:1:0324/111025:ERROR:HTMLTreeBuilder.cpp(1466)] Not implemented reached in
bool blink::HTMLTreeBuilder::processBodyEndTagForInBody(blink::AtomicHTMLToken
*)
[1:1:0324/111025:ERROR:HTMLTreeBuilder.cpp(2466)] Not implemented reached in
void blink::HTMLTreeBuilder::processEndOfFile(blink::AtomicHTMLToken *)
[1:1:0324/111025:ERROR:HTMLTreeBuilder.cpp(1466)] Not implemented reached in
bool blink::HTMLTreeBuilder::processBodyEndTagForInBody(blink::AtomicHTMLToken
*)
[1:1:0324/111025:ERROR:HTMLTreeBuilder.cpp(2466)] Not implemented reached in
void blink::HTMLTreeBuilder::processEndOfFile(blink::AtomicHTMLToken *)
[1:1:0324/111025:ERROR:HTMLTreeBuilder.cpp(2466)] Not implemented reached in
void blink::HTMLTreeBuilder::processEndOfFile(blink::AtomicHTMLToken *)
[1:1:0324/111025:ERROR:HTMLTreeBuilder.cpp(2466)] Not implemented reached in
void blink::HTMLTreeBuilder::processEndOfFile(blink::AtomicHTMLToken *)
[1:1:0324/111025:ERROR:HTMLTreeBuilder.cpp(2466)] Not implemented reached in
void blink::HTMLTreeBuilder::processEndOfFile(blink::AtomicHTMLToken *)
[1:1:0324/111025:ERROR:HTMLTreeBuilder.cpp(2466)] Not implemented reached in
void blink::HTMLTreeBuilder::processEndOfFile(blink::AtomicHTMLToken *)
[1:1:0324/111025:ERROR:HTMLTreeBuilder.cpp(2466)] Not implemented reached in
void blink::HTMLTreeBuilder::processEndOfFile(blink::AtomicHTMLToken *)
[1:1:0324/111025:ERROR:HTMLTreeBuilder.cpp(2466)] Not implemented reached in
void blink::HTMLTreeBuilder::processEndOfFile(blink::AtomicHTMLToken *)
[1:1:0324/111025:ERROR:HTMLTreeBuilder.cpp(2466)] Not implemented reached in
void blink::HTMLTreeBuilder::processEndOfFile(blink::AtomicHTMLToken *)

[1:1:0324/111026:ERROR:HTMLTreeBuilder.cpp(2525)] Not implemented reached in
void blink::HTMLTreeBuilder::defaultForInitial()

(ad nauseum)

any chance you can make it less verbose?

jbroman

On 2016/03/24 at 18:12:09, estade wrote: > On 2016/03/24 04:28:46, commit-bot: I haz the power ...

4 years, 9 months ago (2016-03-24 18:15:45 UTC) #17

Message was sent while issue was closed.

On 2016/03/24 at 18:12:09, estade wrote:
> On 2016/03/24 04:28:46, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/cdc755c0552ebca53e2a86d678a3dd7f7f5dbcf6
> > Cr-Commit-Position: refs/heads/master@{#383029}
> 
> this CL is causing insane amounts of logspam in my console:
> 
> [1:1:0324/111025:ERROR:HTMLTreeBuilder.cpp(1466)] Not implemented reached in
bool blink::HTMLTreeBuilder::processBodyEndTagForInBody(blink::AtomicHTMLToken
*)
> [1:1:0324/111025:ERROR:HTMLTreeBuilder.cpp(2466)] Not implemented reached in
void blink::HTMLTreeBuilder::processEndOfFile(blink::AtomicHTMLToken *)
> [1:1:0324/111025:ERROR:HTMLTreeBuilder.cpp(1466)] Not implemented reached in
bool blink::HTMLTreeBuilder::processBodyEndTagForInBody(blink::AtomicHTMLToken
*)
> [1:1:0324/111025:ERROR:HTMLTreeBuilder.cpp(2466)] Not implemented reached in
void blink::HTMLTreeBuilder::processEndOfFile(blink::AtomicHTMLToken *)
> [1:1:0324/111025:ERROR:HTMLTreeBuilder.cpp(2466)] Not implemented reached in
void blink::HTMLTreeBuilder::processEndOfFile(blink::AtomicHTMLToken *)
> [1:1:0324/111025:ERROR:HTMLTreeBuilder.cpp(2466)] Not implemented reached in
void blink::HTMLTreeBuilder::processEndOfFile(blink::AtomicHTMLToken *)
> [1:1:0324/111025:ERROR:HTMLTreeBuilder.cpp(2466)] Not implemented reached in
void blink::HTMLTreeBuilder::processEndOfFile(blink::AtomicHTMLToken *)
> [1:1:0324/111025:ERROR:HTMLTreeBuilder.cpp(2466)] Not implemented reached in
void blink::HTMLTreeBuilder::processEndOfFile(blink::AtomicHTMLToken *)
> [1:1:0324/111025:ERROR:HTMLTreeBuilder.cpp(2466)] Not implemented reached in
void blink::HTMLTreeBuilder::processEndOfFile(blink::AtomicHTMLToken *)
> [1:1:0324/111025:ERROR:HTMLTreeBuilder.cpp(2466)] Not implemented reached in
void blink::HTMLTreeBuilder::processEndOfFile(blink::AtomicHTMLToken *)
> [1:1:0324/111025:ERROR:HTMLTreeBuilder.cpp(2466)] Not implemented reached in
void blink::HTMLTreeBuilder::processEndOfFile(blink::AtomicHTMLToken *)
> 
> [1:1:0324/111026:ERROR:HTMLTreeBuilder.cpp(2525)] Not implemented reached in
void blink::HTMLTreeBuilder::defaultForInitial()
> 
> (ad nauseum)
> 
> any chance you can make it less verbose?

I filed https://bugs.chromium.org/p/chromium/issues/detail?id=597688 about this
issue.

Dirk Pranke

A revert of this CL (patchset #1 id:20001) has been created in https://codereview.chromium.org/1828353002/ by dpranke@chromium.org. ...

4 years, 9 months ago (2016-03-24 20:52:04 UTC) #18

Dirk Pranke

4 years, 9 months ago (2016-03-24 21:24:53 UTC) #19

Message was sent while issue was closed.

On 2016/03/24 20:52:04, Dirk Pranke wrote:
> A revert of this CL (patchset #1 id:20001) has been created in
> https://codereview.chromium.org/1828353002/ by mailto:dpranke@chromium.org.
> 
> The reason for reverting is: We seem to be hitting logging all over the place
> for this, which is making buildbot very unhappy. 
> 
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/6...
> 
> reverting for now..

I ended up reverting this in https://codereview.chromium.org/1826283004/
instead, along with reverting 
https://codereview.chromium.org/1828163002/ in order to get the reverts to apply
cleanly.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages