third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp - Issue 1820083005: Remove platform/NotImplemented.*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp

Issue 1820083005: Remove platform/NotImplemented.*. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp

index c14bd9f1258b40da79a7aad32ca852ffaa6d2ba6..212f5eb9f84f146b4c2a9ec0c27afa34b1dcaf4f 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp

@@ -68,7 +68,6 @@

#include "core/loader/ProgressTracker.h"

#include "core/plugins/PluginView.h"

#include "platform/Histogram.h"

-#include "platform/NotImplemented.h"

#include "platform/TraceEvent.h"

#include "platform/UserGestureIndicator.h"

#include "platform/Widget.h"

@@ -344,8 +343,8 @@ void ScriptController::registerExtensionIfNeeded(v8::Extension* extension)

static NPObject* createNoScriptObject()

{

- notImplemented();

- return 0;

+ NOTIMPLEMENTED();

+ return nullptr;

}

static NPObject* createScriptObject(LocalFrame* frame, v8::Isolate* isolate)