components/favicon/core/fallback_icon_service.cc - Issue 1819753003: Allow various font weights in gfx.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/favicon/core/fallback_icon_service.cc

Issue 1819753003: Allow various font weights in gfx. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add a lost comment and modify a render text unittest to not test black because of test env font con… Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/favicon/core/fallback_icon_service.cc

diff --git a/components/favicon/core/fallback_icon_service.cc b/components/favicon/core/fallback_icon_service.cc

index 25efd996ff684fd783876a33106d970b4efaaefe..283808858a55f34491e0c7e843eea6ff1df641c0 100644

--- a/components/favicon/core/fallback_icon_service.cc

+++ b/components/favicon/core/fallback_icon_service.cc

@@ -79,9 +79,8 @@ void FallbackIconService::DrawFallbackIcon(

canvas->DrawStringRectWithFlags(

icon_text,

gfx::FontList(fallback_icon_client_->GetFontNameList(), gfx::Font::NORMAL,

- font_size),

- style.text_color,

- gfx::Rect(kOffsetX, kOffsetY, size, size),

+ font_size, gfx::Font::Weight::NORMAL),

+ style.text_color, gfx::Rect(kOffsetX, kOffsetY, size, size),

gfx::Canvas::TEXT_ALIGN_CENTER);

}