chrome/renderer/pepper/pepper_flash_renderer_host.cc - Issue 1819753003: Allow various font weights in gfx.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/pepper/pepper_flash_renderer_host.cc

Issue 1819753003: Allow various font weights in gfx. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add a lost comment and modify a render text unittest to not test black because of test env font con… Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/pepper/pepper_flash_renderer_host.cc

diff --git a/chrome/renderer/pepper/pepper_flash_renderer_host.cc b/chrome/renderer/pepper/pepper_flash_renderer_host.cc

index 43d9f81c9e446011369fefb505769b01c8482fe8..d6e8de3c698e8a7001ab7481e6045b95f080bd2a 100644

--- a/chrome/renderer/pepper/pepper_flash_renderer_host.cc

+++ b/chrome/renderer/pepper/pepper_flash_renderer_host.cc

@@ -210,8 +210,8 @@ int32_t PepperFlashRendererHost::OnDrawGlyphs(

style |= SkTypeface::kBold;

if (params.font_desc.italic)

style |= SkTypeface::kItalic;

- sk_sp<SkTypeface> typeface(SkTypeface::CreateFromName(

- params.font_desc.face.c_str(), static_cast<SkTypeface::Style>(style)));

+ sk_sp<SkTypeface> typeface(SkTypeface::MakeFromName(

+ params.font_desc.face.c_str(), SkFontStyle::FromOldStyle(style)));

if (!typeface)

return PP_ERROR_FAILED;