content/browser/renderer_host/sandbox_ipc_linux.cc - Issue 1819753003: Allow various font weights in gfx.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/sandbox_ipc_linux.cc

Issue 1819753003: Allow various font weights in gfx. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add a lost comment and modify a render text unittest to not test black because of test env font con… Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/sandbox_ipc_linux.cc

diff --git a/content/browser/renderer_host/sandbox_ipc_linux.cc b/content/browser/renderer_host/sandbox_ipc_linux.cc

index 777c18bbad33af5bfce92c8f0b92e9d5fdd15db4..d27a2435547089c29237d067024191a309fb1f8b 100644

--- a/content/browser/renderer_host/sandbox_ipc_linux.cc

+++ b/content/browser/renderer_host/sandbox_ipc_linux.cc

@@ -284,8 +284,8 @@ void SandboxIPCHandler::HandleGetStyleForStrike(

gfx::FontRenderParamsQuery query;

query.families.push_back(family);

query.pixel_size = pixel_size;

- query.style = gfx::Font::NORMAL |

- (bold ? gfx::Font::BOLD : 0) | (italic ? gfx::Font::ITALIC : 0);

+ query.style = italic ? gfx::Font::ITALIC : 0;

+ query.weight = bold ? gfx::Font::Weight::BOLD : gfx::Font::Weight::NORMAL;

const gfx::FontRenderParams params = gfx::GetFontRenderParams(query, NULL);

// These are passed as ints since they're interpreted as tri-state chars in