chrome/browser/ui/webui/chromeos/login/network_dropdown.cc - Issue 1819753003: Allow various font weights in gfx.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/chromeos/login/network_dropdown.cc

Issue 1819753003: Allow various font weights in gfx. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add a lost comment and modify a render text unittest to not test black because of test env font con… Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/chromeos/login/network_dropdown.cc

diff --git a/chrome/browser/ui/webui/chromeos/login/network_dropdown.cc b/chrome/browser/ui/webui/chromeos/login/network_dropdown.cc

index 88395726ee9b25c0727543db85e6a0a1b87e201e..e18a15b8a300b8c548acf28aeabaf62e3f4fe922 100644

--- a/chrome/browser/ui/webui/chromeos/login/network_dropdown.cc

+++ b/chrome/browser/ui/webui/chromeos/login/network_dropdown.cc

@@ -102,7 +102,8 @@ base::ListValue* NetworkMenuWebUI::ConvertMenuModel(ui::MenuModel* model) {

item->SetBoolean("enabled", model->IsEnabledAt(i));

const gfx::FontList* font_list = model->GetLabelFontListAt(i);

if (font_list)

- item->SetBoolean("bold", font_list->GetFontStyle() == gfx::Font::BOLD);

+ item->SetBoolean("bold",

+ font_list->GetFontWeight() == gfx::Font::Weight::BOLD);

}

if (type == ui::MenuModel::TYPE_SUBMENU)

item->Set("sub", ConvertMenuModel(model->GetSubmenuModelAt(i)));